dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

Use V1 SchemaVersion when RemoveClientServiceNamesEnabled is true

Open bouwkast opened this issue 1 year ago • 8 comments

Summary of changes

Whenever RemoveClientServiceNamesEnabled is set to true force the SchemaVersion to be V1.

Reason for change

Without this the inferred service beta isn't working.

Implementation details

Added two checks when parsing the SchemaVersion to check RemoveClientServiceNamesEnabled and set to V1 whenever RemoveClientServiceNamesEnabled is true.

I looked at other libraries as how they implemented this and this seems to be how - the RFC(s) that I could find for this didn't seem to lay out exactly how this config was to work 😕

Test coverage

  • Updated the settings tests

Other details

https://datadoghq.atlassian.net/browse/AIT-10215 https://datadoghq.atlassian.net/browse/APMS-11941

bouwkast avatar May 01 '24 00:05 bouwkast

Datadog Report

Branch report: steven/schema-version-fix Commit report: 079f2ba Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 334092 Passed, 1553 Skipped, 42m 52.34s Wall Time

datadog-ddstaging[bot] avatar May 01 '24 00:05 datadog-ddstaging[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5521) - mean (71ms)  : 68, 74
     .   : milestone, 71,
    master - mean (74ms)  : 66, 82
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5521) - mean (1,018ms)  : 1000, 1037
     .   : milestone, 1018,
    master - mean (1,014ms)  : 989, 1040
     .   : milestone, 1014,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5521) - mean (109ms)  : 106, 113
     .   : milestone, 109,
    master - mean (110ms)  : 106, 114
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5521) - mean (730ms)  : 707, 753
     .   : milestone, 730,
    master - mean (730ms)  : 703, 758
     .   : milestone, 730,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5521) - mean (94ms)  : 90, 98
     .   : milestone, 94,
    master - mean (94ms)  : 91, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5521) - mean (685ms)  : 661, 708
     .   : milestone, 685,
    master - mean (684ms)  : 662, 705
     .   : milestone, 684,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5521) - mean (191ms)  : 188, 195
     .   : milestone, 191,
    master - mean (191ms)  : 187, 196
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5521) - mean (1,091ms)  : 1062, 1120
     .   : milestone, 1091,
    master - mean (1,092ms)  : 1067, 1118
     .   : milestone, 1092,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5521) - mean (277ms)  : 273, 281
     .   : milestone, 277,
    master - mean (275ms)  : 271, 279
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (5521) - mean (892ms)  : 869, 915
     .   : milestone, 892,
    master - mean (887ms)  : 862, 912
     .   : milestone, 887,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5521) - mean (264ms)  : 261, 268
     .   : milestone, 264,
    master - mean (264ms)  : 260, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (5521) - mean (869ms)  : 845, 893
     .   : milestone, 869,
    master - mean (868ms)  : 840, 896
     .   : milestone, 868,

andrewlock avatar May 01 '24 00:05 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #5521 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.146
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.96μs 51.5ns 385ns 0.0277 0.0111 0 7.56 KB
master StartStopWithChild netcoreapp3.1 11μs 62.3ns 413ns 0.0274 0.0109 0 7.65 KB
master StartStopWithChild net472 17.1μs 47.5ns 178ns 1.35 0.35 0.111 8.1 KB
#5521 StartStopWithChild net6.0 8.62μs 44.8ns 233ns 0.0246 0.0123 0 7.56 KB
#5521 StartStopWithChild netcoreapp3.1 10.9μs 61.7ns 414ns 0.0212 0.0106 0 7.65 KB
#5521 StartStopWithChild net472 17.3μs 31.8ns 123ns 1.38 0.414 0.112 8.11 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 482μs 173ns 669ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 625μs 390ns 1.51μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 824μs 850ns 3.06μs 0.408 0 0 3.3 KB
#5521 WriteAndFlushEnrichedTraces net6.0 458μs 81.6ns 305ns 0 0 0 2.7 KB
#5521 WriteAndFlushEnrichedTraces netcoreapp3.1 636μs 188ns 729ns 0 0 0 2.7 KB
#5521 WriteAndFlushEnrichedTraces net472 834μs 476ns 1.84μs 0.417 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 166μs 146ns 545ns 0.248 0 0 18.49 KB
master SendRequest netcoreapp3.1 193μs 267ns 1.03μs 0.194 0 0 20.65 KB
master SendRequest net472 0.0019ns 0.000809ns 0.00303ns 0 0 0 0 b
#5521 SendRequest net6.0 171μs 272ns 1.06μs 0.255 0 0 18.49 KB
#5521 SendRequest netcoreapp3.1 190μs 281ns 1.01μs 0.191 0 0 20.65 KB
#5521 SendRequest net472 0.00068ns 0.000302ns 0.00117ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 543μs 207ns 802ns 0.541 0 0 41.65 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 645μs 1.07μs 4μs 0.319 0 0 41.68 KB
master WriteAndFlushEnrichedTraces net472 874μs 4μs 15.5μs 8.36 2.64 0.44 53.23 KB
#5521 WriteAndFlushEnrichedTraces net6.0 537μs 1.27μs 4.91μs 0.539 0 0 41.48 KB
#5521 WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 2.44μs 9.43μs 0.322 0 0 41.82 KB
#5521 WriteAndFlushEnrichedTraces net472 845μs 3.6μs 14μs 8.28 2.48 0.414 53.26 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.19μs 0.525ns 2.03ns 0.0113 0 0 808 B
master ExecuteNonQuery netcoreapp3.1 1.53μs 1.41ns 5.46ns 0.0108 0 0 808 B
master ExecuteNonQuery net472 1.81μs 1.13ns 4.06ns 0.122 0 0 770 B
#5521 ExecuteNonQuery net6.0 1.15μs 3.9ns 15.1ns 0.0112 0 0 808 B
#5521 ExecuteNonQuery netcoreapp3.1 1.57μs 1.35ns 5.24ns 0.011 0 0 808 B
#5521 ExecuteNonQuery net472 1.84μs 0.624ns 2.16ns 0.122 0 0 770 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.36μs 0.922ns 3.45ns 0.0144 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 1.67μs 0.653ns 2.44ns 0.0142 0 0 1.03 KB
master CallElasticsearch net472 2.6μs 1.89ns 7.08ns 0.165 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.29μs 1.41ns 5.48ns 0.014 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 1.77μs 0.659ns 2.47ns 0.0142 0 0 1.08 KB
master CallElasticsearchAsync net472 2.67μs 1.67ns 6.47ns 0.174 0 0 1.1 KB
#5521 CallElasticsearch net6.0 1.33μs 0.498ns 1.87ns 0.0146 0 0 1.03 KB
#5521 CallElasticsearch netcoreapp3.1 1.63μs 1.67ns 6.45ns 0.0138 0 0 1.03 KB
#5521 CallElasticsearch net472 2.56μs 1.03ns 4.01ns 0.165 0 0 1.04 KB
#5521 CallElasticsearchAsync net6.0 1.38μs 0.72ns 2.69ns 0.0139 0 0 1.01 KB
#5521 CallElasticsearchAsync netcoreapp3.1 1.64μs 2.3ns 8.6ns 0.0149 0 0 1.08 KB
#5521 CallElasticsearchAsync net472 2.52μs 1.33ns 4.8ns 0.174 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.32μs 0.665ns 2.49ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.77μs 0.791ns 2.96ns 0.013 0 0 952 B
master ExecuteAsync net472 1.79μs 0.617ns 2.39ns 0.145 0 0 915 B
#5521 ExecuteAsync net6.0 1.4μs 1.05ns 4.07ns 0.0133 0 0 952 B
#5521 ExecuteAsync netcoreapp3.1 1.61μs 1.18ns 4.57ns 0.0128 0 0 952 B
#5521 ExecuteAsync net472 1.89μs 0.861ns 3.33ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.35μs 1.94ns 7.27ns 0.0304 0 0 2.27 KB
master SendAsync netcoreapp3.1 5.2μs 2.39ns 8.96ns 0.0366 0 0 2.81 KB
master SendAsync net472 7.89μs 3.84ns 14.4ns 0.503 0 0 3.18 KB
#5521 SendAsync net6.0 4.11μs 2.63ns 10.2ns 0.0309 0 0 2.27 KB
#5521 SendAsync netcoreapp3.1 5.17μs 2.56ns 9.22ns 0.0389 0 0 2.81 KB
#5521 SendAsync net472 7.91μs 4.67ns 18.1ns 0.502 0 0 3.18 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.59μs 0.799ns 2.99ns 0.0238 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 2.3μs 0.756ns 2.62ns 0.023 0 0 1.7 KB
master EnrichedLog net472 2.51μs 1.47ns 5.5ns 0.257 0 0 1.62 KB
#5521 EnrichedLog net6.0 1.52μs 0.301ns 1.08ns 0.0244 0 0 1.7 KB
#5521 EnrichedLog netcoreapp3.1 2.27μs 3ns 11.2ns 0.0236 0 0 1.7 KB
#5521 EnrichedLog net472 2.6μs 1.23ns 4.78ns 0.257 0 0 1.62 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 114μs 165ns 641ns 0.0571 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 127ns 492ns 0 0 0 4.28 KB
master EnrichedLog net472 150μs 184ns 712ns 0.67 0.223 0 4.46 KB
#5521 EnrichedLog net6.0 112μs 124ns 463ns 0.0561 0 0 4.28 KB
#5521 EnrichedLog netcoreapp3.1 118μs 121ns 421ns 0.0588 0 0 4.28 KB
#5521 EnrichedLog net472 150μs 100ns 389ns 0.671 0.224 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.99μs 1.33ns 4.96ns 0.0319 0 0 2.25 KB
master EnrichedLog netcoreapp3.1 4.22μs 3.86ns 14.9ns 0.0293 0 0 2.25 KB
master EnrichedLog net472 4.9μs 1.2ns 4.65ns 0.327 0 0 2.07 KB
#5521 EnrichedLog net6.0 2.98μs 1ns 3.75ns 0.0313 0 0 2.25 KB
#5521 EnrichedLog netcoreapp3.1 4.26μs 4.3ns 16.6ns 0.0297 0 0 2.25 KB
#5521 EnrichedLog net472 4.85μs 2.13ns 7.98ns 0.328 0 0 2.07 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.42μs 0.819ns 3.17ns 0.017 0 0 1.2 KB
master SendReceive netcoreapp3.1 1.86μs 2.34ns 9.08ns 0.0165 0 0 1.2 KB
master SendReceive net472 2.19μs 0.821ns 2.84ns 0.191 0.0011 0 1.2 KB
#5521 SendReceive net6.0 1.5μs 1.43ns 5.54ns 0.017 0 0 1.2 KB
#5521 SendReceive netcoreapp3.1 1.8μs 3.68ns 14.2ns 0.0163 0 0 1.2 KB
#5521 SendReceive net472 2.34μs 1.05ns 4.07ns 0.191 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.84μs 1.06ns 3.97ns 0.0227 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.96μs 2.48ns 9.28ns 0.0217 0 0 1.65 KB
master EnrichedLog net472 4.42μs 1.17ns 4.37ns 0.323 0 0 2.04 KB
#5521 EnrichedLog net6.0 2.78μs 1.01ns 3.79ns 0.0223 0 0 1.6 KB
#5521 EnrichedLog netcoreapp3.1 3.94μs 1.33ns 4.97ns 0.0218 0 0 1.65 KB
#5521 EnrichedLog net472 4.54μs 1.85ns 6.93ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5521

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.146 498.31 571.20

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 498ns 0.203ns 0.76ns 0.00819 0 0 576 B
master StartFinishSpan netcoreapp3.1 769ns 0.298ns 1.16ns 0.00768 0 0 576 B
master StartFinishSpan net472 732ns 0.444ns 1.72ns 0.0915 0 0 578 B
master StartFinishScope net6.0 591ns 1.8ns 6.99ns 0.0097 0 0 696 B
master StartFinishScope netcoreapp3.1 892ns 1.25ns 4.67ns 0.00928 0 0 696 B
master StartFinishScope net472 1.02μs 0.26ns 0.971ns 0.104 0 0 658 B
#5521 StartFinishSpan net6.0 571ns 0.166ns 0.622ns 0.00812 0 0 576 B
#5521 StartFinishSpan netcoreapp3.1 752ns 0.222ns 0.799ns 0.00786 0 0 576 B
#5521 StartFinishSpan net472 776ns 0.518ns 1.87ns 0.0917 0 0 578 B
#5521 StartFinishScope net6.0 566ns 0.463ns 1.67ns 0.00968 0 0 696 B
#5521 StartFinishScope netcoreapp3.1 910ns 0.496ns 1.92ns 0.00926 0 0 696 B
#5521 StartFinishScope net472 1.03μs 0.235ns 0.91ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 720ns 0.436ns 1.63ns 0.00965 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1μs 2.27ns 8.78ns 0.00947 0 0 696 B
master RunOnMethodBegin net472 1.14μs 0.907ns 3.51ns 0.104 0 0 658 B
#5521 RunOnMethodBegin net6.0 661ns 0.778ns 3.01ns 0.00963 0 0 696 B
#5521 RunOnMethodBegin netcoreapp3.1 915ns 0.585ns 2.27ns 0.0096 0 0 696 B
#5521 RunOnMethodBegin net472 1.15μs 0.325ns 1.22ns 0.104 0 0 658 B

andrewlock avatar May 01 '24 00:05 andrewlock

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5521) (11.702M)   : 0, 11702284
    master (11.965M)   : 0, 11964977
    benchmarks/2.9.0 (11.912M)   : 0, 11912338

    section Automatic
    This PR (5521) (7.987M)   : 0, 7987343
    master (8.118M)   : 0, 8117927
    benchmarks/2.9.0 (8.365M)   : 0, 8365219

    section Trace stats
    master (8.404M)   : 0, 8403784

    section Manual
    This PR (5521) (10.167M)   : 0, 10167465
    master (10.375M)   : 0, 10374864

    section Manual + Automatic
    This PR (5521) (7.537M)   : 0, 7536999
    master (7.592M)   : 0, 7592168

    section Version Conflict
    master (6.784M)   : 0, 6783630


gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5521) (9.560M)   : 0, 9560462
    master (9.523M)   : 0, 9522858
    benchmarks/2.9.0 (9.398M)   : 0, 9398075

    section Automatic
    This PR (5521) (6.496M)   : 0, 6496183
    master (6.598M)   : 0, 6597696

    section Trace stats
    master (6.854M)   : 0, 6854465

    section Manual
    This PR (5521) (8.131M)   : 0, 8131399
    master (8.288M)   : 0, 8288001

    section Manual + Automatic
    This PR (5521) (6.025M)   : 0, 6025290
    master (6.184M)   : 0, 6183503

    section Version Conflict
    master (5.444M)   : 0, 5443800


gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5521) (8.579M)   : 0, 8578916
    master (10.174M)   : 0, 10174265
    benchmarks/2.9.0 (9.898M)   : 0, 9898006

    section Automatic
    This PR (5521) (6.052M)   : crit ,0, 6051652
    master (7.175M)   : 0, 7175010
    benchmarks/2.9.0 (7.393M)   : 0, 7392571

    section Trace stats
    master (7.336M)   : 0, 7335733

    section Manual
    This PR (5521) (7.663M)   : crit ,0, 7663419
    master (8.899M)   : 0, 8899285

    section Manual + Automatic
    This PR (5521) (6.473M)   : crit ,0, 6473190
    master (6.824M)   : 0, 6824426

    section Version Conflict
    master (6.251M)   : 0, 6251275

andrewlock avatar May 01 '24 01:05 andrewlock

For reference:

  • https://github.com/DataDog/dd-trace-dotnet/blob/1ddd57628073106ec7da3b3828e1ff6dd5d4c748/tracer/src/Datadog.Trace/Configuration/Schema/ClientSchema.cs#L18
  • https://github.com/DataDog/dd-trace-dotnet/blob/1ddd57628073106ec7da3b3828e1ff6dd5d4c748/tracer/src/Datadog.Trace/Configuration/Schema/DatabaseSchema.cs#L20

bouwkast avatar May 02 '24 14:05 bouwkast

Isn't it the other way around, that enabling schema v1 enables several config knobs, including RemoveClientServiceNamesEnabled? (but each one of those can also be enabled individually?) cc @zacharycmontoya

lucaspimentel avatar May 02 '24 21:05 lucaspimentel

Isn't it the other way around, that enabling schema v1 enabled several config knobs, including RemoveClientServiceNamesEnabled? (but they can also be enabled individually?) cc @zacharycmontoya

This is something that I'm unsure on, so would greatly appreciate some additional insight, from all of the RFCs that I found on this weren't exactly clear and seemed to be out of date.

bouwkast avatar May 03 '24 13:05 bouwkast

I've added the status:do-not-merge label (not that it enforces anything at the moment...) because this particular scenario should be unblocked by ensuring the user is on the latest Inferred Services beta. If that doesn't resolve this use-case, we may consider merging this change

zacharycmontoya avatar May 09 '24 21:05 zacharycmontoya

No longer relevant

bouwkast avatar Feb 14 '25 22:02 bouwkast