dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

[NO MERGE] Just a test

Open gleocadie opened this issue 1 year ago • 3 comments

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

gleocadie avatar Apr 11 '24 19:04 gleocadie

Datadog Report

Branch report: gleocadie/test-to-retrieve-asan-binaries Commit report: ba818af Test service: dd-trace-dotnet

:x: 1 Failed (1 Known Flaky), 334549 Passed, 1788 Skipped, 46m 49.55s Wall Time

:x: Failed Tests (1)

  • CheckErrorWhenNoAgentIsAvailable - Datadog.Profiler.IntegrationTests.WindowsOnly.EtwEventsTests - :snowflake: Known flaky - Details

    Expand for error 
    xit code of "Samples.Computer01.exe" should be 0 instead of -1073741819 (= 0xC0000005)
xpected: True
ctual:   False

datadog-ddstaging[bot] avatar Apr 11 '24 19:04 datadog-ddstaging[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5435) - mean (73ms)  : 63, 83
     .   : milestone, 73,
    master - mean (74ms)  : 65, 84
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5435) - mean (1,014ms)  : 996, 1033
     .   : milestone, 1014,
    master - mean (1,019ms)  : 1003, 1034
     .   : milestone, 1019,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5435) - mean (109ms)  : 105, 113
     .   : milestone, 109,
    master - mean (113ms)  : 110, 116
     .   : milestone, 113,

    section CallTarget+Inlining+NGEN
    This PR (5435) - mean (739ms)  : 721, 758
     .   : milestone, 739,
    master - mean (748ms)  : 723, 773
     .   : milestone, 748,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5435) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (94ms)  : 90, 98
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5435) - mean (688ms)  : 664, 711
     .   : milestone, 688,
    master - mean (701ms)  : 671, 730
     .   : milestone, 701,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5435) - mean (188ms)  : 185, 190
     .   : milestone, 188,
    master - mean (188ms)  : 185, 190
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5435) - mean (1,089ms)  : 1066, 1113
     .   : milestone, 1089,
    master - mean (1,082ms)  : 1052, 1112
     .   : milestone, 1082,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5435) - mean (273ms)  : 269, 277
     .   : milestone, 273,
    master - mean (271ms)  : 267, 276
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (5435) - mean (885ms)  : 863, 907
     .   : milestone, 885,
    master - mean (892ms)  : 868, 917
     .   : milestone, 892,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5435) - mean (260ms)  : 257, 263
     .   : milestone, 260,
    master - mean (260ms)  : 256, 264
     .   : milestone, 260,

    section CallTarget+Inlining+NGEN
    This PR (5435) - mean (868ms)  : 836, 900
     .   : milestone, 868,
    master - mean (864ms)  : 838, 890
     .   : milestone, 864,

andrewlock avatar Apr 11 '24 19:04 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #5435 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.150
  • 1 benchmarks are slower, with geometric mean 1.202
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.59μs 46.9ns 366ns 0.0263 0.0131 0 7.54 KB
master StartStopWithChild netcoreapp3.1 10.5μs 53.2ns 238ns 0.0265 0.0106 0 7.63 KB
master StartStopWithChild net472 16.9μs 52.1ns 202ns 1.37 0.38 0.0908 8.08 KB
#5435 StartStopWithChild net6.0 8.76μs 40.7ns 207ns 0.0174 0.00868 0 7.54 KB
#5435 StartStopWithChild netcoreapp3.1 10.6μs 60.4ns 419ns 0.021 0.0105 0 7.64 KB
#5435 StartStopWithChild net472 16.8μs 32.7ns 118ns 1.34 0.344 0.109 8.08 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 480μs 179ns 693ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 640μs 268ns 1.04μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 821μs 237ns 918ns 0.406 0 0 3.3 KB
#5435 WriteAndFlushEnrichedTraces net6.0 462μs 286ns 1.11μs 0 0 0 2.7 KB
#5435 WriteAndFlushEnrichedTraces netcoreapp3.1 633μs 308ns 1.19μs 0 0 0 2.7 KB
#5435 WriteAndFlushEnrichedTraces net472 818μs 297ns 1.11μs 0.408 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 171μs 201ns 779ns 0.169 0 0 18.38 KB
master SendRequest netcoreapp3.1 189μs 179ns 669ns 0.19 0 0 20.54 KB
master SendRequest net472 0.000712ns 0.000206ns 0.000771ns 0 0 0 0 b
#5435 SendRequest net6.0 170μs 137ns 494ns 0.251 0 0 18.38 KB
#5435 SendRequest netcoreapp3.1 189μs 330ns 1.28μs 0.189 0 0 20.54 KB
#5435 SendRequest net472 7.38E‑05ns 7.38E‑05ns 0.000276ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5435

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.48 KB 41.75 KB 263 B 0.63%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 547μs 1.46μs 5.64μs 0.558 0 0 41.48 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 650μs 1.05μs 3.94μs 0.331 0 0 41.67 KB
master WriteAndFlushEnrichedTraces net472 847μs 3.94μs 15.8μs 8.39 2.52 0.419 53.23 KB
#5435 WriteAndFlushEnrichedTraces net6.0 547μs 1.92μs 7.42μs 0.561 0 0 41.75 KB
#5435 WriteAndFlushEnrichedTraces netcoreapp3.1 648μs 2.17μs 8.42μs 0.322 0 0 41.84 KB
#5435 WriteAndFlushEnrichedTraces net472 842μs 3.19μs 12.4μs 8.13 2.57 0.428 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.13μs 1.03ns 4ns 0.0108 0 0 800 B
master ExecuteNonQuery netcoreapp3.1 1.56μs 0.7ns 2.71ns 0.0109 0 0 800 B
master ExecuteNonQuery net472 1.79μs 0.719ns 2.78ns 0.121 0 0 762 B
#5435 ExecuteNonQuery net6.0 1.22μs 0.585ns 2.27ns 0.0111 0 0 800 B
#5435 ExecuteNonQuery netcoreapp3.1 1.52μs 0.545ns 2.11ns 0.0107 0 0 800 B
#5435 ExecuteNonQuery net472 1.82μs 1.19ns 4.3ns 0.121 0 0 762 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.31μs 0.837ns 3.13ns 0.0144 0 0 1.02 KB
master CallElasticsearch netcoreapp3.1 1.59μs 0.754ns 2.61ns 0.0135 0 0 1.02 KB
master CallElasticsearch net472 2.62μs 1.74ns 6.53ns 0.164 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.38μs 1.26ns 4.9ns 0.0138 0 0 1 KB
master CallElasticsearchAsync netcoreapp3.1 1.71μs 0.777ns 3.01ns 0.0146 0 0 1.07 KB
master CallElasticsearchAsync net472 2.6μs 1.11ns 4.32ns 0.173 0 0 1.09 KB
#5435 CallElasticsearch net6.0 1.28μs 0.448ns 1.55ns 0.0142 0 0 1.02 KB
#5435 CallElasticsearch netcoreapp3.1 1.57μs 1.47ns 5.67ns 0.0136 0 0 1.02 KB
#5435 CallElasticsearch net472 2.52μs 1.03ns 3.85ns 0.164 0 0 1.04 KB
#5435 CallElasticsearchAsync net6.0 1.36μs 0.543ns 2.1ns 0.0144 0 0 1 KB
#5435 CallElasticsearchAsync netcoreapp3.1 1.7μs 1.72ns 6.65ns 0.0144 0 0 1.07 KB
#5435 CallElasticsearchAsync net472 2.57μs 1.68ns 6.3ns 0.173 0.00128 0 1.09 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.49μs 1.19ns 4.45ns 0.0131 0 0 944 B
master ExecuteAsync netcoreapp3.1 1.73μs 0.825ns 3.09ns 0.0122 0 0 944 B
master ExecuteAsync net472 1.8μs 0.505ns 1.89ns 0.144 0 0 907 B
#5435 ExecuteAsync net6.0 1.52μs 1.05ns 3.91ns 0.0129 0 0 944 B
#5435 ExecuteAsync netcoreapp3.1 1.63μs 4.11ns 15.9ns 0.0129 0 0 944 B
#5435 ExecuteAsync net472 1.84μs 0.385ns 1.49ns 0.143 0 0 907 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.32μs 2.61ns 10.1ns 0.03 0 0 2.18 KB
master SendAsync netcoreapp3.1 5.19μs 3.32ns 12ns 0.0361 0 0 2.71 KB
master SendAsync net472 7.69μs 3.12ns 12.1ns 0.486 0 0 3.07 KB
#5435 SendAsync net6.0 4.27μs 0.848ns 3.17ns 0.0299 0 0 2.18 KB
#5435 SendAsync netcoreapp3.1 5.06μs 2.42ns 9.06ns 0.0353 0 0 2.71 KB
#5435 SendAsync net472 7.64μs 1.92ns 7.19ns 0.485 0 0 3.07 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.54μs 0.654ns 2.45ns 0.0233 0 0 1.68 KB
master EnrichedLog netcoreapp3.1 2.34μs 0.719ns 2.78ns 0.0233 0 0 1.68 KB
master EnrichedLog net472 2.67μs 3.68ns 14.3ns 0.255 0 0 1.61 KB
#5435 EnrichedLog net6.0 1.47μs 0.743ns 2.78ns 0.0235 0 0 1.68 KB
#5435 EnrichedLog netcoreapp3.1 2.2μs 1.17ns 4.39ns 0.0229 0 0 1.68 KB
#5435 EnrichedLog net472 2.68μs 5.35ns 20.7ns 0.254 0 0 1.61 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 114μs 157ns 607ns 0.0569 0 0 4.26 KB
master EnrichedLog netcoreapp3.1 118μs 75.9ns 284ns 0 0 0 4.26 KB
master EnrichedLog net472 150μs 108ns 418ns 0.676 0.225 0 4.45 KB
#5435 EnrichedLog net6.0 113μs 88ns 317ns 0.0564 0 0 4.26 KB
#5435 EnrichedLog netcoreapp3.1 118μs 191ns 738ns 0 0 0 4.26 KB
#5435 EnrichedLog net472 151μs 198ns 768ns 0.678 0.226 0 4.45 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.1μs 0.643ns 2.4ns 0.031 0 0 2.24 KB
master EnrichedLog netcoreapp3.1 4.21μs 1.31ns 5.09ns 0.0298 0 0 2.24 KB
master EnrichedLog net472 4.82μs 1.95ns 7.28ns 0.325 0 0 2.05 KB
#5435 EnrichedLog net6.0 3.03μs 1.67ns 6.46ns 0.0319 0 0 2.24 KB
#5435 EnrichedLog netcoreapp3.1 4.28μs 1.56ns 6.06ns 0.03 0 0 2.24 KB
#5435 EnrichedLog net472 4.97μs 1.34ns 5.18ns 0.324 0 0 2.05 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.45μs 0.48ns 1.8ns 0.0168 0 0 1.19 KB
master SendReceive netcoreapp3.1 1.86μs 0.563ns 2.18ns 0.0158 0 0 1.19 KB
master SendReceive net472 2.2μs 3.74ns 14.5ns 0.189 0 0 1.2 KB
#5435 SendReceive net6.0 1.44μs 0.915ns 3.42ns 0.0165 0 0 1.19 KB
#5435 SendReceive netcoreapp3.1 1.88μs 0.886ns 3.43ns 0.0159 0 0 1.19 KB
#5435 SendReceive net472 2.27μs 3.28ns 12.7ns 0.189 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.68μs 0.685ns 2.47ns 0.0214 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 4.06μs 21.1ns 101ns 0.0218 0 0 1.63 KB
master EnrichedLog net472 4.37μs 2.41ns 9.34ns 0.321 0 0 2.02 KB
#5435 EnrichedLog net6.0 2.65μs 1.1ns 4.13ns 0.0212 0 0 1.58 KB
#5435 EnrichedLog netcoreapp3.1 3.87μs 1.28ns 4.96ns 0.0214 0 0 1.63 KB
#5435 EnrichedLog net472 4.36μs 1.69ns 6.55ns 0.321 0 0 2.02 KB
Benchmarks.Trace.SpanBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #5435

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.158 859.01 741.73
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.141 514.84 451.17

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 515ns 1ns 3.88ns 0.00806 0 0 568 B
master StartFinishSpan netcoreapp3.1 760ns 2.37ns 9.17ns 0.0076 0 0 568 B
master StartFinishSpan net472 858ns 0.926ns 3.34ns 0.0902 0 0 570 B
master StartFinishScope net6.0 657ns 1.07ns 4.13ns 0.00956 0 0 688 B
master StartFinishScope netcoreapp3.1 864ns 1.24ns 4.62ns 0.00914 0 0 688 B
master StartFinishScope net472 996ns 1.67ns 6.49ns 0.103 0 0 650 B
#5435 StartFinishSpan net6.0 451ns 0.711ns 2.66ns 0.00798 0 0 568 B
#5435 StartFinishSpan netcoreapp3.1 738ns 0.997ns 3.86ns 0.00775 0 0 568 B
#5435 StartFinishSpan net472 741ns 0.951ns 3.68ns 0.0905 0 0 570 B
#5435 StartFinishScope net6.0 603ns 0.534ns 2.07ns 0.00958 0 0 688 B
#5435 StartFinishScope netcoreapp3.1 866ns 1.84ns 7.14ns 0.00911 0 0 688 B
#5435 StartFinishScope net472 964ns 1.31ns 5.09ns 0.103 0 0 650 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5435

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.202 597.48 718.10

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 598ns 0.863ns 3.23ns 0.00971 0 0 688 B
master RunOnMethodBegin netcoreapp3.1 1μs 1.46ns 5.45ns 0.00926 0 0 688 B
master RunOnMethodBegin net472 1.18μs 1.97ns 7.61ns 0.103 0 0 650 B
#5435 RunOnMethodBegin net6.0 717ns 0.943ns 3.65ns 0.00968 0 0 688 B
#5435 RunOnMethodBegin netcoreapp3.1 992ns 1ns 3.88ns 0.00918 0 0 688 B
#5435 RunOnMethodBegin net472 1.17μs 1.81ns 6.99ns 0.103 0 0 650 B

andrewlock avatar Apr 11 '24 19:04 andrewlock