dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

Optimise dependencies

Open thompson-tomo opened this issue 1 year ago • 4 comments

Is your feature request related to a problem? Please describe.

I want to minimise dependencies in my project by utilising framework dependencies wherever possible

Describe the solution you'd like

Within the Datadog.Trace.OpenTracing package, The System.Net.Http dependency becomes conditional so that it is only added for the older frameworks

Describe alternatives you've considered

Accept the additional dependency

Additional context

n/a

thompson-tomo avatar Apr 02 '24 11:04 thompson-tomo

As far as I can see, we don't depend on System.Net.Http, even transitively 🤔 Which NuGet package are you referring to? Datadog.Trace?

andrewlock avatar Apr 02 '24 15:04 andrewlock

So Datadog.Trace.OpenTracing depends on System.Net.Http, so I have updated the description.

thompson-tomo avatar Apr 02 '24 18:04 thompson-tomo

OK, thanks for the details.

To set expectations, I doubt we will take this approach. The OpenTracing project is archived and considered deprecated at this point. We recommend considering moving to OpenTelemetry instead. We will likely deprecate the Datadog.Trace.OpenTracing package in a future version

andrewlock avatar Apr 03 '24 13:04 andrewlock

@andrewlock i took a look at this topic & I was able to identify a number of locations where the dependencies can be optimised hence have submitted #5410 to cover these optimisation's.

thompson-tomo avatar Apr 06 '24 09:04 thompson-tomo

Closing this issue as fixed in #5418.

lucaspimentel avatar Aug 21 '24 19:08 lucaspimentel