dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

[Tracer][CI] support 128-bit trace ids in logs injection

Open lucaspimentel opened this issue 1 year ago • 4 comments

Summary of changes

Add support for injecting 128-bit trace ids using logs injection. This uses the existing DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED setting, which is false (disabled) by default.

When DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED=false (default), there should be no change from today. Inject all trace ids as a 64-bit decimal number. Only use the lower 64 bits (traceid.lower) of any 128-bit trace id.

When DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED=true

  • 64-bit trace ids (traceid.upper == 0) should keep the previous decimal format (no change).
  • 128-bit trace ids should be injected as lower-case hex string of length 32.

Reason for change

The DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED setting already exists (and is disabled by default), but enabling it doesn't really do anything yet. Its behavior is defined in the RFC that added support for 128-bit trace ids.

Implementation details

Created a helper LogContext static class to consolidate code used to get trace id and span id strings in various places. The new methods take a bool parameter to determine if we should inject 64-bit trace ids as decimal strings (default) or 128-bit trace ids as hexadecimal strings. Span id are always injected as decimal strings, never hex.

The new implementation also detects SpanContext objects and accesses its properties directly instead of relying on the IReadOnlyDictionary<string, string> implementation used for version mismatch scenarios.

Test coverage

⚠️ TODO ⚠️

Other details

lucaspimentel avatar Mar 27 '24 23:03 lucaspimentel

Datadog Report

Branch report: lpimentel/log-injection-128-bit-trace-id Commit report: 144dfc9 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 329436 Passed, 1527 Skipped, 49m 27.22s Wall Time

datadog-ddstaging[bot] avatar Mar 27 '24 23:03 datadog-ddstaging[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5363) - mean (70ms)  : 67, 73
     .   : milestone, 70,
    master - mean (69ms)  : 65, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (5363) - mean (1,003ms)  : 973, 1034
     .   : milestone, 1003,
    master - mean (1,001ms)  : 978, 1024
     .   : milestone, 1001,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5363) - mean (104ms)  : 99, 109
     .   : milestone, 104,
    master - mean (102ms)  : 100, 105
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (5363) - mean (677ms)  : 660, 694
     .   : milestone, 677,
    master - mean (676ms)  : 659, 693
     .   : milestone, 676,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5363) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (5363) - mean (632ms)  : 609, 654
     .   : milestone, 632,
    master - mean (632ms)  : 616, 648
     .   : milestone, 632,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5363) - mean (192ms)  : 188, 196
     .   : milestone, 192,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5363) - mean (1,111ms)  : 1087, 1134
     .   : milestone, 1111,
    master - mean (1,108ms)  : 1072, 1144
     .   : milestone, 1108,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5363) - mean (272ms)  : 267, 277
     .   : milestone, 272,
    master - mean (270ms)  : 264, 276
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (5363) - mean (866ms)  : 826, 906
     .   : milestone, 866,
    master - mean (863ms)  : 834, 892
     .   : milestone, 863,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5363) - mean (263ms)  : 259, 267
     .   : milestone, 263,
    master - mean (263ms)  : 259, 267
     .   : milestone, 263,

    section CallTarget+Inlining+NGEN
    This PR (5363) - mean (841ms)  : 813, 869
     .   : milestone, 841,
    master - mean (844ms)  : 806, 882
     .   : milestone, 844,

andrewlock avatar Apr 02 '24 19:04 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #5363 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.161
  • 2 benchmarks are slower, with geometric mean 1.194
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.78μs 34.9ns 130ns 0.0157 0.00786 0 5.61 KB
master StartStopWithChild netcoreapp3.1 9.89μs 53.4ns 283ns 0.015 0.00499 0 5.8 KB
master StartStopWithChild net472 15.9μs 58.6ns 227ns 1.06 0.351 0.104 6.2 KB
#5363 StartStopWithChild net6.0 7.84μs 43.8ns 301ns 0.0148 0.00738 0 5.61 KB
#5363 StartStopWithChild netcoreapp3.1 10μs 54.6ns 299ns 0.0145 0.00485 0 5.8 KB
#5363 StartStopWithChild net472 15.9μs 40.7ns 152ns 1.06 0.321 0.102 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 487μs 243ns 940ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 665μs 384ns 1.49μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 856μs 935ns 3.62μs 0.428 0 0 3.3 KB
#5363 WriteAndFlushEnrichedTraces net6.0 469μs 153ns 572ns 0 0 0 2.7 KB
#5363 WriteAndFlushEnrichedTraces netcoreapp3.1 665μs 747ns 2.89μs 0 0 0 2.7 KB
#5363 WriteAndFlushEnrichedTraces net472 852μs 823ns 3.19μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 133μs 238ns 923ns 0.194 0 0 14.47 KB
master SendRequest netcoreapp3.1 147μs 275ns 1.07μs 0.218 0 0 17.27 KB
master SendRequest net472 3.32E‑05ns 3.32E‑05ns 0.00012ns 0 0 0 0 b
#5363 SendRequest net6.0 132μs 258ns 998ns 0.199 0 0 14.47 KB
#5363 SendRequest netcoreapp3.1 150μs 117ns 451ns 0.224 0 0 17.27 KB
#5363 SendRequest net472 0.000329ns 0.000137ns 0.000529ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 566μs 2.86μs 16.7μs 0.563 0 0 41.65 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 696μs 3.88μs 25.4μs 0.322 0 0 41.77 KB
master WriteAndFlushEnrichedTraces net472 852μs 3.75μs 14.5μs 8.28 2.48 0.414 53.3 KB
#5363 WriteAndFlushEnrichedTraces net6.0 578μs 3.18μs 19.4μs 0.579 0 0 41.53 KB
#5363 WriteAndFlushEnrichedTraces netcoreapp3.1 661μs 2.48μs 9.61μs 0.329 0 0 41.64 KB
#5363 WriteAndFlushEnrichedTraces net472 848μs 3.62μs 13.5μs 8.33 2.5 0.417 53.33 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.33μs 1.8ns 6.73ns 0.0141 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.85μs 2.52ns 9.08ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery net472 2.12μs 1.73ns 6.71ns 0.156 0.00105 0 987 B
#5363 ExecuteNonQuery net6.0 1.27μs 0.987ns 3.82ns 0.0141 0 0 1.02 KB
#5363 ExecuteNonQuery netcoreapp3.1 1.76μs 1.45ns 5.62ns 0.0132 0 0 1.02 KB
#5363 ExecuteNonQuery net472 2.02μs 1.91ns 6.88ns 0.156 0.00102 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5363

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.255 1,183.89 1,485.34

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.3μs 0.625ns 2.42ns 0.0136 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.61μs 1.28ns 4.97ns 0.0129 0 0 976 B
master CallElasticsearch net472 2.47μs 2.17ns 8.39ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.18μs 1.14ns 4.26ns 0.013 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.68μs 1.06ns 4.1ns 0.0135 0 0 1.02 KB
master CallElasticsearchAsync net472 2.64μs 1.79ns 6.95ns 0.167 0 0 1.05 KB
#5363 CallElasticsearch net6.0 1.21μs 0.632ns 2.45ns 0.0134 0 0 976 B
#5363 CallElasticsearch netcoreapp3.1 1.55μs 0.93ns 3.6ns 0.0133 0 0 976 B
#5363 CallElasticsearch net472 2.65μs 4.24ns 16.4ns 0.157 0 0 995 B
#5363 CallElasticsearchAsync net6.0 1.49μs 1.05ns 4.07ns 0.0134 0 0 952 B
#5363 CallElasticsearchAsync netcoreapp3.1 1.72μs 1.52ns 5.89ns 0.0137 0 0 1.02 KB
#5363 CallElasticsearchAsync net472 2.57μs 1.88ns 7.26ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.27μs 1.19ns 4.44ns 0.0134 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.67μs 1.07ns 3.87ns 0.0125 0 0 952 B
master ExecuteAsync net472 1.88μs 1.12ns 4.35ns 0.145 0 0 915 B
#5363 ExecuteAsync net6.0 1.27μs 1.1ns 4.11ns 0.0134 0 0 952 B
#5363 ExecuteAsync netcoreapp3.1 1.62μs 0.619ns 2.32ns 0.0122 0 0 952 B
#5363 ExecuteAsync net472 1.9μs 0.718ns 2.68ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.43μs 5.94ns 22.2ns 0.0331 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.15μs 1.4ns 5.42ns 0.0388 0 0 2.85 KB
master SendAsync net472 7.55μs 1.94ns 7.51ns 0.494 0 0 3.12 KB
#5363 SendAsync net6.0 4.5μs 2.8ns 10.5ns 0.0314 0 0 2.31 KB
#5363 SendAsync netcoreapp3.1 5.27μs 5.55ns 21.5ns 0.0394 0 0 2.85 KB
#5363 SendAsync net472 7.42μs 1.57ns 6.09ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.58μs 0.987ns 3.56ns 0.0229 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.22μs 1.41ns 5.26ns 0.0224 0 0 1.64 KB
master EnrichedLog net472 2.67μs 1.55ns 5.59ns 0.25 0 0 1.57 KB
#5363 EnrichedLog net6.0 1.51μs 0.973ns 3.77ns 0.0232 0 0 1.64 KB
#5363 EnrichedLog netcoreapp3.1 2.11μs 0.781ns 2.82ns 0.0222 0 0 1.64 KB
#5363 EnrichedLog net472 2.63μs 3.72ns 14.4ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 114μs 188ns 728ns 0.0571 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 120μs 210ns 812ns 0.0598 0 0 4.28 KB
master EnrichedLog net472 151μs 332ns 1.29μs 0.672 0.224 0 4.46 KB
#5363 EnrichedLog net6.0 113μs 165ns 640ns 0.0571 0 0 4.28 KB
#5363 EnrichedLog netcoreapp3.1 119μs 228ns 885ns 0.0592 0 0 4.28 KB
#5363 EnrichedLog net472 149μs 162ns 608ns 0.673 0.224 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.02μs 1.86ns 6.96ns 0.0303 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.14μs 2.04ns 7.89ns 0.029 0 0 2.2 KB
master EnrichedLog net472 4.81μs 1.96ns 7.33ns 0.319 0 0 2.02 KB
#5363 EnrichedLog net6.0 3.04μs 0.554ns 2ns 0.0304 0 0 2.2 KB
#5363 EnrichedLog netcoreapp3.1 4.18μs 1.36ns 5.27ns 0.0293 0 0 2.2 KB
#5363 EnrichedLog net472 4.84μs 1.11ns 4.3ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.36μs 1.1ns 4.26ns 0.0158 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.85μs 1.11ns 4.3ns 0.0155 0 0 1.14 KB
master SendReceive net472 2.15μs 4.8ns 18.6ns 0.184 0 0 1.16 KB
#5363 SendReceive net6.0 1.33μs 0.495ns 1.92ns 0.0159 0 0 1.14 KB
#5363 SendReceive netcoreapp3.1 1.77μs 1.03ns 3.86ns 0.015 0 0 1.14 KB
#5363 SendReceive net472 2.05μs 1.61ns 5.8ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.7μs 0.88ns 3.41ns 0.0216 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.84μs 2.08ns 8.08ns 0.023 0 0 1.65 KB
master EnrichedLog net472 4.31μs 2.51ns 9.73ns 0.324 0 0 2.04 KB
#5363 EnrichedLog net6.0 2.97μs 1.15ns 4.46ns 0.0222 0 0 1.6 KB
#5363 EnrichedLog netcoreapp3.1 3.78μs 1.06ns 4.11ns 0.0208 0 0 1.65 KB
#5363 EnrichedLog net472 4.32μs 3.09ns 12ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5363

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 1.137 766.55 871.25

Faster :tada: in #5363

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.126 525.29 466.37

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 444ns 0.759ns 2.94ns 0.00798 0 0 576 B
master StartFinishSpan netcoreapp3.1 573ns 0.985ns 3.81ns 0.00795 0 0 576 B
master StartFinishSpan net472 629ns 1.58ns 6.12ns 0.0915 0 0 578 B
master StartFinishScope net6.0 525ns 0.809ns 3.13ns 0.00979 0 0 696 B
master StartFinishScope netcoreapp3.1 750ns 1.34ns 5.19ns 0.00929 0 0 696 B
master StartFinishScope net472 767ns 2.24ns 8.68ns 0.104 0 0 658 B
#5363 StartFinishSpan net6.0 401ns 0.821ns 3.18ns 0.00807 0 0 576 B
#5363 StartFinishSpan netcoreapp3.1 564ns 0.757ns 2.93ns 0.00791 0 0 576 B
#5363 StartFinishSpan net472 577ns 1.23ns 4.76ns 0.0917 0 0 578 B
#5363 StartFinishScope net6.0 466ns 0.865ns 3.35ns 0.00972 0 0 696 B
#5363 StartFinishScope netcoreapp3.1 714ns 1.22ns 4.72ns 0.00948 0 0 696 B
#5363 StartFinishScope net472 871ns 1.17ns 4.38ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #5363

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.197 722.62 603.60

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 725ns 1.6ns 6.21ns 0.00949 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 883ns 1.6ns 5.99ns 0.0093 0 0 696 B
master RunOnMethodBegin net472 1.09μs 2.2ns 8.51ns 0.105 0 0 658 B
#5363 RunOnMethodBegin net6.0 603ns 0.916ns 3.55ns 0.00974 0 0 696 B
#5363 RunOnMethodBegin netcoreapp3.1 918ns 1.71ns 6.62ns 0.00946 0 0 696 B
#5363 RunOnMethodBegin net472 1.09μs 1.85ns 7.15ns 0.104 0 0 658 B

andrewlock avatar Apr 02 '24 19:04 andrewlock

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5363) (11.090M)   : 0, 11090254
    master (11.151M)   : 0, 11150817
    benchmarks/2.9.0 (11.045M)   : 0, 11045405

    section Automatic
    This PR (5363) (7.263M)   : 0, 7263256
    master (7.221M)   : 0, 7221295
    benchmarks/2.9.0 (7.885M)   : 0, 7885346

    section Trace stats
    master (7.485M)   : 0, 7485025

    section Manual
    master (11.247M)   : 0, 11246750

    section Manual + Automatic
    This PR (5363) (6.720M)   : 0, 6720153
    master (6.675M)   : 0, 6674965

    section DD_TRACE_ENABLED=0
    master (10.234M)   : 0, 10233694


gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5363) (9.749M)   : 0, 9749031
    benchmarks/2.9.0 (9.586M)   : 0, 9586476

    section Automatic
    This PR (5363) (6.427M)   : 0, 6427025

    section Manual + Automatic
    This PR (5363) (6.046M)   : 0, 6045607


gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5363) (10.473M)   : 0, 10473402
    master (10.052M)   : 0, 10051670

    section Automatic
    This PR (5363) (6.686M)   : 0, 6686358
    master (6.724M)   : 0, 6723576

    section Trace stats
    master (7.295M)   : 0, 7294515

    section Manual
    master (10.082M)   : 0, 10082228

    section Manual + Automatic
    This PR (5363) (6.183M)   : 0, 6183207
    master (6.302M)   : 0, 6302199

    section DD_TRACE_ENABLED=0
    master (9.527M)   : 0, 9526935

andrewlock avatar Apr 08 '24 20:04 andrewlock

Datadog Report

Branch report: lpimentel/log-injection-128-bit-trace-id Commit report: bc3bafd Test service: dd-trace-dotnet

:x: 356 Failed (1 Known Flaky), 582626 Passed, 4654 Skipped, 34h 41m 31.04s Total Time

:x: Failed Tests (356)

This report shows up to 5 failed tests.

  • GraphQL2SchemaV0Tests.SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests - Details

    Expand for error 
    nable to determine port application is listening on

  • GraphQL2SchemaV0Tests.SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests - Details

    Expand for error 
    nable to determine port application is listening on

  • GraphQL2SchemaV0Tests.SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests - Details

    Expand for error 
    nable to determine port application is listening on

  • GraphQL2SchemaV0Tests.SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests - Details

    Expand for error 
    nable to determine port application is listening on

  • GraphQL3SchemaV0Tests.SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests - Details

    Expand for error 
    nable to determine port application is listening on

datadog-ddstaging[bot] avatar Jan 15 '25 17:01 datadog-ddstaging[bot]