dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

Use `TraceId128` in log instead of `TraceId`

Open andrewlock opened this issue 1 year ago • 4 comments

Summary of changes

Use TraceId128 in log instead of TraceId when recording exception

Reason for change

TraceId only gives the 64-bit TraceId, TraceId128 gives the full thing

Implementation details

TraceId -> TraceId128

Test coverage

meh

Other details

Originally done in

  • https://github.com/DataDog/dd-trace-dotnet/pull/5291

And flagged by @lucaspimentel here

andrewlock avatar Mar 15 '24 12:03 andrewlock

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5312) - mean (73ms)  : 65, 82
     .   : milestone, 73,
    master - mean (73ms)  : 65, 82
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5312) - mean (1,006ms)  : 986, 1026
     .   : milestone, 1006,
    master - mean (1,005ms)  : 978, 1033
     .   : milestone, 1005,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5312) - mean (110ms)  : 106, 114
     .   : milestone, 110,
    master - mean (111ms)  : 108, 114
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (5312) - mean (723ms)  : 701, 745
     .   : milestone, 723,
    master - mean (733ms)  : 711, 754
     .   : milestone, 733,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5312) - mean (94ms)  : 91, 96
     .   : milestone, 94,
    master - mean (93ms)  : 91, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5312) - mean (676ms)  : 658, 693
     .   : milestone, 676,
    master - mean (683ms)  : 665, 702
     .   : milestone, 683,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5312) - mean (188ms)  : 184, 191
     .   : milestone, 188,
    master - mean (187ms)  : 185, 190
     .   : milestone, 187,

    section CallTarget+Inlining+NGEN
    This PR (5312) - mean (1,078ms)  : 1054, 1103
     .   : milestone, 1078,
    master - mean (1,079ms)  : 1060, 1099
     .   : milestone, 1079,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5312) - mean (272ms)  : 267, 276
     .   : milestone, 272,
    master - mean (271ms)  : 267, 275
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (5312) - mean (882ms)  : 861, 903
     .   : milestone, 882,
    master - mean (883ms)  : 861, 904
     .   : milestone, 883,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5312) - mean (261ms)  : 257, 264
     .   : milestone, 261,
    master - mean (260ms)  : 256, 264
     .   : milestone, 260,

    section CallTarget+Inlining+NGEN
    This PR (5312) - mean (868ms)  : 842, 894
     .   : milestone, 868,
    master - mean (861ms)  : 841, 882
     .   : milestone, 861,

andrewlock avatar Mar 15 '24 13:03 andrewlock

Datadog Report

Branch report: andrew/use-traceid128 Commit report: b0da35e Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 327900 Passed, 1586 Skipped, 35m 17.21s Wall Time

datadog-ddstaging[bot] avatar Mar 15 '24 13:03 datadog-ddstaging[bot]

Benchmarks Report for tracer :snail:

Benchmarks for #5312 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.145
  • 2 benchmarks are slower, with geometric mean 1.145
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.69μs 48.5ns 307ns 0.022 0.0088 0 7.5 KB
master StartStopWithChild netcoreapp3.1 10.7μs 56.7ns 350ns 0.0322 0.0107 0.00537 7.6 KB
master StartStopWithChild net472 17.1μs 56.5ns 219ns 1.37 0.357 0.128 8.12 KB
#5312 StartStopWithChild net6.0 8.76μs 44.6ns 252ns 0.0219 0.00876 0 7.51 KB
#5312 StartStopWithChild netcoreapp3.1 10.6μs 57.7ns 331ns 0.0209 0.0104 0 7.6 KB
#5312 StartStopWithChild net472 17μs 63.8ns 230ns 1.38 0.359 0.12 8.14 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 457μs 178ns 642ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 598μs 177ns 661ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 814μs 287ns 1.03μs 0.437 0 0 3.3 KB
#5312 WriteAndFlushEnrichedTraces net6.0 465μs 343ns 1.33μs 0 0 0 2.7 KB
#5312 WriteAndFlushEnrichedTraces netcoreapp3.1 607μs 94.2ns 353ns 0 0 0 2.7 KB
#5312 WriteAndFlushEnrichedTraces net472 812μs 281ns 1.09μs 0.408 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 170μs 109ns 422ns 0.17 0 0 18.33 KB
master SendRequest netcoreapp3.1 191μs 494ns 1.91μs 0.19 0 0 20.49 KB
master SendRequest net472 0.00136ns 0.000452ns 0.00169ns 0 0 0 0 b
#5312 SendRequest net6.0 168μs 158ns 614ns 0.168 0 0 18.33 KB
#5312 SendRequest netcoreapp3.1 192μs 204ns 762ns 0.191 0 0 20.49 KB
#5312 SendRequest net472 0.000895ns 0.000329ns 0.00128ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 545μs 792ns 3.07μs 0.558 0 0 41.66 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 663μs 877ns 3.28μs 0.326 0 0 41.76 KB
master WriteAndFlushEnrichedTraces net472 840μs 3.51μs 13.6μs 8.33 2.5 0.417 53.23 KB
#5312 WriteAndFlushEnrichedTraces net6.0 549μs 584ns 2.26μs 0.534 0 0 41.61 KB
#5312 WriteAndFlushEnrichedTraces netcoreapp3.1 651μs 777ns 3.01μs 0.326 0 0 41.6 KB
#5312 WriteAndFlushEnrichedTraces net472 874μs 4.15μs 17.1μs 8.08 2.55 0.425 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.1μs 0.453ns 1.76ns 0.0111 0 0 784 B
master ExecuteNonQuery netcoreapp3.1 1.55μs 0.568ns 2.2ns 0.0102 0 0 784 B
master ExecuteNonQuery net472 1.87μs 1.76ns 6.81ns 0.118 0 0 746 B
#5312 ExecuteNonQuery net6.0 1.12μs 0.477ns 1.79ns 0.0107 0 0 784 B
#5312 ExecuteNonQuery netcoreapp3.1 1.55μs 1.24ns 4.82ns 0.0106 0 0 784 B
#5312 ExecuteNonQuery net472 1.77μs 1.03ns 3.99ns 0.118 0 0 746 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.31μs 0.615ns 2.22ns 0.0144 0 0 1.01 KB
master CallElasticsearch netcoreapp3.1 1.64μs 1.21ns 4.51ns 0.0139 0 0 1.01 KB
master CallElasticsearch net472 2.45μs 1.26ns 4.55ns 0.161 0 0 1.02 KB
master CallElasticsearchAsync net6.0 1.4μs 0.753ns 2.82ns 0.014 0 0 984 B
master CallElasticsearchAsync netcoreapp3.1 1.6μs 0.868ns 3.25ns 0.0145 0 0 1.06 KB
master CallElasticsearchAsync net472 2.53μs 1.19ns 4.6ns 0.17 0 0 1.08 KB
#5312 CallElasticsearch net6.0 1.31μs 1.48ns 5.72ns 0.0143 0 0 1.01 KB
#5312 CallElasticsearch netcoreapp3.1 1.65μs 0.888ns 3.2ns 0.0131 0 0 1.01 KB
#5312 CallElasticsearch net472 2.45μs 1.6ns 5.97ns 0.162 0 0 1.02 KB
#5312 CallElasticsearchAsync net6.0 1.33μs 1.13ns 4.37ns 0.0139 0 0 984 B
#5312 CallElasticsearchAsync netcoreapp3.1 1.77μs 1.13ns 4.36ns 0.0142 0 0 1.06 KB
#5312 CallElasticsearchAsync net472 2.53μs 1.19ns 4.61ns 0.17 0 0 1.08 KB
Benchmarks.Trace.GraphQLBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5312

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 1.148 1,224.99 1,406.36

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.22μs 1.26ns 4.88ns 0.0127 0 0 928 B
master ExecuteAsync netcoreapp3.1 1.69μs 0.938ns 3.63ns 0.0125 0 0 928 B
master ExecuteAsync net472 1.9μs 1.86ns 7.21ns 0.141 0 0 891 B
#5312 ExecuteAsync net6.0 1.41μs 0.832ns 3.22ns 0.0126 0 0 928 B
#5312 ExecuteAsync netcoreapp3.1 1.74μs 0.803ns 3.01ns 0.0121 0 0 928 B
#5312 ExecuteAsync net472 1.9μs 1.22ns 4.55ns 0.141 0 0 891 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.18μs 2.03ns 7.59ns 0.0293 0 0 2.16 KB
master SendAsync netcoreapp3.1 5.08μs 2.91ns 10.9ns 0.0356 0 0 2.7 KB
master SendAsync net472 7.79μs 8.2ns 31.8ns 0.533 0 0 3.38 KB
#5312 SendAsync net6.0 4.29μs 2.64ns 9.88ns 0.0302 0 0 2.16 KB
#5312 SendAsync netcoreapp3.1 5.24μs 1.87ns 6.76ns 0.0367 0 0 2.7 KB
#5312 SendAsync net472 7.72μs 5.22ns 19.5ns 0.536 0 0 3.38 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.45μs 0.629ns 2.35ns 0.0231 0 0 1.65 KB
master EnrichedLog netcoreapp3.1 2.11μs 0.959ns 3.71ns 0.0221 0 0 1.65 KB
master EnrichedLog net472 2.54μs 1.16ns 4.34ns 0.25 0 0 1.57 KB
#5312 EnrichedLog net6.0 1.43μs 0.745ns 2.89ns 0.0231 0 0 1.65 KB
#5312 EnrichedLog netcoreapp3.1 2.24μs 1.11ns 4.17ns 0.0215 0 0 1.65 KB
#5312 EnrichedLog net472 2.67μs 3.12ns 12.1ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 197ns 763ns 0 0 0 4.23 KB
master EnrichedLog netcoreapp3.1 118μs 102ns 381ns 0.0592 0 0 4.23 KB
master EnrichedLog net472 145μs 92.8ns 360ns 0.654 0.218 0 4.41 KB
#5312 EnrichedLog net6.0 112μs 89.4ns 346ns 0.0567 0 0 4.23 KB
#5312 EnrichedLog netcoreapp3.1 118μs 166ns 643ns 0.0592 0 0 4.23 KB
#5312 EnrichedLog net472 146μs 103ns 387ns 0.66 0.22 0 4.41 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3μs 1.16ns 4.03ns 0.0303 0 0 2.21 KB
master EnrichedLog netcoreapp3.1 4.28μs 2.4ns 8.97ns 0.0298 0 0 2.21 KB
master EnrichedLog net472 4.84μs 2.15ns 8.06ns 0.321 0 0 2.02 KB
#5312 EnrichedLog net6.0 3.12μs 1.06ns 3.82ns 0.0313 0 0 2.21 KB
#5312 EnrichedLog netcoreapp3.1 4.33μs 1.55ns 5.79ns 0.028 0 0 2.21 KB
#5312 EnrichedLog net472 4.89μs 1.95ns 7.28ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.41μs 0.571ns 2.21ns 0.0162 0 0 1.18 KB
master SendReceive netcoreapp3.1 1.87μs 1.14ns 4.27ns 0.0159 0 0 1.18 KB
master SendReceive net472 2.3μs 1ns 3.89ns 0.187 0 0 1.18 KB
#5312 SendReceive net6.0 1.39μs 1.12ns 4.17ns 0.0167 0 0 1.18 KB
#5312 SendReceive netcoreapp3.1 1.81μs 0.748ns 2.8ns 0.0154 0 0 1.18 KB
#5312 SendReceive net472 2.25μs 2.58ns 10ns 0.187 0 0 1.18 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.69μs 0.905ns 3.39ns 0.0215 0 0 1.55 KB
master EnrichedLog netcoreapp3.1 3.9μs 1ns 3.89ns 0.0213 0 0 1.6 KB
master EnrichedLog net472 4.43μs 2.12ns 8.23ns 0.315 0 0 1.99 KB
#5312 EnrichedLog net6.0 2.74μs 0.914ns 3.42ns 0.0223 0 0 1.55 KB
#5312 EnrichedLog netcoreapp3.1 3.95μs 1.16ns 4.17ns 0.0217 0 0 1.6 KB
#5312 EnrichedLog net472 4.38μs 2.24ns 8.38ns 0.315 0 0 1.99 KB
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5312

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.143 451.45 515.82

Faster :tada: in #5312

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.119 599.73 536.07

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 451ns 0.527ns 1.97ns 0.00771 0 0 552 B
master StartFinishSpan netcoreapp3.1 682ns 1.07ns 4.15ns 0.00736 0 0 552 B
master StartFinishSpan net472 730ns 0.393ns 1.52ns 0.0877 0 0 554 B
master StartFinishScope net6.0 600ns 0.714ns 2.67ns 0.00952 0 0 672 B
master StartFinishScope netcoreapp3.1 813ns 1.04ns 4.04ns 0.0089 0 0 672 B
master StartFinishScope net472 1.01μs 1.03ns 3.86ns 0.1 0 0 634 B
#5312 StartFinishSpan net6.0 517ns 0.996ns 3.86ns 0.00762 0 0 552 B
#5312 StartFinishSpan netcoreapp3.1 736ns 1.93ns 7.47ns 0.00774 0 0 552 B
#5312 StartFinishSpan net472 799ns 1.71ns 6.64ns 0.0878 0 0 554 B
#5312 StartFinishScope net6.0 535ns 1.06ns 4.11ns 0.00938 0 0 672 B
#5312 StartFinishScope netcoreapp3.1 871ns 1.17ns 4.51ns 0.00909 0 0 672 B
#5312 StartFinishScope net472 950ns 1.68ns 6.52ns 0.101 0 0 634 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #5312

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.172 700.47 597.43

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 700ns 0.762ns 2.95ns 0.00944 0 0 672 B
master RunOnMethodBegin netcoreapp3.1 993ns 1.81ns 7.01ns 0.00908 0 0 672 B
master RunOnMethodBegin net472 1.09μs 1.73ns 6.72ns 0.101 0 0 634 B
#5312 RunOnMethodBegin net6.0 596ns 0.94ns 3.64ns 0.00946 0 0 672 B
#5312 RunOnMethodBegin netcoreapp3.1 928ns 1.24ns 4.8ns 0.00898 0 0 672 B
#5312 RunOnMethodBegin net472 1.02μs 2.59ns 10ns 0.101 0 0 634 B

andrewlock avatar Mar 15 '24 13:03 andrewlock

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5312) (11.066M)   : 0, 11066406
    master (11.199M)   : 0, 11199038
    benchmarks/2.9.0 (11.199M)   : 0, 11198849

    section Automatic
    This PR (5312) (7.501M)   : 0, 7501313
    master (7.662M)   : 0, 7662012
    benchmarks/2.9.0 (8.073M)   : 0, 8073104

    section Trace stats
    This PR (5312) (7.888M)   : 0, 7887954
    master (8.205M)   : 0, 8205275

    section Manual
    This PR (5312) (9.540M)   : 0, 9540410
    master (9.883M)   : 0, 9883344

    section Manual + Automatic
    This PR (5312) (7.171M)   : 0, 7170552
    master (7.295M)   : 0, 7295083

    section Version Conflict
    This PR (5312) (6.503M)   : 0, 6503277
    master (6.628M)   : 0, 6627687


gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5312) (9.518M)   : 0, 9518058
    master (9.627M)   : 0, 9626775
    benchmarks/2.9.0 (9.424M)   : 0, 9424414

    section Automatic
    This PR (5312) (6.629M)   : 0, 6629360
    master (6.666M)   : 0, 6665718

    section Trace stats
    This PR (5312) (6.916M)   : 0, 6916475
    master (6.927M)   : 0, 6927005

    section Manual
    This PR (5312) (8.224M)   : 0, 8223827
    master (8.376M)   : 0, 8375804

    section Manual + Automatic
    This PR (5312) (6.219M)   : 0, 6219097
    master (6.218M)   : 0, 6217652

    section Version Conflict
    This PR (5312) (5.640M)   : 0, 5640115
    master (5.680M)   : 0, 5679994


gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5312) (10.083M)   : 0, 10082712
    master (9.866M)   : 0, 9865815
    benchmarks/2.9.0 (9.559M)   : 0, 9558711

    section Automatic
    This PR (5312) (7.017M)   : 0, 7016872
    master (6.996M)   : 0, 6995543
    benchmarks/2.9.0 (7.049M)   : 0, 7049098

    section Trace stats
    This PR (5312) (7.378M)   : 0, 7377594
    master (7.364M)   : 0, 7364144

    section Manual
    This PR (5312) (8.775M)   : 0, 8774525
    master (8.631M)   : 0, 8631324

    section Manual + Automatic
    This PR (5312) (6.710M)   : 0, 6709819
    master (6.707M)   : 0, 6707173

    section Version Conflict
    This PR (5312) (6.132M)   : 0, 6132094
    master (6.201M)   : 0, 6201222

andrewlock avatar Mar 15 '24 14:03 andrewlock