dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

Add explicit "clean" step to clone repo

Open andrewlock opened this issue 1 year ago • 4 comments

Summary of changes

Clean the working directory before cloning into it

Reason for change

Azure Devops explicitly doesn't clean the directory after running a job. That's fine normally, but we're doing extra work (with a merge commit) to ensure we test the same code throughout the pipeline which currently assumes the checkout directory is empty. This has caused issues when we try to disable provisioning of VMs (to increase throughput)

Implementation details

Explicit rm -rf before we do anything else

Test coverage

This is the test - if the PR builds, after merging to master I'll try disabling the de-provision steps, which will hopefully help throughput

Other details

andrewlock avatar Mar 14 '24 15:03 andrewlock

Datadog Report

Branch report: andrew/ci/do-proper-clean Commit report: 0310ede Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 332105 Passed, 1565 Skipped, 35m 45.45s Wall Time

datadog-ddstaging[bot] avatar Mar 14 '24 16:03 datadog-ddstaging[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5309) - mean (74ms)  : 66, 83
     .   : milestone, 74,
    master - mean (74ms)  : 65, 82
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5309) - mean (1,020ms)  : 1002, 1037
     .   : milestone, 1020,
    master - mean (1,015ms)  : 996, 1034
     .   : milestone, 1015,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5309) - mean (112ms)  : 108, 115
     .   : milestone, 112,
    master - mean (110ms)  : 107, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5309) - mean (749ms)  : 732, 765
     .   : milestone, 749,
    master - mean (735ms)  : 723, 748
     .   : milestone, 735,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5309) - mean (96ms)  : 93, 100
     .   : milestone, 96,
    master - mean (94ms)  : 91, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5309) - mean (702ms)  : 680, 724
     .   : milestone, 702,
    master - mean (692ms)  : 676, 708
     .   : milestone, 692,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5309) - mean (187ms)  : 185, 190
     .   : milestone, 187,
    master - mean (187ms)  : 184, 191
     .   : milestone, 187,

    section CallTarget+Inlining+NGEN
    This PR (5309) - mean (1,080ms)  : 1061, 1098
     .   : milestone, 1080,
    master - mean (1,085ms)  : 1064, 1105
     .   : milestone, 1085,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5309) - mean (271ms)  : 267, 275
     .   : milestone, 271,
    master - mean (271ms)  : 267, 275
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (5309) - mean (884ms)  : 860, 909
     .   : milestone, 884,
    master - mean (886ms)  : 860, 912
     .   : milestone, 886,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5309) - mean (260ms)  : 256, 264
     .   : milestone, 260,
    master - mean (261ms)  : 257, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (5309) - mean (867ms)  : 844, 890
     .   : milestone, 867,
    master - mean (868ms)  : 846, 890
     .   : milestone, 868,

andrewlock avatar Mar 14 '24 17:03 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #5309 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.200
  • 1 benchmarks are slower, with geometric mean 1.135
  • 1 benchmarks have fewer allocations
  • 33 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.66μs 48.5ns 318ns 0.0175 0.00877 0 7.49 KB
master StartStopWithChild netcoreapp3.1 10.7μs 58.1ns 313ns 0.0265 0.0106 0 7.58 KB
master StartStopWithChild net472 17.2μs 56ns 217ns 1.36 0.35 0.0855 8.11 KB
#5309 StartStopWithChild net6.0 8.48μs 45.2ns 235ns 0.0254 0.0127 0 7.51 KB
#5309 StartStopWithChild netcoreapp3.1 10.6μs 57.9ns 317ns 0.0315 0.0158 0 7.6 KB
#5309 StartStopWithChild net472 17.3μs 50.2ns 194ns 1.38 0.363 0.127 8.13 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 460μs 399ns 1.38μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 606μs 270ns 974ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 806μs 298ns 1.11μs 0.403 0 0 3.3 KB
#5309 WriteAndFlushEnrichedTraces net6.0 473μs 330ns 1.28μs 0 0 0 2.7 KB
#5309 WriteAndFlushEnrichedTraces netcoreapp3.1 607μs 127ns 475ns 0 0 0 2.7 KB
#5309 WriteAndFlushEnrichedTraces net472 827μs 506ns 1.96μs 0.408 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 170μs 158ns 612ns 0.17 0 0 18.3 KB
master SendRequest netcoreapp3.1 192μs 276ns 1.07μs 0.192 0 0 20.46 KB
master SendRequest net472 0.000687ns 0.000257ns 0.000994ns 0 0 0 0 b
#5309 SendRequest net6.0 170μs 101ns 392ns 0.253 0 0 18.33 KB
#5309 SendRequest netcoreapp3.1 192μs 240ns 931ns 0.191 0 0 20.49 KB
#5309 SendRequest net472 0.000939ns 0.000417ns 0.0015ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #5309

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.94 KB 41.71 KB -229 B -0.55%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 553μs 681ns 2.64μs 0.543 0 0 41.94 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 663μs 1.16μs 4.48μs 0.324 0 0 41.63 KB
master WriteAndFlushEnrichedTraces net472 848μs 4.09μs 16.8μs 8.08 2.55 0.425 53.26 KB
#5309 WriteAndFlushEnrichedTraces net6.0 549μs 883ns 3.42μs 0.548 0 0 41.71 KB
#5309 WriteAndFlushEnrichedTraces netcoreapp3.1 659μs 1.38μs 5.15μs 0.322 0 0 41.68 KB
#5309 WriteAndFlushEnrichedTraces net472 897μs 4.12μs 16μs 8.25 2.6 0.434 53.24 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5309

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472 738 B 746 B 8 B 1.08%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 776 B 784 B 8 B 1.03%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 776 B 784 B 8 B 1.03%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.15μs 0.545ns 2.11ns 0.011 0 0 776 B
master ExecuteNonQuery netcoreapp3.1 1.49μs 0.72ns 2.79ns 0.0106 0 0 776 B
master ExecuteNonQuery net472 1.75μs 0.702ns 2.53ns 0.116 0 0 738 B
#5309 ExecuteNonQuery net6.0 1.2μs 0.253ns 0.911ns 0.0108 0 0 784 B
#5309 ExecuteNonQuery netcoreapp3.1 1.5μs 0.621ns 2.32ns 0.0104 0 0 784 B
#5309 ExecuteNonQuery net472 1.82μs 0.555ns 2.08ns 0.118 0 0 746 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5309

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 976 B 984 B 8 B 0.82%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1 KB 1.01 KB 8 B 0.80%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1 KB 1.01 KB 8 B 0.80%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472 1.01 KB 1.02 KB 8 B 0.79%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 1.05 KB 1.06 KB 8 B 0.76%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472 1.07 KB 1.08 KB 8 B 0.75%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.31μs 1.61ns 6.24ns 0.0138 0 0 1 KB
master CallElasticsearch netcoreapp3.1 1.65μs 1.54ns 5.76ns 0.0135 0 0 1 KB
master CallElasticsearch net472 2.55μs 1.47ns 5.68ns 0.16 0 0 1.01 KB
master CallElasticsearchAsync net6.0 1.3μs 0.829ns 3.1ns 0.0135 0 0 976 B
master CallElasticsearchAsync netcoreapp3.1 1.72μs 1.04ns 3.88ns 0.0145 0 0 1.05 KB
master CallElasticsearchAsync net472 2.72μs 1.27ns 4.74ns 0.169 0 0 1.07 KB
#5309 CallElasticsearch net6.0 1.27μs 0.741ns 2.77ns 0.0143 0 0 1.01 KB
#5309 CallElasticsearch netcoreapp3.1 1.63μs 2.27ns 8.49ns 0.0138 0 0 1.01 KB
#5309 CallElasticsearch net472 2.64μs 2.15ns 8.06ns 0.162 0 0 1.02 KB
#5309 CallElasticsearchAsync net6.0 1.38μs 0.524ns 2.03ns 0.0138 0 0 984 B
#5309 CallElasticsearchAsync netcoreapp3.1 1.73μs 0.828ns 3.21ns 0.0145 0 0 1.06 KB
#5309 CallElasticsearchAsync net472 2.72μs 1.18ns 4.4ns 0.171 0 0 1.08 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5309

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472 883 B 891 B 8 B 0.91%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 920 B 928 B 8 B 0.87%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 920 B 928 B 8 B 0.87%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.29μs 0.999ns 3.6ns 0.0128 0 0 920 B
master ExecuteAsync netcoreapp3.1 1.7μs 1.64ns 6.15ns 0.0125 0 0 920 B
master ExecuteAsync net472 1.91μs 1.28ns 4.94ns 0.14 0 0 883 B
#5309 ExecuteAsync net6.0 1.37μs 1.29ns 4.82ns 0.0131 0 0 928 B
#5309 ExecuteAsync netcoreapp3.1 1.64μs 1.03ns 3.99ns 0.0124 0 0 928 B
#5309 ExecuteAsync net472 1.95μs 1.5ns 5.83ns 0.141 0 0 891 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.27μs 1.8ns 6.95ns 0.0299 0 0 2.15 KB
master SendAsync netcoreapp3.1 5.11μs 3.75ns 14.5ns 0.0362 0 0 2.69 KB
master SendAsync net472 7.74μs 1.99ns 7.17ns 0.534 0 0 3.37 KB
#5309 SendAsync net6.0 4.17μs 1.89ns 7.07ns 0.0291 0 0 2.16 KB
#5309 SendAsync netcoreapp3.1 5.08μs 2.72ns 9.82ns 0.0356 0 0 2.7 KB
#5309 SendAsync net472 7.91μs 21ns 81.4ns 0.534 0 0 3.38 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5309

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.56 KB 1.57 KB 16 B 1.03%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.63 KB 1.65 KB 16 B 0.98%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.63 KB 1.65 KB 16 B 0.98%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.55μs 1.05ns 4.05ns 0.0227 0 0 1.63 KB
master EnrichedLog netcoreapp3.1 2.16μs 1.43ns 5.56ns 0.0219 0 0 1.63 KB
master EnrichedLog net472 2.75μs 1.84ns 7.11ns 0.246 0 0 1.56 KB
#5309 EnrichedLog net6.0 1.54μs 0.653ns 2.44ns 0.0231 0 0 1.65 KB
#5309 EnrichedLog netcoreapp3.1 2.21μs 2.75ns 10.6ns 0.022 0 0 1.65 KB
#5309 EnrichedLog net472 2.57μs 1.29ns 4.66ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 208ns 806ns 0.0563 0 0 4.22 KB
master EnrichedLog netcoreapp3.1 118μs 99.4ns 385ns 0 0 0 4.22 KB
master EnrichedLog net472 146μs 68.5ns 265ns 0.659 0.22 0 4.4 KB
#5309 EnrichedLog net6.0 113μs 120ns 464ns 0.0564 0 0 4.23 KB
#5309 EnrichedLog netcoreapp3.1 120μs 246ns 953ns 0 0 0 4.23 KB
#5309 EnrichedLog net472 147μs 91ns 352ns 0.657 0.219 0 4.41 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5309

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472 2.01 KB 2.02 KB 16 B 0.80%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0 2.19 KB 2.21 KB 16 B 0.73%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1 2.19 KB 2.21 KB 16 B 0.73%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.94μs 2.26ns 8.46ns 0.031 0 0 2.19 KB
master EnrichedLog netcoreapp3.1 4.29μs 1.94ns 7ns 0.0302 0 0 2.19 KB
master EnrichedLog net472 5.01μs 2.92ns 10.5ns 0.317 0 0 2.01 KB
#5309 EnrichedLog net6.0 3.16μs 1.23ns 4.42ns 0.0305 0 0 2.21 KB
#5309 EnrichedLog netcoreapp3.1 4.23μs 1.99ns 7.45ns 0.0297 0 0 2.21 KB
#5309 EnrichedLog net472 5.09μs 3.62ns 13.6ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5309

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.17 KB 1.18 KB 8 B 0.68%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 1.17 KB 1.18 KB 8 B 0.68%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.17 KB 1.18 KB 8 B 0.68%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.39μs 0.659ns 2.47ns 0.016 0 0 1.17 KB
master SendReceive netcoreapp3.1 1.74μs 1.07ns 3.99ns 0.0156 0 0 1.17 KB
master SendReceive net472 2.24μs 2.03ns 7.87ns 0.185 0 0 1.17 KB
#5309 SendReceive net6.0 1.34μs 0.482ns 1.8ns 0.0168 0 0 1.18 KB
#5309 SendReceive netcoreapp3.1 1.78μs 2.27ns 8.8ns 0.0158 0 0 1.18 KB
#5309 SendReceive net472 2.22μs 1.2ns 4.51ns 0.187 0.00111 0 1.18 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5309

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.54 KB 1.55 KB 16 B 1.04%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1 1.58 KB 1.6 KB 16 B 1.01%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472 1.97 KB 1.99 KB 16 B 0.81%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.68μs 1.16ns 4.49ns 0.0215 0 0 1.54 KB
master EnrichedLog netcoreapp3.1 3.97μs 1.37ns 5.14ns 0.0199 0 0 1.58 KB
master EnrichedLog net472 4.31μs 2.51ns 9.38ns 0.313 0 0 1.97 KB
#5309 EnrichedLog net6.0 2.78μs 11.7ns 45.3ns 0.022 0 0 1.55 KB
#5309 EnrichedLog netcoreapp3.1 3.98μs 2.07ns 8ns 0.0218 0 0 1.6 KB
#5309 EnrichedLog net472 4.38μs 2.58ns 10ns 0.315 0 0 1.99 KB
Benchmarks.Trace.SpanBenchmark - Slower :warning: More allocations :warning:

Slower :warning: in #5309

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.135 565.49 641.96

Faster :tada: in #5309

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.200 537.87 448.39

More allocations :warning: in #5309

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 544 B 552 B 8 B 1.47%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 544 B 552 B 8 B 1.47%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 546 B 554 B 8 B 1.47%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 626 B 634 B 8 B 1.28%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 664 B 672 B 8 B 1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 664 B 672 B 8 B 1.20%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 539ns 1.21ns 4.68ns 0.00756 0 0 544 B
master StartFinishSpan netcoreapp3.1 756ns 0.933ns 3.23ns 0.00717 0 0 544 B
master StartFinishSpan net472 769ns 1.1ns 4.27ns 0.0864 0 0 546 B
master StartFinishScope net6.0 565ns 1.06ns 4.09ns 0.00927 0 0 664 B
master StartFinishScope netcoreapp3.1 844ns 1.08ns 4.04ns 0.00896 0 0 664 B
master StartFinishScope net472 938ns 1.79ns 6.93ns 0.0993 0 0 626 B
#5309 StartFinishSpan net6.0 448ns 0.418ns 1.62ns 0.00781 0 0 552 B
#5309 StartFinishSpan netcoreapp3.1 750ns 0.634ns 2.37ns 0.00751 0 0 552 B
#5309 StartFinishSpan net472 748ns 1.38ns 5.36ns 0.0879 0 0 554 B
#5309 StartFinishScope net6.0 642ns 0.614ns 2.38ns 0.00932 0 0 672 B
#5309 StartFinishScope netcoreapp3.1 892ns 1.13ns 4.39ns 0.00897 0 0 672 B
#5309 StartFinishScope net472 925ns 1.93ns 7.46ns 0.101 0 0 634 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5309

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 626 B 634 B 8 B 1.28%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 664 B 672 B 8 B 1.20%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 664 B 672 B 8 B 1.20%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 713ns 0.804ns 3.12ns 0.00923 0 0 664 B
master RunOnMethodBegin netcoreapp3.1 991ns 0.6ns 2.32ns 0.00892 0 0 664 B
master RunOnMethodBegin net472 1.07μs 3.26ns 11.8ns 0.099 0 0 626 B
#5309 RunOnMethodBegin net6.0 667ns 0.626ns 2.43ns 0.00954 0 0 672 B
#5309 RunOnMethodBegin netcoreapp3.1 980ns 1.01ns 3.64ns 0.00933 0 0 672 B
#5309 RunOnMethodBegin net472 1.07μs 1.39ns 5.39ns 0.101 0 0 634 B

andrewlock avatar Mar 14 '24 17:03 andrewlock

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5309) (10.996M)   : 0, 10996340
    master (10.931M)   : 0, 10931051
    benchmarks/2.9.0 (11.247M)   : 0, 11247223

    section Automatic
    This PR (5309) (7.631M)   : 0, 7631241
    master (7.508M)   : 0, 7507500
    benchmarks/2.9.0 (8.075M)   : 0, 8075266

    section Trace stats
    This PR (5309) (7.958M)   : 0, 7957971
    master (7.940M)   : 0, 7940352

    section Manual
    This PR (5309) (9.630M)   : 0, 9630319
    master (9.575M)   : 0, 9574680

    section Manual + Automatic
    This PR (5309) (7.137M)   : 0, 7136654
    master (7.203M)   : 0, 7203487

    section Version Conflict
    This PR (5309) (6.445M)   : 0, 6445497
    master (6.418M)   : 0, 6418357

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5309) (9.624M)   : 0, 9623998
    master (9.665M)   : 0, 9664633
    benchmarks/2.9.0 (9.694M)   : 0, 9694479

    section Automatic
    This PR (5309) (6.608M)   : 0, 6608010
    master (6.662M)   : 0, 6661891

    section Trace stats
    This PR (5309) (6.866M)   : 0, 6865684
    master (6.844M)   : 0, 6844127

    section Manual
    This PR (5309) (8.089M)   : 0, 8089443
    master (8.363M)   : 0, 8363236

    section Manual + Automatic
    This PR (5309) (6.357M)   : 0, 6357036
    master (6.203M)   : 0, 6203336

    section Version Conflict
    This PR (5309) (5.684M)   : 0, 5683783
    master (5.630M)   : 0, 5629861

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5309) (9.278M)   : 0, 9278078
    master (9.292M)   : 0, 9292153
    benchmarks/2.9.0 (9.301M)   : 0, 9300867

    section Automatic
    This PR (5309) (6.558M)   : 0, 6558393
    master (6.541M)   : 0, 6541370
    benchmarks/2.9.0 (7.022M)   : 0, 7021879

    section Trace stats
    This PR (5309) (6.972M)   : 0, 6971557
    master (6.924M)   : 0, 6923773

    section Manual
    This PR (5309) (8.143M)   : 0, 8142643
    master (8.360M)   : 0, 8360375

    section Manual + Automatic
    This PR (5309) (6.413M)   : 0, 6413131
    master (6.315M)   : 0, 6314813

    section Version Conflict
    This PR (5309) (5.735M)   : 0, 5734517
    master (5.789M)   : 0, 5789117

andrewlock avatar Mar 14 '24 18:03 andrewlock