dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

[ASM] never log WAF at debug level, since

Open robertpi opened this issue 1 year ago • 2 comments

Summary of changes

The WAF produces a high volume of uninteresting logs debug logs, that can spam the logs and make it difficult to investigate issues that require debug logs.

robertpi avatar Mar 11 '24 08:03 robertpi

Datadog Report

Branch report: robert/asm/reduce-waf-logs Commit report: 5a0694a Test service: dd-trace-dotnet

:x: 1 Failed (0 Known Flaky), 323446 Passed, 1576 Skipped, 42m 25.17s Wall Time

:x: Failed Tests (1)

  • Profiler_exceptions - scenarios - Details

    Expand for error 
    erminate called after throwing an instance of 'std::bad_alloc'
 what():  std::bad_alloc

tarting at 03/28/2024 13:33:25

sage:
> Samples.ExceptionGenerator [--service] [--timeout TimeoutInSeconds | --run-infinitely | --scenario Scenario]


nvironment info
..

datadog-ddstaging[bot] avatar Mar 11 '24 08:03 datadog-ddstaging[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5295) - mean (74ms)  : 66, 82
     .   : milestone, 74,
    master - mean (76ms)  : 64, 87
     .   : milestone, 76,

    section CallTarget+Inlining+NGEN
    This PR (5295) - mean (997ms)  : 974, 1021
     .   : milestone, 997,
    master - mean (1,002ms)  : 981, 1022
     .   : milestone, 1002,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5295) - mean (110ms)  : 107, 114
     .   : milestone, 110,
    master - mean (110ms)  : 107, 112
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5295) - mean (719ms)  : 698, 740
     .   : milestone, 719,
    master - mean (718ms)  : 694, 741
     .   : milestone, 718,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5295) - mean (96ms)  : 83, 109
     .   : milestone, 96,
    master - mean (95ms)  : 91, 99
     .   : milestone, 95,

    section CallTarget+Inlining+NGEN
    This PR (5295) - mean (680ms)  : 659, 700
     .   : milestone, 680,
    master - mean (676ms)  : 653, 698
     .   : milestone, 676,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5295) - mean (188ms)  : 185, 191
     .   : milestone, 188,
    master - mean (188ms)  : 184, 192
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5295) - mean (1,083ms)  : 1054, 1112
     .   : milestone, 1083,
    master - mean (1,080ms)  : 1058, 1102
     .   : milestone, 1080,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5295) - mean (272ms)  : 267, 277
     .   : milestone, 272,
    master - mean (272ms)  : 268, 276
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (5295) - mean (878ms)  : 851, 905
     .   : milestone, 878,
    master - mean (874ms)  : 853, 895
     .   : milestone, 874,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5295) - mean (260ms)  : 256, 264
     .   : milestone, 260,
    master - mean (260ms)  : 254, 265
     .   : milestone, 260,

    section CallTarget+Inlining+NGEN
    This PR (5295) - mean (863ms)  : 838, 889
     .   : milestone, 863,
    master - mean (850ms)  : 827, 872
     .   : milestone, 850,

andrewlock avatar Mar 11 '24 18:03 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #5295 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.129
  • 1 benchmarks are slower, with geometric mean 1.119
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.82μs 45.3ns 217ns 0.0265 0.0132 0 7.51 KB
master StartStopWithChild netcoreapp3.1 10.9μs 57.9ns 301ns 0.0328 0.0164 0 7.6 KB
master StartStopWithChild net472 16.7μs 76.8ns 307ns 1.36 0.35 0.117 8.05 KB
#5295 StartStopWithChild net6.0 8.61μs 48.2ns 313ns 0.0247 0.0123 0 7.51 KB
#5295 StartStopWithChild netcoreapp3.1 10.8μs 56.5ns 277ns 0.0216 0.0108 0 7.6 KB
#5295 StartStopWithChild net472 17μs 60ns 232ns 1.36 0.342 0.12 8.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 457μs 549ns 2.13μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 595μs 164ns 612ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 827μs 4.15μs 18.1μs 0.406 0 0 3.3 KB
#5295 WriteAndFlushEnrichedTraces net6.0 455μs 149ns 557ns 0 0 0 2.7 KB
#5295 WriteAndFlushEnrichedTraces netcoreapp3.1 610μs 178ns 641ns 0 0 0 2.7 KB
#5295 WriteAndFlushEnrichedTraces net472 809μs 266ns 1.03μs 0.403 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 171μs 110ns 412ns 0.17 0 0 18.33 KB
master SendRequest netcoreapp3.1 193μs 242ns 937ns 0.191 0 0 20.49 KB
master SendRequest net472 0.00106ns 0.000248ns 0.000893ns 0 0 0 0 b
#5295 SendRequest net6.0 173μs 179ns 694ns 0.173 0 0 18.33 KB
#5295 SendRequest netcoreapp3.1 193μs 209ns 809ns 0.194 0 0 20.49 KB
#5295 SendRequest net472 0.0002ns 0.000157ns 0.000587ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 564μs 2.63μs 10.2μs 0.563 0 0 41.59 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 540ns 1.95μs 0.326 0 0 41.71 KB
master WriteAndFlushEnrichedTraces net472 873μs 4.27μs 18.1μs 8.19 2.59 0.431 53.26 KB
#5295 WriteAndFlushEnrichedTraces net6.0 546μs 830ns 3.22μs 0.546 0 0 41.74 KB
#5295 WriteAndFlushEnrichedTraces netcoreapp3.1 665μs 1.47μs 5.7μs 0.327 0 0 41.65 KB
#5295 WriteAndFlushEnrichedTraces net472 881μs 4.1μs 16.4μs 8.36 2.64 0.44 53.23 KB
Benchmarks.Trace.DbCommandBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #5295

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.129 1,203.40 1,065.78

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.2μs 0.746ns 2.79ns 0.0108 0 0 784 B
master ExecuteNonQuery netcoreapp3.1 1.59μs 0.482ns 1.87ns 0.0105 0 0 784 B
master ExecuteNonQuery net472 1.92μs 1.63ns 5.89ns 0.118 0 0 746 B
#5295 ExecuteNonQuery net6.0 1.07μs 0.319ns 1.24ns 0.0108 0 0 784 B
#5295 ExecuteNonQuery netcoreapp3.1 1.49μs 1ns 3.88ns 0.0104 0 0 784 B
#5295 ExecuteNonQuery net472 1.75μs 0.782ns 2.93ns 0.118 0 0 746 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.34μs 0.371ns 1.39ns 0.0141 0 0 1.01 KB
master CallElasticsearch netcoreapp3.1 1.58μs 1.06ns 3.98ns 0.0134 0 0 1.01 KB
master CallElasticsearch net472 2.42μs 0.888ns 3.32ns 0.162 0 0 1.02 KB
master CallElasticsearchAsync net6.0 1.36μs 0.342ns 1.23ns 0.0136 0 0 984 B
master CallElasticsearchAsync netcoreapp3.1 1.7μs 1.4ns 5.42ns 0.0145 0 0 1.06 KB
master CallElasticsearchAsync net472 2.65μs 1.8ns 6.97ns 0.171 0 0 1.08 KB
#5295 CallElasticsearch net6.0 1.28μs 0.562ns 2.1ns 0.0141 0 0 1.01 KB
#5295 CallElasticsearch netcoreapp3.1 1.68μs 0.818ns 3.06ns 0.0135 0 0 1.01 KB
#5295 CallElasticsearch net472 2.37μs 1.42ns 5.49ns 0.162 0 0 1.02 KB
#5295 CallElasticsearchAsync net6.0 1.36μs 0.903ns 3.38ns 0.0136 0 0 984 B
#5295 CallElasticsearchAsync netcoreapp3.1 1.71μs 1.8ns 6.73ns 0.0145 0 0 1.06 KB
#5295 CallElasticsearchAsync net472 2.64μs 2.75ns 10.7ns 0.17 0 0 1.08 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.47μs 0.551ns 2.06ns 0.0132 0 0 928 B
master ExecuteAsync netcoreapp3.1 1.68μs 0.981ns 3.8ns 0.0126 0 0 928 B
master ExecuteAsync net472 1.94μs 1.56ns 6.05ns 0.141 0 0 891 B
#5295 ExecuteAsync net6.0 1.36μs 5.29ns 20.5ns 0.0127 0 0 928 B
#5295 ExecuteAsync netcoreapp3.1 1.6μs 0.92ns 3.57ns 0.0129 0 0 928 B
#5295 ExecuteAsync net472 1.95μs 0.701ns 2.71ns 0.141 0 0 891 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.3μs 3.67ns 13.7ns 0.0302 0 0 2.16 KB
master SendAsync netcoreapp3.1 4.99μs 1.73ns 6.23ns 0.0357 0 0 2.7 KB
master SendAsync net472 7.61μs 4.09ns 14.7ns 0.483 0 0 3.05 KB
#5295 SendAsync net6.0 4.23μs 1.61ns 6.22ns 0.0296 0 0 2.16 KB
#5295 SendAsync netcoreapp3.1 5.01μs 2.45ns 8.83ns 0.0374 0 0 2.7 KB
#5295 SendAsync net472 7.72μs 3.02ns 11.7ns 0.484 0 0 3.05 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.43μs 0.471ns 1.7ns 0.023 0 0 1.65 KB
master EnrichedLog netcoreapp3.1 2.22μs 1.86ns 7.19ns 0.0225 0 0 1.65 KB
master EnrichedLog net472 2.59μs 1.28ns 4.8ns 0.25 0 0 1.57 KB
#5295 EnrichedLog net6.0 1.59μs 1.18ns 4.42ns 0.0232 0 0 1.65 KB
#5295 EnrichedLog netcoreapp3.1 2.22μs 4.4ns 17ns 0.0225 0 0 1.65 KB
#5295 EnrichedLog net472 2.7μs 2.23ns 8.35ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 111μs 84.1ns 326ns 0.0556 0 0 4.23 KB
master EnrichedLog netcoreapp3.1 117μs 166ns 642ns 0.0582 0 0 4.23 KB
master EnrichedLog net472 146μs 81.6ns 316ns 0.657 0.219 0 4.41 KB
#5295 EnrichedLog net6.0 113μs 174ns 676ns 0.0563 0 0 4.23 KB
#5295 EnrichedLog netcoreapp3.1 117μs 137ns 529ns 0 0 0 4.23 KB
#5295 EnrichedLog net472 148μs 85.3ns 330ns 0.663 0.221 0 4.41 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.09μs 1.06ns 3.83ns 0.0309 0 0 2.21 KB
master EnrichedLog netcoreapp3.1 4.23μs 2.98ns 11.5ns 0.0301 0 0 2.21 KB
master EnrichedLog net472 5μs 2.24ns 8.38ns 0.319 0 0 2.02 KB
#5295 EnrichedLog net6.0 3.01μs 1.02ns 3.83ns 0.0303 0 0 2.21 KB
#5295 EnrichedLog netcoreapp3.1 4.26μs 1.7ns 6.14ns 0.0301 0 0 2.21 KB
#5295 EnrichedLog net472 4.93μs 1.97ns 7.62ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.4μs 0.836ns 3.24ns 0.0168 0 0 1.18 KB
master SendReceive netcoreapp3.1 1.82μs 0.581ns 2.17ns 0.0155 0 0 1.18 KB
master SendReceive net472 2.27μs 1.87ns 7ns 0.187 0.00114 0 1.18 KB
#5295 SendReceive net6.0 1.53μs 2.32ns 8.98ns 0.0167 0 0 1.18 KB
#5295 SendReceive netcoreapp3.1 1.78μs 0.756ns 2.93ns 0.016 0 0 1.18 KB
#5295 SendReceive net472 2.25μs 0.999ns 3.87ns 0.187 0 0 1.18 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.73μs 1.07ns 3.85ns 0.0221 0 0 1.55 KB
master EnrichedLog netcoreapp3.1 3.97μs 2.08ns 8.07ns 0.0219 0 0 1.6 KB
master EnrichedLog net472 4.47μs 3.26ns 12.2ns 0.314 0 0 1.99 KB
#5295 EnrichedLog net6.0 2.68μs 1.16ns 4.35ns 0.0214 0 0 1.55 KB
#5295 EnrichedLog netcoreapp3.1 4μs 2.69ns 10.4ns 0.0221 0 0 1.6 KB
#5295 EnrichedLog net472 4.4μs 2.65ns 9.91ns 0.315 0 0 1.99 KB
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5295

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.119 477.73 534.57

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 477ns 0.588ns 2.2ns 0.00765 0 0 552 B
master StartFinishSpan netcoreapp3.1 639ns 0.885ns 3.43ns 0.00757 0 0 552 B
master StartFinishSpan net472 781ns 1.37ns 5.31ns 0.088 0 0 554 B
master StartFinishScope net6.0 662ns 1.04ns 4.03ns 0.00954 0 0 672 B
master StartFinishScope netcoreapp3.1 922ns 1.18ns 4.42ns 0.00926 0 0 672 B
master StartFinishScope net472 940ns 0.797ns 3.09ns 0.101 0 0 634 B
#5295 StartFinishSpan net6.0 534ns 0.988ns 3.83ns 0.00782 0 0 552 B
#5295 StartFinishSpan netcoreapp3.1 670ns 1.35ns 5.05ns 0.0075 0 0 552 B
#5295 StartFinishSpan net472 766ns 1.36ns 5.27ns 0.0877 0 0 554 B
#5295 StartFinishScope net6.0 656ns 1.63ns 6.31ns 0.00925 0 0 672 B
#5295 StartFinishScope netcoreapp3.1 843ns 1.51ns 5.64ns 0.00926 0 0 672 B
#5295 StartFinishScope net472 949ns 1.52ns 5.88ns 0.101 0 0 634 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 678ns 1.16ns 4.5ns 0.00923 0 0 672 B
master RunOnMethodBegin netcoreapp3.1 980ns 1.17ns 4.55ns 0.00932 0 0 672 B
master RunOnMethodBegin net472 1.07μs 1.15ns 4.44ns 0.1 0 0 634 B
#5295 RunOnMethodBegin net6.0 662ns 0.974ns 3.77ns 0.00938 0 0 672 B
#5295 RunOnMethodBegin netcoreapp3.1 971ns 1.49ns 5.79ns 0.00933 0 0 672 B
#5295 RunOnMethodBegin net472 1.16μs 2.07ns 8.04ns 0.101 0 0 634 B

andrewlock avatar Mar 18 '24 09:03 andrewlock

Benchmarks Report for appsec :snail:

Benchmarks for #5295 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.180
  • 3 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 71.2μs 115ns 431ns 0.0716 0 0 5.97 KB
master AllCycleSimpleBody netcoreapp3.1 61.2μs 82.9ns 321ns 0.0918 0 0 6.92 KB
master AllCycleSimpleBody net472 48.7μs 81.7ns 316ns 1.31 0 0 8.3 KB
master AllCycleMoreComplexBody net6.0 75.4μs 70.1ns 262ns 0.113 0 0 9.48 KB
master AllCycleMoreComplexBody netcoreapp3.1 67.5μs 68ns 263ns 0.134 0 0 10.33 KB
master AllCycleMoreComplexBody net472 55μs 46.9ns 175ns 1.86 0.0274 0 11.82 KB
master ObjectExtractorSimpleBody net6.0 147ns 0.182ns 0.704ns 0.00391 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 213ns 0.285ns 1.11ns 0.00374 0 0 272 B
master ObjectExtractorSimpleBody net472 187ns 0.139ns 0.54ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.09μs 1.26ns 4.55ns 0.0529 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.06μs 2.02ns 7.81ns 0.0507 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.76μs 2.63ns 10.2ns 0.602 0.00562 0 3.8 KB
#5295 AllCycleSimpleBody net6.0 71.3μs 82.1ns 296ns 0.0723 0 0 5.97 KB
#5295 AllCycleSimpleBody netcoreapp3.1 61.5μs 84.2ns 326ns 0.0614 0 0 6.92 KB
#5295 AllCycleSimpleBody net472 48.5μs 51ns 191ns 1.3 0 0 8.3 KB
#5295 AllCycleMoreComplexBody net6.0 77μs 157ns 609ns 0.118 0 0 9.48 KB
#5295 AllCycleMoreComplexBody netcoreapp3.1 68.5μs 109ns 424ns 0.137 0 0 10.33 KB
#5295 AllCycleMoreComplexBody net472 55.4μs 69.5ns 269ns 1.86 0.0277 0 11.82 KB
#5295 ObjectExtractorSimpleBody net6.0 146ns 0.18ns 0.695ns 0.00392 0 0 280 B
#5295 ObjectExtractorSimpleBody netcoreapp3.1 200ns 0.0719ns 0.279ns 0.00365 0 0 272 B
#5295 ObjectExtractorSimpleBody net472 171ns 0.195ns 0.754ns 0.0446 0 0 281 B
#5295 ObjectExtractorMoreComplexBody net6.0 3.04μs 1.77ns 6.63ns 0.0532 0 0 3.78 KB
#5295 ObjectExtractorMoreComplexBody netcoreapp3.1 4.06μs 1.66ns 6.43ns 0.0485 0 0 3.69 KB
#5295 ObjectExtractorMoreComplexBody net472 3.85μs 4.16ns 16.1ns 0.602 0.00577 0 3.8 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 187μs 275ns 1.06μs 0 0 0 6.51 KB
master RunWafRealisticBenchmark netcoreapp3.1 205μs 127ns 490ns 0 0 0 6.49 KB
master RunWafRealisticBenchmark net472 220μs 101ns 390ns 0.987 0 0 6.59 KB
master RunWafRealisticBenchmarkWithAttack net6.0 124μs 47.9ns 179ns 0 0 0 4.15 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 133μs 147ns 531ns 0 0 0 4.15 KB
master RunWafRealisticBenchmarkWithAttack net472 145μs 71.4ns 276ns 0.65 0 0 4.19 KB
#5295 RunWafRealisticBenchmark net6.0 189μs 150ns 580ns 0.0941 0 0 6.51 KB
#5295 RunWafRealisticBenchmark netcoreapp3.1 203μs 432ns 1.62μs 0 0 0 6.49 KB
#5295 RunWafRealisticBenchmark net472 223μs 363ns 1.4μs 0.994 0 0 6.59 KB
#5295 RunWafRealisticBenchmarkWithAttack net6.0 127μs 117ns 454ns 0 0 0 4.15 KB
#5295 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 134μs 201ns 750ns 0 0 0 4.14 KB
#5295 RunWafRealisticBenchmarkWithAttack net472 146μs 34.8ns 135ns 0.652 0 0 4.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower :warning: Fewer allocations :tada:

Slower :warning: in #5295

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 1.180 53,800.00 63,500.00 bimodal

Fewer allocations :tada: in #5295

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 226.23 KB 221.18 KB -5.05 KB -2.23%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 211.19 KB 203.66 KB -7.54 KB -3.57%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 60.02 KB 57.16 KB -2.86 KB -4.76%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 60.1μs 739ns 7.28μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 55.8μs 430ns 4.05μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 37.8μs 172ns 806ns 0 0 0 60.02 KB
master StringConcatAspectBenchmark net6.0 288μs 1.56μs 8.26μs 0 0 0 203.1 KB
master StringConcatAspectBenchmark netcoreapp3.1 315μs 1.74μs 9.99μs 0 0 0 211.19 KB
master StringConcatAspectBenchmark net472 232μs 1.25μs 6.82μs 0 0 0 226.23 KB
#5295 StringConcatBenchmark net6.0 62.2μs 611ns 5.83μs 0 0 0 43.44 KB
#5295 StringConcatBenchmark netcoreapp3.1 63.8μs 794ns 7.82μs 0 0 0 42.64 KB
#5295 StringConcatBenchmark net472 39.5μs 222ns 1.42μs 0 0 0 57.16 KB
#5295 StringConcatAspectBenchmark net6.0 278μs 5.34μs 52.8μs 0 0 0 202.99 KB
#5295 StringConcatAspectBenchmark netcoreapp3.1 308μs 1.73μs 11.9μs 0 0 0 203.66 KB
#5295 StringConcatAspectBenchmark net472 261μs 3.7μs 35.5μs 0 0 0 221.18 KB

andrewlock avatar Mar 18 '24 10:03 andrewlock