dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

Encode the last seen Datadog span ID within `tracestate`

Open bouwkast opened this issue 1 year ago • 4 comments

Summary of changes

This adds a p sub-key to the dd= tracestate with the value of the last seen parent Datadog Span ID encoded as a 16-character hex string. When extracting tracecontext headers the value of p will be added as a _dd.parent_id span tag which can then be used by the backend to reparent the span, if necessary.

Reason for change

When there are datadog and tracecontext headers used in a distributed context we may run into issues where orphaned spans are created within a trace because a W3C tracer doesn't send spans. This gets around that by keeping track of the last seen Datadog span ID within the tracestate.

Implementation details

  • Whenever tracecontext is injected adds the current SpanContext Span ID as the p value.
  • Whenever tracecontext is extracted (and the context is created from those headers) sets the LastParentId on the SpanContext
  • Whenever a Span is serialized, if its SpanContext has a value in LastParentId add that as the _dd.parent_id tag.

Test coverage

  • Updated unit tests
  • Ran micro-benchmarking of the changes to injection/extraction and saw around a 2% performance hit to Inject/Extract code paths.

Other details

bouwkast avatar Feb 12 '24 13:02 bouwkast

Datadog Report

Branch report: steven/encode-last-parent-id Commit report: a317a6a Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 331341 Passed, 1503 Skipped, 43m 20.3s Wall Time :snowflake: 1 New Flaky

New Flaky Tests (1)

  • ObfuscateWithDefaultPattern - Datadog.Trace.Tests.Util.Http.EvidenceRedactorTests - Last Failure

    Expand for error
    xpected string to be "key1=val1&<redacted>&key2=val2" with a length of 30, but "" has a length of 0, differs near "" (index 0).
    

datadog-ddstaging[bot] avatar Feb 12 '24 13:02 datadog-ddstaging[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5176) - mean (72ms)  : 64, 80
     .   : milestone, 72,
    master - mean (74ms)  : 62, 86
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5176) - mean (1,016ms)  : 1001, 1031
     .   : milestone, 1016,
    master - mean (1,016ms)  : 997, 1034
     .   : milestone, 1016,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5176) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (110ms)  : 107, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5176) - mean (739ms)  : 718, 760
     .   : milestone, 739,
    master - mean (737ms)  : 717, 757
     .   : milestone, 737,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5176) - mean (94ms)  : 90, 97
     .   : milestone, 94,
    master - mean (94ms)  : 91, 96
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5176) - mean (690ms)  : 667, 712
     .   : milestone, 690,
    master - mean (687ms)  : 668, 706
     .   : milestone, 687,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5176) - mean (187ms)  : 184, 190
     .   : milestone, 187,
    master - mean (187ms)  : 183, 191
     .   : milestone, 187,

    section CallTarget+Inlining+NGEN
    This PR (5176) - mean (1,075ms)  : 1048, 1102
     .   : milestone, 1075,
    master - mean (1,077ms)  : 1057, 1096
     .   : milestone, 1077,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5176) - mean (270ms)  : 265, 276
     .   : milestone, 270,
    master - mean (272ms)  : 267, 277
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (5176) - mean (872ms)  : 848, 895
     .   : milestone, 872,
    master - mean (872ms)  : 845, 899
     .   : milestone, 872,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5176) - mean (261ms)  : 256, 266
     .   : milestone, 261,
    master - mean (260ms)  : 256, 264
     .   : milestone, 260,

    section CallTarget+Inlining+NGEN
    This PR (5176) - mean (857ms)  : 835, 879
     .   : milestone, 857,
    master - mean (852ms)  : 830, 874
     .   : milestone, 852,

andrewlock avatar Feb 12 '24 14:02 andrewlock

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5176) (11.458M)   : 0, 11457951
    master (11.513M)   : 0, 11513071
    benchmarks/2.9.0 (11.505M)   : 0, 11505055

    section Automatic
    This PR (5176) (7.663M)   : 0, 7663120
    master (7.865M)   : 0, 7865106
    benchmarks/2.9.0 (8.298M)   : 0, 8297530

    section Trace stats
    This PR (5176) (8.118M)   : 0, 8118253
    master (8.191M)   : 0, 8191460

    section Manual
    This PR (5176) (9.695M)   : 0, 9695089
    master (9.818M)   : 0, 9817756

    section Manual + Automatic
    This PR (5176) (7.361M)   : 0, 7361220
    master (7.438M)   : 0, 7438337

    section Version Conflict
    This PR (5176) (6.514M)   : 0, 6514347
    master (6.616M)   : 0, 6616045

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5176) (9.659M)   : 0, 9658747
    master (9.704M)   : 0, 9703592
    benchmarks/2.9.0 (9.448M)   : 0, 9448007

    section Automatic
    This PR (5176) (6.601M)   : 0, 6601277
    master (6.671M)   : 0, 6671028

    section Trace stats
    This PR (5176) (6.839M)   : 0, 6838732
    master (6.942M)   : 0, 6941901

    section Manual
    This PR (5176) (8.192M)   : 0, 8191532
    master (8.091M)   : 0, 8090897

    section Manual + Automatic
    This PR (5176) (6.205M)   : 0, 6205081
    master (6.258M)   : 0, 6258242

    section Version Conflict
    This PR (5176) (5.689M)   : 0, 5689269
    master (5.688M)   : 0, 5687879

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5176) (10.091M)   : 0, 10091159
    master (9.847M)   : 0, 9847483
    benchmarks/2.9.0 (10.119M)   : 0, 10118734

    section Automatic
    This PR (5176) (7.167M)   : 0, 7166910
    master (7.053M)   : 0, 7052591
    benchmarks/2.9.0 (7.382M)   : 0, 7381600

    section Trace stats
    This PR (5176) (7.454M)   : 0, 7454225
    master (7.348M)   : 0, 7347651

    section Manual
    This PR (5176) (8.782M)   : 0, 8781684
    master (8.644M)   : 0, 8644472

    section Manual + Automatic
    This PR (5176) (6.964M)   : 0, 6963766
    master (6.803M)   : 0, 6802962

    section Version Conflict
    This PR (5176) (6.277M)   : 0, 6276963
    master (6.090M)   : 0, 6090004

andrewlock avatar Feb 13 '24 04:02 andrewlock

Benchmarks Report :snail:

Benchmarks for #5176 compared to master:

  • 4 benchmarks are faster, with geometric mean 1.207
  • 2 benchmarks are slower, with geometric mean 1.158
  • 1 benchmarks have fewer allocations
  • 41 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.71μs 49.8ns 372ns 0.0249 0.0125 0 7.49 KB
master StartStopWithChild netcoreapp3.1 11μs 59.7ns 353ns 0.0272 0.0109 0 7.59 KB
master StartStopWithChild net472 17.2μs 51ns 197ns 1.34 0.343 0.112 7.96 KB
#5176 StartStopWithChild net6.0 8.61μs 47.8ns 291ns 0.0213 0.00853 0 7.51 KB
#5176 StartStopWithChild netcoreapp3.1 10.6μs 51.8ns 207ns 0.0364 0.0156 0 7.6 KB
#5176 StartStopWithChild net472 16.9μs 70.4ns 272ns 1.33 0.341 0.0997 7.98 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 450μs 111ns 429ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 624μs 700ns 2.71μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 810μs 197ns 739ns 0.406 0 0 3.3 KB
#5176 WriteAndFlushEnrichedTraces net6.0 461μs 328ns 1.27μs 0 0 0 2.7 KB
#5176 WriteAndFlushEnrichedTraces netcoreapp3.1 644μs 171ns 661ns 0 0 0 2.7 KB
#5176 WriteAndFlushEnrichedTraces net472 807μs 418ns 1.56μs 0.401 0 0 3.3 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #5176

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net472 1.386 237.43 171.29
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody‑net472 1.170 4,521.34 3,864.50

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 41.6μs 61.2ns 237ns 0.021 0 0 2.36 KB
master AllCycleSimpleBody netcoreapp3.1 43.8μs 44.6ns 173ns 0.0218 0 0 2.34 KB
master AllCycleSimpleBody net472 46.6μs 16.6ns 64.4ns 0.374 0 0 2.41 KB
master AllCycleMoreComplexBody net6.0 216μs 85.7ns 332ns 0.107 0 0 9.84 KB
master AllCycleMoreComplexBody netcoreapp3.1 225μs 84.8ns 328ns 0.113 0 0 9.73 KB
master AllCycleMoreComplexBody net472 239μs 48.9ns 183ns 1.56 0 0 9.91 KB
master ObjectExtractorSimpleBody net6.0 146ns 0.712ns 2.93ns 0.00399 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 200ns 0.118ns 0.457ns 0.00372 0 0 272 B
master ObjectExtractorSimpleBody net472 238ns 0.0689ns 0.258ns 0.0445 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.05μs 1.55ns 6.01ns 0.0533 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.02μs 2.01ns 7.77ns 0.0504 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 4.52μs 2.58ns 9.97ns 0.601 0.00678 0 3.8 KB
#5176 AllCycleSimpleBody net6.0 41.1μs 19.5ns 75.4ns 0.0207 0 0 2.37 KB
#5176 AllCycleSimpleBody netcoreapp3.1 43.7μs 23.7ns 88.7ns 0.022 0 0 2.34 KB
#5176 AllCycleSimpleBody net472 46.9μs 24.7ns 92.3ns 0.376 0 0 2.42 KB
#5176 AllCycleMoreComplexBody net6.0 214μs 115ns 444ns 0.106 0 0 9.85 KB
#5176 AllCycleMoreComplexBody netcoreapp3.1 225μs 188ns 727ns 0.111 0 0 9.74 KB
#5176 AllCycleMoreComplexBody net472 241μs 72.3ns 271ns 1.57 0 0 9.92 KB
#5176 ObjectExtractorSimpleBody net6.0 139ns 0.0777ns 0.301ns 0.00393 0 0 280 B
#5176 ObjectExtractorSimpleBody netcoreapp3.1 204ns 0.122ns 0.68ns 0.00379 0 0 272 B
#5176 ObjectExtractorSimpleBody net472 171ns 0.0601ns 0.233ns 0.0446 0 0 281 B
#5176 ObjectExtractorMoreComplexBody net6.0 3.03μs 1.28ns 4.79ns 0.053 0 0 3.78 KB
#5176 ObjectExtractorMoreComplexBody netcoreapp3.1 3.95μs 2.47ns 9.55ns 0.0494 0 0 3.69 KB
#5176 ObjectExtractorMoreComplexBody net472 3.86μs 1.95ns 7.56ns 0.603 0.00578 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 53.3μs 61ns 228ns 0.427 0 0 30.94 KB
master EncodeArgs netcoreapp3.1 75.2μs 83.6ns 313ns 0.413 0 0 31.47 KB
master EncodeArgs net472 84.9μs 60.2ns 233ns 5.11 0.0845 0 32.27 KB
master EncodeLegacyArgs net6.0 127μs 104ns 390ns 0.437 0 0 33.89 KB
master EncodeLegacyArgs netcoreapp3.1 154μs 501ns 1.94μs 0.451 0 0 34.09 KB
master EncodeLegacyArgs net472 211μs 357ns 1.38μs 5.47 0.421 0 34.99 KB
#5176 EncodeArgs net6.0 52.7μs 42.8ns 154ns 0.423 0 0 30.94 KB
#5176 EncodeArgs netcoreapp3.1 68.7μs 57.8ns 216ns 0.411 0 0 31.47 KB
#5176 EncodeArgs net472 84.2μs 51.4ns 199ns 5.09 0.0842 0 32.27 KB
#5176 EncodeLegacyArgs net6.0 121μs 265ns 955ns 0.474 0 0 33.89 KB
#5176 EncodeLegacyArgs netcoreapp3.1 153μs 260ns 1.01μs 0.447 0 0 34.09 KB
#5176 EncodeLegacyArgs net472 217μs 106ns 410ns 5.51 0.433 0 35 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 189μs 149ns 577ns 0.0978 0 0 6.51 KB
master RunWafRealisticBenchmark netcoreapp3.1 204μs 219ns 820ns 0 0 0 6.49 KB
master RunWafRealisticBenchmark net472 226μs 305ns 1.18μs 1.01 0 0 6.59 KB
master RunWafRealisticBenchmarkWithAttack net6.0 126μs 253ns 980ns 0.0644 0 0 4.15 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 134μs 132ns 512ns 0 0 0 4.14 KB
master RunWafRealisticBenchmarkWithAttack net472 147μs 78.5ns 304ns 0.659 0 0 4.19 KB
#5176 RunWafRealisticBenchmark net6.0 192μs 199ns 772ns 0.0959 0 0 6.51 KB
#5176 RunWafRealisticBenchmark netcoreapp3.1 203μs 370ns 1.43μs 0 0 0 6.49 KB
#5176 RunWafRealisticBenchmark net472 225μs 116ns 451ns 1.01 0 0 6.59 KB
#5176 RunWafRealisticBenchmarkWithAttack net6.0 126μs 48.9ns 189ns 0.0636 0 0 4.15 KB
#5176 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 133μs 147ns 568ns 0 0 0 4.14 KB
#5176 RunWafRealisticBenchmarkWithAttack net472 148μs 81.3ns 315ns 0.661 0 0 4.19 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑net6.0 18.26 KB 18.37 KB 113 B 0.62%
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑netcoreapp3.1 20.42 KB 20.53 KB 112 B 0.55%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 171μs 165ns 639ns 0.256 0 0 18.26 KB
master SendRequest netcoreapp3.1 194μs 274ns 1.06μs 0.194 0 0 20.42 KB
master SendRequest net472 0.000118ns 0.000118ns 0.000424ns 0 0 0 0 b
#5176 SendRequest net6.0 175μs 216ns 836ns 0.175 0 0 18.37 KB
#5176 SendRequest netcoreapp3.1 195μs 153ns 574ns 0.195 0 0 20.53 KB
#5176 SendRequest net472 0.000503ns 0.000219ns 0.000848ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 547μs 1.41μs 5.28μs 0.551 0 0 41.61 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 678μs 775ns 3μs 0.338 0 0 41.68 KB
master WriteAndFlushEnrichedTraces net472 854μs 3.79μs 14.7μs 8.45 2.53 0.422 53.25 KB
#5176 WriteAndFlushEnrichedTraces net6.0 559μs 2.14μs 8.28μs 0.541 0 0 41.81 KB
#5176 WriteAndFlushEnrichedTraces netcoreapp3.1 663μs 388ns 1.5μs 0.322 0 0 41.71 KB
#5176 WriteAndFlushEnrichedTraces net472 863μs 3.36μs 13μs 8.19 2.59 0.431 53.22 KB
Benchmarks.Trace.DbCommandBenchmark - Faster :tada: More allocations :warning:

Faster :tada: in #5176

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.125 1,219.38 1,084.09

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472 738 B 746 B 8 B 1.08%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 776 B 784 B 8 B 1.03%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 776 B 784 B 8 B 1.03%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.22μs 0.705ns 2.64ns 0.0104 0 0 776 B
master ExecuteNonQuery netcoreapp3.1 1.57μs 4.48ns 16.1ns 0.00998 0 0 776 B
master ExecuteNonQuery net472 1.73μs 0.685ns 2.65ns 0.117 0 0 738 B
#5176 ExecuteNonQuery net6.0 1.08μs 0.232ns 0.837ns 0.0108 0 0 784 B
#5176 ExecuteNonQuery netcoreapp3.1 1.55μs 0.736ns 2.75ns 0.0101 0 0 784 B
#5176 ExecuteNonQuery net472 1.78μs 0.425ns 1.53ns 0.118 0 0 746 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 920 B 928 B 8 B 0.87%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 944 B 952 B 8 B 0.85%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 944 B 952 B 8 B 0.85%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472 963 B 971 B 8 B 0.83%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 992 B 1 KB 8 B 0.81%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472 1.02 KB 1.03 KB 8 B 0.79%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.23μs 0.765ns 2.96ns 0.0133 0 0 944 B
master CallElasticsearch netcoreapp3.1 1.47μs 1.04ns 4.04ns 0.0127 0 0 944 B
master CallElasticsearch net472 2.54μs 1.27ns 4.93ns 0.153 0 0 963 B
master CallElasticsearchAsync net6.0 1.23μs 0.699ns 2.71ns 0.0129 0 0 920 B
master CallElasticsearchAsync netcoreapp3.1 1.58μs 0.867ns 3.36ns 0.0135 0 0 992 B
master CallElasticsearchAsync net472 2.68μs 6.8ns 26.4ns 0.161 0 0 1.02 KB
#5176 CallElasticsearch net6.0 1.22μs 0.642ns 2.31ns 0.0134 0 0 952 B
#5176 CallElasticsearch netcoreapp3.1 1.49μs 0.589ns 2.28ns 0.0127 0 0 952 B
#5176 CallElasticsearch net472 2.42μs 1.11ns 3.99ns 0.153 0 0 971 B
#5176 CallElasticsearchAsync net6.0 1.25μs 0.535ns 2.07ns 0.0132 0 0 928 B
#5176 CallElasticsearchAsync netcoreapp3.1 1.6μs 0.511ns 1.91ns 0.0135 0 0 1 KB
#5176 CallElasticsearchAsync net472 2.71μs 1.91ns 7.38ns 0.163 0 0 1.03 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472 883 B 891 B 8 B 0.91%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 920 B 928 B 8 B 0.87%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 920 B 928 B 8 B 0.87%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.3μs 0.468ns 1.75ns 0.0125 0 0 920 B
master ExecuteAsync netcoreapp3.1 1.62μs 0.547ns 2.12ns 0.0121 0 0 920 B
master ExecuteAsync net472 1.89μs 0.312ns 1.17ns 0.14 0 0 883 B
#5176 ExecuteAsync net6.0 1.26μs 0.934ns 3.49ns 0.0126 0 0 928 B
#5176 ExecuteAsync netcoreapp3.1 1.71μs 0.625ns 2.25ns 0.0127 0 0 928 B
#5176 ExecuteAsync net472 1.82μs 0.57ns 2.05ns 0.141 0 0 891 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.HttpClientBenchmark.SendAsync‑net472 3.31 KB 3.51 KB 201 B 6.07%
Benchmarks.Trace.HttpClientBenchmark.SendAsync‑net6.0 2.1 KB 2.2 KB 96 B 4.56%
Benchmarks.Trace.HttpClientBenchmark.SendAsync‑netcoreapp3.1 2.64 KB 2.74 KB 96 B 3.64%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.18μs 1.31ns 5.06ns 0.0293 0 0 2.1 KB
master SendAsync netcoreapp3.1 5.04μs 2.45ns 9.18ns 0.0354 0 0 2.64 KB
master SendAsync net472 7.65μs 2.47ns 9.57ns 0.526 0 0 3.31 KB
#5176 SendAsync net6.0 4.05μs 1.55ns 5.79ns 0.0305 0 0 2.2 KB
#5176 SendAsync netcoreapp3.1 5.13μs 1.55ns 5.8ns 0.036 0 0 2.74 KB
#5176 SendAsync net472 7.76μs 2.46ns 9.52ns 0.556 0.00389 0 3.51 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower :warning: More allocations :warning:

Slower :warning: in #5176

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 1.198 51,750.00 62,000.00 bimodal

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 203.49 KB 213.86 KB 10.37 KB 5.10%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 221.18 KB 229.38 KB 8.19 KB 3.70%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 57.34 KB 58.05 KB 704 B 1.23%

Fewer allocations :tada: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 213.06 KB 202.21 KB -10.85 KB -5.09%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 61.4μs 922ns 9.22μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 51.9μs 251ns 971ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 37.4μs 158ns 592ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 264μs 3.94μs 36.6μs 0 0 0 203.49 KB
master StringConcatAspectBenchmark netcoreapp3.1 288μs 1.42μs 6.37μs 0 0 0 213.06 KB
master StringConcatAspectBenchmark net472 222μs 1.08μs 4.84μs 0 0 0 221.18 KB
#5176 StringConcatBenchmark net6.0 54.8μs 227ns 817ns 0 0 0 43.44 KB
#5176 StringConcatBenchmark netcoreapp3.1 60.8μs 753ns 7.34μs 0 0 0 42.64 KB
#5176 StringConcatBenchmark net472 37.5μs 111ns 414ns 0 0 0 58.05 KB
#5176 StringConcatAspectBenchmark net6.0 242μs 3.95μs 37.7μs 0 0 0 213.86 KB
#5176 StringConcatAspectBenchmark netcoreapp3.1 277μs 1.49μs 8.3μs 0 0 0 202.21 KB
#5176 StringConcatAspectBenchmark net472 233μs 1.22μs 7.14μs 0 0 0 229.38 KB
Benchmarks.Trace.ILoggerBenchmark - Slower :warning: More allocations :warning:

Slower :warning: in #5176

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.119 2,064.32 2,309.34

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.51 KB 1.52 KB 16 B 1.06%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.58 KB 1.59 KB 16 B 1.01%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.58 KB 1.59 KB 16 B 1.01%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.43μs 0.492ns 1.91ns 0.0222 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 2.06μs 0.915ns 3.54ns 0.0216 0 0 1.58 KB
master EnrichedLog net472 2.48μs 2.83ns 11ns 0.239 0 0 1.51 KB
#5176 EnrichedLog net6.0 1.47μs 0.455ns 1.76ns 0.0223 0 0 1.59 KB
#5176 EnrichedLog netcoreapp3.1 2.31μs 0.882ns 3.3ns 0.0222 0 0 1.59 KB
#5176 EnrichedLog net472 2.63μs 1.17ns 4.37ns 0.241 0 0 1.52 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 192ns 743ns 0 0 0 4.22 KB
master EnrichedLog netcoreapp3.1 119μs 159ns 595ns 0 0 0 4.22 KB
master EnrichedLog net472 146μs 74.2ns 278ns 0.656 0.219 0 4.4 KB
#5176 EnrichedLog net6.0 111μs 54.8ns 205ns 0.0557 0 0 4.23 KB
#5176 EnrichedLog netcoreapp3.1 119μs 220ns 852ns 0.0591 0 0 4.23 KB
#5176 EnrichedLog net472 147μs 212ns 820ns 0.662 0.221 0 4.41 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472 1.95 KB 1.97 KB 16 B 0.82%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0 2.14 KB 2.15 KB 16 B 0.75%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1 2.14 KB 2.15 KB 16 B 0.75%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.99μs 0.943ns 3.4ns 0.0301 0 0 2.14 KB
master EnrichedLog netcoreapp3.1 4.12μs 1.36ns 5.1ns 0.0286 0 0 2.14 KB
master EnrichedLog net472 4.79μs 0.87ns 3.37ns 0.31 0 0 1.95 KB
#5176 EnrichedLog net6.0 3.04μs 0.967ns 3.75ns 0.0289 0 0 2.15 KB
#5176 EnrichedLog netcoreapp3.1 4.19μs 1.73ns 6.71ns 0.0295 0 0 2.15 KB
#5176 EnrichedLog net472 4.85μs 1.7ns 6.58ns 0.311 0 0 1.97 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.11 KB 1.12 KB 8 B 0.72%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 1.11 KB 1.12 KB 8 B 0.72%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.12 KB 1.13 KB 8 B 0.71%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.37μs 0.66ns 2.47ns 0.0153 0 0 1.11 KB
master SendReceive netcoreapp3.1 1.71μs 1.24ns 4.81ns 0.0147 0 0 1.11 KB
master SendReceive net472 2.13μs 2.09ns 8.1ns 0.178 0 0 1.12 KB
#5176 SendReceive net6.0 1.35μs 0.91ns 3.53ns 0.0156 0 0 1.12 KB
#5176 SendReceive netcoreapp3.1 1.82μs 1.65ns 6.39ns 0.0156 0 0 1.12 KB
#5176 SendReceive net472 2.07μs 2.98ns 11.5ns 0.18 0 0 1.13 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.54 KB 1.55 KB 16 B 1.04%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1 1.58 KB 1.6 KB 16 B 1.01%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472 1.97 KB 1.99 KB 16 B 0.81%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.81μs 1ns 3.74ns 0.0211 0 0 1.54 KB
master EnrichedLog netcoreapp3.1 3.8μs 1.53ns 5.72ns 0.021 0 0 1.58 KB
master EnrichedLog net472 4.28μs 2.38ns 9.23ns 0.312 0 0 1.97 KB
#5176 EnrichedLog net6.0 2.76μs 0.79ns 2.95ns 0.0209 0 0 1.55 KB
#5176 EnrichedLog netcoreapp3.1 3.84μs 1.23ns 4.77ns 0.0211 0 0 1.6 KB
#5176 EnrichedLog net472 4.38μs 1.18ns 4.42ns 0.316 0 0 1.99 KB
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 544 B 552 B 8 B 1.47%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 544 B 552 B 8 B 1.47%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 546 B 554 B 8 B 1.47%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 626 B 634 B 8 B 1.28%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 664 B 672 B 8 B 1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 664 B 672 B 8 B 1.20%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 515ns 0.986ns 3.82ns 0.00751 0 0 544 B
master StartFinishSpan netcoreapp3.1 677ns 1.4ns 5.41ns 0.00725 0 0 544 B
master StartFinishSpan net472 753ns 1.2ns 4.67ns 0.0865 0 0 546 B
master StartFinishScope net6.0 632ns 0.536ns 1.93ns 0.00931 0 0 664 B
master StartFinishScope netcoreapp3.1 900ns 1.8ns 6.97ns 0.00893 0 0 664 B
master StartFinishScope net472 977ns 1.95ns 7.56ns 0.0991 0 0 626 B
#5176 StartFinishSpan net6.0 502ns 0.767ns 2.97ns 0.00784 0 0 552 B
#5176 StartFinishSpan netcoreapp3.1 719ns 3.65ns 15.9ns 0.00746 0 0 552 B
#5176 StartFinishSpan net472 733ns 1.79ns 6.92ns 0.0878 0 0 554 B
#5176 StartFinishScope net6.0 616ns 1.2ns 4.63ns 0.00938 0 0 672 B
#5176 StartFinishScope netcoreapp3.1 827ns 1.91ns 7.4ns 0.00909 0 0 672 B
#5176 StartFinishScope net472 994ns 0.74ns 2.87ns 0.1 0 0 634 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster :tada: More allocations :warning:

Faster :tada: in #5176

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.164 722.13 620.54

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 626 B 634 B 8 B 1.28%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 664 B 672 B 8 B 1.20%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 664 B 672 B 8 B 1.20%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 721ns 0.736ns 2.85ns 0.00925 0 0 664 B
master RunOnMethodBegin netcoreapp3.1 994ns 2.15ns 8.31ns 0.00883 0 0 664 B
master RunOnMethodBegin net472 1.1μs 3.72ns 14.4ns 0.0994 0 0 626 B
#5176 RunOnMethodBegin net6.0 621ns 1.25ns 4.83ns 0.00936 0 0 672 B
#5176 RunOnMethodBegin netcoreapp3.1 1μs 2.3ns 8.91ns 0.0091 0 0 672 B
#5176 RunOnMethodBegin net472 1.07μs 1.91ns 7.38ns 0.101 0 0 634 B

andrewlock avatar Mar 01 '24 02:03 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #5176 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.161
  • 38 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.7μs 47.5ns 277ns 0.0215 0.00858 0 7.54 KB
master StartStopWithChild netcoreapp3.1 11μs 60.6ns 368ns 0.0205 0.0103 0 7.63 KB
master StartStopWithChild net472 16.8μs 55.4ns 215ns 1.33 0.341 0.0937 8.08 KB
#5176 StartStopWithChild net6.0 8.69μs 48.7ns 316ns 0.0169 0.00847 0 7.55 KB
#5176 StartStopWithChild netcoreapp3.1 10.8μs 39ns 146ns 0.0207 0.0103 0 7.65 KB
#5176 StartStopWithChild net472 17.3μs 80.2ns 311ns 1.36 0.365 0.0934 8.11 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 473μs 114ns 413ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 635μs 138ns 499ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 813μs 513ns 1.99μs 0.406 0 0 3.3 KB
#5176 WriteAndFlushEnrichedTraces net6.0 485μs 335ns 1.3μs 0 0 0 2.7 KB
#5176 WriteAndFlushEnrichedTraces netcoreapp3.1 618μs 207ns 802ns 0 0 0 2.7 KB
#5176 WriteAndFlushEnrichedTraces net472 830μs 134ns 500ns 0.414 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑net6.0 18.38 KB 18.49 KB 112 B 0.61%
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑netcoreapp3.1 20.54 KB 20.65 KB 112 B 0.55%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 171μs 156ns 606ns 0.259 0 0 18.38 KB
master SendRequest netcoreapp3.1 189μs 171ns 594ns 0.19 0 0 20.54 KB
master SendRequest net472 6.09E‑05ns 6.09E‑05ns 0.000236ns 0 0 0 0 b
#5176 SendRequest net6.0 170μs 223ns 863ns 0.257 0 0 18.49 KB
#5176 SendRequest netcoreapp3.1 192μs 276ns 1.07μs 0.192 0 0 20.65 KB
#5176 SendRequest net472 0.00018ns 9.72E‑05ns 0.000364ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 542μs 1.06μs 4.1μs 0.553 0 0 41.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 660μs 675ns 2.62μs 0.326 0 0 41.87 KB
master WriteAndFlushEnrichedTraces net472 880μs 3.55μs 13.8μs 8.09 2.25 0.45 53.25 KB
#5176 WriteAndFlushEnrichedTraces net6.0 541μs 737ns 2.76μs 0.558 0 0 41.61 KB
#5176 WriteAndFlushEnrichedTraces netcoreapp3.1 654μs 1.99μs 7.71μs 0.326 0 0 41.97 KB
#5176 WriteAndFlushEnrichedTraces net472 852μs 2.25μs 8.71μs 8.25 2.6 0.434 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472 762 B 770 B 8 B 1.05%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 800 B 808 B 8 B 1.00%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 800 B 808 B 8 B 1.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.21μs 0.6ns 2.25ns 0.011 0 0 800 B
master ExecuteNonQuery netcoreapp3.1 1.48μs 1.54ns 5.96ns 0.011 0 0 800 B
master ExecuteNonQuery net472 1.82μs 1.02ns 3.95ns 0.121 0 0 762 B
#5176 ExecuteNonQuery net6.0 1.19μs 0.597ns 2.31ns 0.0112 0 0 808 B
#5176 ExecuteNonQuery netcoreapp3.1 1.45μs 0.349ns 1.3ns 0.0109 0 0 808 B
#5176 ExecuteNonQuery net472 1.81μs 0.698ns 2.52ns 0.122 0 0 770 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1 KB 1.01 KB 8 B 0.80%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.02 KB 1.03 KB 8 B 0.78%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.02 KB 1.03 KB 8 B 0.78%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472 1.04 KB 1.04 KB 8 B 0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 1.07 KB 1.08 KB 8 B 0.75%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472 1.09 KB 1.1 KB 8 B 0.73%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.3μs 0.872ns 3.38ns 0.0143 0 0 1.02 KB
master CallElasticsearch netcoreapp3.1 1.62μs 3.53ns 13.2ns 0.0139 0 0 1.02 KB
master CallElasticsearch net472 2.57μs 1.51ns 5.84ns 0.164 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.31μs 0.741ns 2.87ns 0.0137 0 0 1 KB
master CallElasticsearchAsync netcoreapp3.1 1.71μs 1.06ns 3.95ns 0.0147 0 0 1.07 KB
master CallElasticsearchAsync net472 2.7μs 6.8ns 26.3ns 0.173 0 0 1.09 KB
#5176 CallElasticsearch net6.0 1.32μs 1.95ns 7.57ns 0.0145 0 0 1.03 KB
#5176 CallElasticsearch netcoreapp3.1 1.61μs 1.02ns 3.54ns 0.0138 0 0 1.03 KB
#5176 CallElasticsearch net472 2.48μs 0.902ns 3.37ns 0.165 0 0 1.04 KB
#5176 CallElasticsearchAsync net6.0 1.35μs 0.351ns 1.31ns 0.0143 0 0 1.01 KB
#5176 CallElasticsearchAsync netcoreapp3.1 1.64μs 0.741ns 2.87ns 0.0146 0 0 1.08 KB
#5176 CallElasticsearchAsync net472 2.6μs 1.13ns 4.21ns 0.174 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472 907 B 915 B 8 B 0.88%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 944 B 952 B 8 B 0.85%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 944 B 952 B 8 B 0.85%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.4μs 0.434ns 1.63ns 0.0132 0 0 944 B
master ExecuteAsync netcoreapp3.1 1.72μs 0.732ns 2.74ns 0.0123 0 0 944 B
master ExecuteAsync net472 1.69μs 0.662ns 2.56ns 0.144 0 0 907 B
#5176 ExecuteAsync net6.0 1.31μs 0.594ns 2.3ns 0.0136 0 0 952 B
#5176 ExecuteAsync netcoreapp3.1 1.62μs 0.89ns 3.33ns 0.013 0 0 952 B
#5176 ExecuteAsync net472 1.77μs 0.771ns 2.99ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.HttpClientBenchmark.SendAsync‑net6.0 2.18 KB 2.27 KB 96 B 4.41%
Benchmarks.Trace.HttpClientBenchmark.SendAsync‑net472 3.07 KB 3.18 KB 112 B 3.65%
Benchmarks.Trace.HttpClientBenchmark.SendAsync‑netcoreapp3.1 2.71 KB 2.81 KB 96 B 3.54%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.23μs 3.18ns 12.3ns 0.0293 0 0 2.18 KB
master SendAsync netcoreapp3.1 5.03μs 1.99ns 7.72ns 0.0375 0 0 2.71 KB
master SendAsync net472 7.71μs 1.65ns 6.18ns 0.487 0 0 3.07 KB
#5176 SendAsync net6.0 3.96μs 1.56ns 5.83ns 0.0318 0 0 2.27 KB
#5176 SendAsync netcoreapp3.1 5.13μs 1.58ns 5.71ns 0.0384 0 0 2.81 KB
#5176 SendAsync net472 7.91μs 2.61ns 10.1ns 0.502 0 0 3.18 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.61 KB 1.62 KB 16 B 1.00%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.68 KB 1.7 KB 16 B 0.95%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.68 KB 1.7 KB 16 B 0.95%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.55μs 0.471ns 1.76ns 0.024 0 0 1.68 KB
master EnrichedLog netcoreapp3.1 2.32μs 1.37ns 5.13ns 0.0231 0 0 1.68 KB
master EnrichedLog net472 2.67μs 1.28ns 4.8ns 0.254 0 0 1.61 KB
#5176 EnrichedLog net6.0 1.55μs 0.74ns 2.87ns 0.0238 0 0 1.7 KB
#5176 EnrichedLog netcoreapp3.1 2.14μs 0.713ns 2.67ns 0.0232 0 0 1.7 KB
#5176 EnrichedLog net472 2.67μs 2.35ns 9.08ns 0.257 0 0 1.62 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 115μs 127ns 476ns 0.057 0 0 4.26 KB
master EnrichedLog netcoreapp3.1 120μs 232ns 899ns 0 0 0 4.26 KB
master EnrichedLog net472 151μs 148ns 571ns 0.68 0.227 0 4.44 KB
#5176 EnrichedLog net6.0 115μs 210ns 813ns 0.0571 0 0 4.28 KB
#5176 EnrichedLog netcoreapp3.1 120μs 202ns 783ns 0 0 0 4.28 KB
#5176 EnrichedLog net472 151μs 233ns 902ns 0.676 0.225 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472 2.05 KB 2.07 KB 16 B 0.78%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0 2.24 KB 2.25 KB 16 B 0.72%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1 2.24 KB 2.25 KB 16 B 0.72%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.02μs 0.973ns 3.77ns 0.0317 0 0 2.24 KB
master EnrichedLog netcoreapp3.1 4.11μs 2.57ns 9.95ns 0.0295 0 0 2.24 KB
master EnrichedLog net472 4.78μs 1.35ns 5.23ns 0.326 0 0 2.05 KB
#5176 EnrichedLog net6.0 3.1μs 1.28ns 4.96ns 0.0324 0 0 2.25 KB
#5176 EnrichedLog netcoreapp3.1 4.35μs 12.1ns 46.9ns 0.0299 0 0 2.25 KB
#5176 EnrichedLog net472 4.82μs 1.51ns 5.83ns 0.327 0 0 2.07 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.19 KB 1.2 KB 8 B 0.67%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 1.19 KB 1.2 KB 8 B 0.67%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.2 KB 1.2 KB 8 B 0.67%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.39μs 0.824ns 3.08ns 0.0168 0 0 1.19 KB
master SendReceive netcoreapp3.1 1.79μs 3ns 11.2ns 0.0159 0 0 1.19 KB
master SendReceive net472 2.27μs 1.68ns 6.06ns 0.19 0 0 1.2 KB
#5176 SendReceive net6.0 1.5μs 0.647ns 2.42ns 0.0172 0 0 1.2 KB
#5176 SendReceive netcoreapp3.1 1.88μs 0.843ns 3.26ns 0.016 0 0 1.2 KB
#5176 SendReceive net472 2.34μs 1.81ns 6.76ns 0.191 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.58 KB 1.6 KB 16 B 1.01%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1 1.63 KB 1.65 KB 16 B 0.98%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472 2.02 KB 2.04 KB 16 B 0.79%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.68μs 0.767ns 2.87ns 0.0228 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 3.9μs 2.21ns 8.56ns 0.0212 0 0 1.63 KB
master EnrichedLog net472 4.42μs 2.28ns 8.82ns 0.32 0 0 2.02 KB
#5176 EnrichedLog net6.0 2.79μs 0.8ns 2.99ns 0.0223 0 0 1.6 KB
#5176 EnrichedLog netcoreapp3.1 4.06μs 1.43ns 5.53ns 0.0205 0 0 1.65 KB
#5176 EnrichedLog net472 4.55μs 2.18ns 8.44ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 568 B 576 B 8 B 1.41%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 568 B 576 B 8 B 1.41%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 570 B 578 B 8 B 1.40%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 650 B 658 B 8 B 1.23%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 688 B 696 B 8 B 1.16%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 688 B 696 B 8 B 1.16%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 476ns 1.12ns 4.34ns 0.00806 0 0 568 B
master StartFinishSpan netcoreapp3.1 786ns 2.21ns 8.55ns 0.00748 0 0 568 B
master StartFinishSpan net472 739ns 0.833ns 3ns 0.0903 0.000376 0 570 B
master StartFinishScope net6.0 557ns 0.712ns 2.66ns 0.00973 0 0 688 B
master StartFinishScope netcoreapp3.1 782ns 1.47ns 5.71ns 0.00916 0 0 688 B
master StartFinishScope net472 969ns 2.19ns 8.5ns 0.103 0 0 650 B
#5176 StartFinishSpan net6.0 517ns 0.78ns 3.02ns 0.00818 0 0 576 B
#5176 StartFinishSpan netcoreapp3.1 709ns 0.802ns 2.89ns 0.00784 0 0 576 B
#5176 StartFinishSpan net472 803ns 2.09ns 8.1ns 0.0918 0 0 578 B
#5176 StartFinishScope net6.0 617ns 1.43ns 5.53ns 0.00981 0 0 696 B
#5176 StartFinishScope netcoreapp3.1 863ns 1.38ns 5.17ns 0.0094 0 0 696 B
#5176 StartFinishScope net472 964ns 1.8ns 6.98ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower :warning: More allocations :warning:

Slower :warning: in #5176

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 1.161 837.87 972.81

More allocations :warning: in #5176

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 650 B 658 B 8 B 1.23%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 688 B 696 B 8 B 1.16%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 688 B 696 B 8 B 1.16%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 659ns 0.894ns 3.46ns 0.00967 0 0 688 B
master RunOnMethodBegin netcoreapp3.1 838ns 1.07ns 3.72ns 0.00915 0 0 688 B
master RunOnMethodBegin net472 1.11μs 1.85ns 7.15ns 0.103 0 0 650 B
#5176 RunOnMethodBegin net6.0 632ns 0.643ns 2.4ns 0.00977 0 0 696 B
#5176 RunOnMethodBegin netcoreapp3.1 973ns 1.31ns 5.06ns 0.00933 0 0 696 B
#5176 RunOnMethodBegin net472 1.09μs 1.78ns 6.91ns 0.104 0 0 658 B

andrewlock avatar Mar 19 '24 20:03 andrewlock