dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

[Dynamic Instrumentation] Fix number of locals in async method

Open dudikeleti opened this issue 1 year ago • 4 comments

Summary of changes

This PR fix the incorrect number of locals in async method that has "real" locals - i.e. locals that aren't hoisted (because they are not in use between awaits).

Test coverage

AsyncMethodNoHoisted

dudikeleti avatar Feb 01 '24 08:02 dudikeleti

Datadog Report

Branch report: dudik/incorrect-locals-number-async-method Commit report: e9578ee Test service: dd-trace-dotnet

:x: 52 Failed (0 Known Flaky), 306624 Passed, 1992 Skipped, 59m 36.35s Wall Time

:x: Failed Tests (52)

This report shows up to 5 failed tests.

  • MethodProbeTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

    Expand for error
    esults do not match.
    ifferences:
    eceived: ProbeTests.TemplateExceptionValue.received.txt
    erified: ProbeTests.TemplateExceptionValue.verified.txt
    eceived Content:
    
     {
       "dd.span_id": "ScrubbedValue",
       "dd.trace_id": "ScrubbedValue",
       "ddsource": "dd_debugger",
    ..
    
  • MethodProbeTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

    Expand for error
    esults do not match.
    ifferences:
    eceived: ProbeTests.TemplateExceptionValue.received.txt
    erified: ProbeTests.TemplateExceptionValue.verified.txt
    eceived Content:
    
     {
       "dd.span_id": "ScrubbedValue",
       "dd.trace_id": "ScrubbedValue",
       "ddsource": "dd_debugger",
    ..
    
  • MethodProbeTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

    Expand for error
    esults do not match.
    ifferences:
    eceived: ProbeTests.TemplateNoException.received.txt
    erified: ProbeTests.TemplateNoException.verified.txt
    eceived Content:
    
     {
       "dd.span_id": "ScrubbedValue",
       "dd.trace_id": "ScrubbedValue",
       "ddsource": "dd_debugger",
    ..
    
  • MethodProbeTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

    Expand for error
    esults do not match.
    ifferences:
    eceived: ProbeTests.TemplateNoException.received.txt
    erified: ProbeTests.TemplateNoException.verified.txt
    eceived Content:
    
     {
       "dd.span_id": "ScrubbedValue",
       "dd.trace_id": "ScrubbedValue",
       "ddsource": "dd_debugger",
    ..
    
  • MethodProbeTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

    Expand for error
    esults do not match.
    ifferences:
    eceived: ProbeTests.TemplateNoException.received.txt
    erified: ProbeTests.TemplateNoException.verified.txt
    eceived Content:
    
     {
       "dd.span_id": "ScrubbedValue",
       "dd.trace_id": "ScrubbedValue",
       "ddsource": "dd_debugger",
    ..
    

datadog-ddstaging[bot] avatar Feb 01 '24 08:02 datadog-ddstaging[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5131) - mean (76ms)  : 65, 86
     .   : milestone, 76,
    master - mean (73ms)  : 67, 79
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5131) - mean (1,013ms)  : 990, 1037
     .   : milestone, 1013,
    master - mean (1,005ms)  : 987, 1024
     .   : milestone, 1005,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5131) - mean (111ms)  : 108, 114
     .   : milestone, 111,
    master - mean (110ms)  : 107, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5131) - mean (727ms)  : 704, 751
     .   : milestone, 727,
    master - mean (723ms)  : 702, 744
     .   : milestone, 723,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5131) - mean (95ms)  : 91, 100
     .   : milestone, 95,
    master - mean (93ms)  : 90, 97
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5131) - mean (682ms)  : 663, 700
     .   : milestone, 682,
    master - mean (677ms)  : 651, 704
     .   : milestone, 677,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5131) - mean (189ms)  : 185, 192
     .   : milestone, 189,
    master - mean (189ms)  : 186, 192
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (5131) - mean (1,080ms)  : 1058, 1102
     .   : milestone, 1080,
    master - mean (1,087ms)  : 1058, 1115
     .   : milestone, 1087,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5131) - mean (271ms)  : 266, 276
     .   : milestone, 271,
    master - mean (273ms)  : 268, 277
     .   : milestone, 273,

    section CallTarget+Inlining+NGEN
    This PR (5131) - mean (875ms)  : 844, 906
     .   : milestone, 875,
    master - mean (877ms)  : 855, 900
     .   : milestone, 877,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5131) - mean (261ms)  : 256, 265
     .   : milestone, 261,
    master - mean (262ms)  : 258, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (5131) - mean (854ms)  : 825, 882
     .   : milestone, 854,
    master - mean (859ms)  : 833, 884
     .   : milestone, 859,

andrewlock avatar Feb 01 '24 08:02 andrewlock

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5131) (11.660M)   : 0, 11659572
    master (11.437M)   : 0, 11436855
    benchmarks/2.9.0 (11.280M)   : 0, 11280359

    section Automatic
    This PR (5131) (7.997M)   : 0, 7996834
    master (7.983M)   : 0, 7983497
    benchmarks/2.9.0 (8.360M)   : 0, 8360007

    section Trace stats
    This PR (5131) (8.319M)   : 0, 8319233
    master (8.226M)   : 0, 8226070

    section Manual
    This PR (5131) (10.257M)   : 0, 10256856
    master (10.130M)   : 0, 10130339

    section Manual + Automatic
    This PR (5131) (7.563M)   : 0, 7563068
    master (7.590M)   : 0, 7590340

    section Version Conflict
    This PR (5131) (6.786M)   : 0, 6785772
    master (6.827M)   : 0, 6826717

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5131) (9.448M)   : 0, 9447903
    master (9.545M)   : 0, 9545432
    benchmarks/2.9.0 (9.532M)   : 0, 9531868

    section Automatic
    This PR (5131) (6.611M)   : 0, 6611165
    master (6.643M)   : 0, 6643404

    section Trace stats
    This PR (5131) (6.943M)   : 0, 6942943
    master (6.939M)   : 0, 6939499

    section Manual
    This PR (5131) (8.446M)   : 0, 8446112
    master (8.360M)   : 0, 8360237

    section Manual + Automatic
    This PR (5131) (6.154M)   : 0, 6153517
    master (6.189M)   : 0, 6189455

    section Version Conflict
    This PR (5131) (5.630M)   : 0, 5629857
    master (5.705M)   : 0, 5705263

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5131) (10.393M)   : 0, 10392584
    master (9.977M)   : 0, 9976981
    benchmarks/2.9.0 (9.979M)   : 0, 9978557

    section Automatic
    This PR (5131) (6.018M)   : crit ,0, 6018250
    master (7.075M)   : 0, 7074682
    benchmarks/2.9.0 (7.450M)   : 0, 7450166

    section Trace stats
    This PR (5131) (7.639M)   : 0, 7639123
    master (7.456M)   : 0, 7456154

    section Manual
    This PR (5131) (9.036M)   : 0, 9035796
    master (8.760M)   : 0, 8759695

    section Manual + Automatic
    This PR (5131) (7.048M)   : 0, 7048436
    master (6.842M)   : 0, 6841906

    section Version Conflict
    This PR (5131) (6.355M)   : 0, 6355330
    master (6.203M)   : 0, 6202571

gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    master (7.489M)   : 0, 7488954
    benchmarks/2.9.0 (7.870M)   : 0, 7870074

    section No attack
    master (1.749M)   : 0, 1748980
    benchmarks/2.9.0 (3.240M)   : 0, 3239596

    section Attack
    master (1.416M)   : 0, 1416134
    benchmarks/2.9.0 (2.506M)   : 0, 2505993

    section Blocking
    master (3.092M)   : 0, 3091627

    section IAST default
    master (6.570M)   : 0, 6569649

    section IAST full
    master (5.693M)   : 0, 5693076

    section Base vuln
    master (0.960M)   : 0, 960468

    section IAST vuln
    master (0.887M)   : 0, 887435

andrewlock avatar Feb 01 '24 08:02 andrewlock

Benchmarks Report :snail:

Benchmarks for #5131 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.173
  • 4 benchmarks are slower, with geometric mean 1.195
  • 2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.54μs 45.7ns 233ns 0.029 0.0124 0 7.49 KB
master StartStopWithChild netcoreapp3.1 10.5μs 49.6ns 185ns 0.0263 0.0105 0 7.58 KB
master StartStopWithChild net472 17.1μs 60ns 232ns 1.32 0.328 0.0948 7.96 KB
#5131 StartStopWithChild net6.0 8.97μs 45.4ns 208ns 0.0302 0.0129 0 7.49 KB
#5131 StartStopWithChild netcoreapp3.1 10.7μs 55.5ns 272ns 0.0275 0.011 0 7.59 KB
#5131 StartStopWithChild net472 17.3μs 65.9ns 255ns 1.34 0.375 0.113 7.95 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 446μs 85.1ns 307ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 613μs 312ns 1.21μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 796μs 488ns 1.89μs 0.393 0 0 3.3 KB
#5131 WriteAndFlushEnrichedTraces net6.0 463μs 147ns 552ns 0 0 0 2.7 KB
#5131 WriteAndFlushEnrichedTraces netcoreapp3.1 627μs 206ns 773ns 0 0 0 2.7 KB
#5131 WriteAndFlushEnrichedTraces net472 774μs 305ns 1.1μs 0.383 0 0 3.3 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5131

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑netcoreapp3.1 1.240 208.60 258.68

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 38.6μs 19.6ns 76ns 0.0192 0 0 2.36 KB
master AllCycleSimpleBody netcoreapp3.1 41.9μs 54.7ns 212ns 0.0208 0 0 2.34 KB
master AllCycleSimpleBody net472 44.8μs 23.5ns 91ns 0.381 0 0 2.41 KB
master AllCycleMoreComplexBody net6.0 203μs 449ns 1.74μs 0.1 0 0 9.84 KB
master AllCycleMoreComplexBody netcoreapp3.1 215μs 293ns 1.14μs 0.105 0 0 9.73 KB
master AllCycleMoreComplexBody net472 225μs 110ns 413ns 1.46 0 0 9.91 KB
master ObjectExtractorSimpleBody net6.0 142ns 0.203ns 0.784ns 0.00395 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 209ns 0.198ns 0.768ns 0.00368 0 0 272 B
master ObjectExtractorSimpleBody net472 165ns 0.0873ns 0.338ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.05μs 1.87ns 7.26ns 0.0533 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.9μs 1.95ns 7.56ns 0.0511 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.74μs 1.87ns 7.25ns 0.603 0.0056 0 3.8 KB
#5131 AllCycleSimpleBody net6.0 39.1μs 23.8ns 92.2ns 0.0194 0 0 2.36 KB
#5131 AllCycleSimpleBody netcoreapp3.1 42.3μs 29.7ns 115ns 0.021 0 0 2.34 KB
#5131 AllCycleSimpleBody net472 44.5μs 14.6ns 52.5ns 0.381 0 0 2.41 KB
#5131 AllCycleMoreComplexBody net6.0 203μs 128ns 495ns 0.1 0 0 9.84 KB
#5131 AllCycleMoreComplexBody netcoreapp3.1 219μs 486ns 1.88μs 0.106 0 0 9.73 KB
#5131 AllCycleMoreComplexBody net472 228μs 66.2ns 256ns 1.48 0 0 9.91 KB
#5131 ObjectExtractorSimpleBody net6.0 141ns 0.169ns 0.631ns 0.00397 0 0 280 B
#5131 ObjectExtractorSimpleBody netcoreapp3.1 259ns 0.183ns 0.709ns 0.00363 0 0 272 B
#5131 ObjectExtractorSimpleBody net472 173ns 0.142ns 0.551ns 0.0446 0 0 281 B
#5131 ObjectExtractorMoreComplexBody net6.0 3.06μs 2.38ns 9.2ns 0.0525 0 0 3.78 KB
#5131 ObjectExtractorMoreComplexBody netcoreapp3.1 3.97μs 1.85ns 6.66ns 0.0515 0 0 3.69 KB
#5131 ObjectExtractorMoreComplexBody net472 3.82μs 2.26ns 8.76ns 0.602 0.00573 0 3.8 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWaf(args=NestedMap (10)) net6.0 53.7μs 190ns 736ns 0.236 0 0 16.66 KB
master RunWaf(args=NestedMap (10)) netcoreapp3.1 70.2μs 394ns 2.64μs 0.212 0 0 16.65 KB
master RunWaf(args=NestedMap (10)) net472 98.9μs 53.7ns 201ns 2.62 0.0987 0 16.73 KB
master RunWafTwice(args=NestedMap (10)) net6.0 57.4μs 330ns 2.76μs 0.224 0 0 17.33 KB
master RunWafTwice(args=NestedMap (10)) netcoreapp3.1 72.7μs 381ns 1.98μs 0.214 0 0 17.31 KB
master RunWafTwice(args=NestedMap (10)) net472 105μs 41.7ns 156ns 2.76 0.106 0 17.42 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 101μs 35.6ns 138ns 0.253 0 0 19.49 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 121μs 551ns 2.13μs 0.234 0 0 19.44 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 150μs 187ns 724ns 3.07 0.0748 0 19.72 KB
master RunWaf(args=NestedMap (100)) net6.0 114μs 169ns 654ns 0.448 0 0 33.35 KB
master RunWaf(args=NestedMap (100)) netcoreapp3.1 136μs 643ns 2.57μs 0.465 0 0 33.92 KB
master RunWaf(args=NestedMap (100)) net472 190μs 111ns 430ns 5.38 0.378 0 34.26 KB
master RunWafTwice(args=NestedMap (100)) net6.0 110μs 51.1ns 191ns 0.436 0 0 34.02 KB
master RunWafTwice(args=NestedMap (100)) netcoreapp3.1 147μs 110ns 426ns 0.468 0 0 34.58 KB
master RunWafTwice(args=NestedMap (100)) net472 199μs 98.2ns 380ns 5.47 0.397 0 34.95 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 156μs 272ns 1.05μs 0.475 0 0 36.18 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 186μs 626ns 2.43μs 0.473 0 0 36.71 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net472 246μs 89.4ns 334ns 5.89 0.491 0 37.26 KB
master RunWaf(args=NestedMap (20)) net6.0 102μs 212ns 970ns 0.461 0 0 32.78 KB
master RunWaf(args=NestedMap (20)) netcoreapp3.1 134μs 636ns 2.7μs 0.407 0 0 32.89 KB
master RunWaf(args=NestedMap (20)) net472 192μs 128ns 495ns 5.23 0.381 0 33.23 KB
master RunWafTwice(args=NestedMap (20)) net6.0 109μs 50.1ns 187ns 0.438 0 0 33.45 KB
master RunWafTwice(args=NestedMap (20)) netcoreapp3.1 141μs 398ns 1.54μs 0.428 0 0 33.55 KB
master RunWafTwice(args=NestedMap (20)) net472 199μs 126ns 472ns 5.37 0.397 0 33.92 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 164μs 616ns 2.39μs 0.493 0 0 35.61 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 192μs 995ns 5.07μs 0.461 0 0 35.68 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 246μs 137ns 529ns 5.64 0.49 0 36.22 KB
#5131 RunWaf(args=NestedMap (10)) net6.0 57.9μs 37.2ns 144ns 0.228 0 0 16.66 KB
#5131 RunWaf(args=NestedMap (10)) netcoreapp3.1 70.5μs 352ns 1.54μs 0.2 0 0 16.65 KB
#5131 RunWaf(args=NestedMap (10)) net472 101μs 57.5ns 223ns 2.62 0.101 0 16.73 KB
#5131 RunWafTwice(args=NestedMap (10)) net6.0 61.3μs 40.3ns 156ns 0.233 0 0 17.33 KB
#5131 RunWafTwice(args=NestedMap (10)) netcoreapp3.1 74.2μs 408ns 2.55μs 0.214 0 0 17.31 KB
#5131 RunWafTwice(args=NestedMap (10)) net472 111μs 450ns 1.74μs 2.76 0.106 0 17.42 KB
#5131 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 103μs 22ns 82.3ns 0.255 0 0 19.49 KB
#5131 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 119μs 310ns 1.2μs 0.239 0 0 19.44 KB
#5131 RunWafWithAttack(args=Neste(...)tack) [22]) net472 151μs 143ns 554ns 3.07 0.15 0 19.72 KB
#5131 RunWaf(args=NestedMap (100)) net6.0 112μs 606ns 3.53μs 0.466 0 0 33.35 KB
#5131 RunWaf(args=NestedMap (100)) netcoreapp3.1 135μs 735ns 3.96μs 0.459 0 0 33.92 KB
#5131 RunWaf(args=NestedMap (100)) net472 193μs 265ns 1.03μs 5.41 0.38 0 34.26 KB
#5131 RunWafTwice(args=NestedMap (100)) net6.0 115μs 51ns 197ns 0.475 0 0 34.02 KB
#5131 RunWafTwice(args=NestedMap (100)) netcoreapp3.1 137μs 665ns 2.66μs 0.409 0 0 34.59 KB
#5131 RunWafTwice(args=NestedMap (100)) net472 197μs 153ns 591ns 5.53 0.395 0 34.95 KB
#5131 RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 162μs 96.5ns 374ns 0.458 0 0 36.18 KB
#5131 RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 192μs 839ns 3.56μs 0.46 0 0 36.71 KB
#5131 RunWafWithAttack(args=Neste(...)tack) [23]) net472 253μs 514ns 1.99μs 5.88 0.375 0 37.26 KB
#5131 RunWaf(args=NestedMap (20)) net6.0 111μs 104ns 405ns 0.431 0 0 32.78 KB
#5131 RunWaf(args=NestedMap (20)) netcoreapp3.1 129μs 45.7ns 177ns 0.402 0 0 32.89 KB
#5131 RunWaf(args=NestedMap (20)) net472 188μs 56.4ns 218ns 5.28 0.377 0 33.23 KB
#5131 RunWafTwice(args=NestedMap (20)) net6.0 112μs 389ns 1.45μs 0.448 0 0 33.45 KB
#5131 RunWafTwice(args=NestedMap (20)) netcoreapp3.1 138μs 679ns 2.88μs 0.408 0 0 33.55 KB
#5131 RunWafTwice(args=NestedMap (20)) net472 195μs 82.5ns 320ns 5.39 0.392 0 33.92 KB
#5131 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 158μs 848ns 4.64μs 0.484 0 0 35.61 KB
#5131 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 190μs 961ns 3.96μs 0.479 0 0 35.68 KB
#5131 RunWafWithAttack(args=Neste(...)tack) [22]) net472 254μs 1.18μs 4.71μs 5.68 0.494 0 36.22 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 174μs 253ns 913ns 0.259 0 0 18.26 KB
master SendRequest netcoreapp3.1 195μs 306ns 1.19μs 0.194 0 0 20.42 KB
master SendRequest net472 0.000332ns 0.000185ns 0.000718ns 0 0 0 0 b
#5131 SendRequest net6.0 173μs 236ns 913ns 0.26 0 0 18.26 KB
#5131 SendRequest netcoreapp3.1 192μs 259ns 968ns 0.192 0 0 20.42 KB
#5131 SendRequest net472 0.000484ns 0.000222ns 0.000829ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 543μs 409ns 1.58μs 0.558 0 0 41.74 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 650μs 1.84μs 7.12μs 0.322 0 0 41.81 KB
master WriteAndFlushEnrichedTraces net472 850μs 3.88μs 15μs 8.33 2.5 0.417 53.24 KB
#5131 WriteAndFlushEnrichedTraces net6.0 545μs 379ns 1.47μs 0.551 0 0 41.71 KB
#5131 WriteAndFlushEnrichedTraces netcoreapp3.1 640μs 1.67μs 6.45μs 0.321 0 0 41.86 KB
#5131 WriteAndFlushEnrichedTraces net472 854μs 3.48μs 13.5μs 8.13 2.57 0.428 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.11μs 0.578ns 2.24ns 0.011 0 0 776 B
master ExecuteNonQuery netcoreapp3.1 1.45μs 0.632ns 2.37ns 0.0102 0 0 776 B
master ExecuteNonQuery net472 1.73μs 1.11ns 4.31ns 0.117 0 0 738 B
#5131 ExecuteNonQuery net6.0 1.08μs 0.71ns 2.75ns 0.0109 0 0 776 B
#5131 ExecuteNonQuery netcoreapp3.1 1.55μs 0.588ns 2.28ns 0.0101 0 0 776 B
#5131 ExecuteNonQuery net472 1.73μs 0.773ns 2.89ns 0.117 0 0 738 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.22μs 0.46ns 1.72ns 0.0134 0 0 944 B
master CallElasticsearch netcoreapp3.1 1.51μs 0.474ns 1.77ns 0.013 0 0 944 B
master CallElasticsearch net472 2.4μs 1.61ns 5.58ns 0.152 0 0 963 B
master CallElasticsearchAsync net6.0 1.33μs 0.852ns 3.19ns 0.0128 0 0 920 B
master CallElasticsearchAsync netcoreapp3.1 1.66μs 0.929ns 3.47ns 0.0133 0 0 992 B
master CallElasticsearchAsync net472 2.7μs 0.63ns 2.36ns 0.162 0 0 1.02 KB
#5131 CallElasticsearch net6.0 1.23μs 0.537ns 2.01ns 0.0135 0 0 944 B
#5131 CallElasticsearch netcoreapp3.1 1.56μs 0.825ns 3.09ns 0.0125 0 0 944 B
#5131 CallElasticsearch net472 2.55μs 1.11ns 4.29ns 0.153 0 0 963 B
#5131 CallElasticsearchAsync net6.0 1.39μs 1.05ns 4.05ns 0.0131 0 0 920 B
#5131 CallElasticsearchAsync netcoreapp3.1 1.63μs 0.947ns 3.67ns 0.0131 0 0 992 B
#5131 CallElasticsearchAsync net472 2.59μs 0.713ns 2.67ns 0.161 0 0 1.02 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.38μs 0.66ns 2.47ns 0.0124 0 0 920 B
master ExecuteAsync netcoreapp3.1 1.66μs 0.529ns 1.83ns 0.012 0 0 920 B
master ExecuteAsync net472 1.84μs 0.663ns 2.57ns 0.14 0 0 883 B
#5131 ExecuteAsync net6.0 1.33μs 0.555ns 2.08ns 0.0127 0 0 920 B
#5131 ExecuteAsync netcoreapp3.1 1.67μs 0.98ns 3.67ns 0.0125 0 0 920 B
#5131 ExecuteAsync net472 1.83μs 1.46ns 5.64ns 0.14 0 0 883 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.04μs 1.04ns 3.88ns 0.0302 0 0 2.1 KB
master SendAsync netcoreapp3.1 4.91μs 24.7ns 131ns 0.0361 0 0 2.64 KB
master SendAsync net472 7.73μs 4.17ns 15.6ns 0.525 0 0 3.31 KB
#5131 SendAsync net6.0 3.95μs 1.27ns 4.91ns 0.0296 0 0 2.1 KB
#5131 SendAsync netcoreapp3.1 4.91μs 2.56ns 9.93ns 0.0368 0 0 2.64 KB
#5131 SendAsync net472 7.68μs 4.57ns 17.7ns 0.525 0 0 3.31 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #5131

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 59.26 KB 61.95 KB 2.7 KB 4.55%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 202.27 KB 211.13 KB 8.86 KB 4.38%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 62μs 844ns 8.23μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 60.4μs 700ns 6.82μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 38.1μs 100ns 361ns 0 0 0 59.26 KB
master StringConcatAspectBenchmark net6.0 274μs 1.45μs 7.12μs 0 0 0 204.7 KB
master StringConcatAspectBenchmark netcoreapp3.1 269μs 4.24μs 40.9μs 0 0 0 202.27 KB
master StringConcatAspectBenchmark net472 228μs 1.97μs 18.8μs 0 0 0 221.18 KB
#5131 StringConcatBenchmark net6.0 59.9μs 815ns 8.15μs 0 0 0 43.44 KB
#5131 StringConcatBenchmark netcoreapp3.1 53.5μs 257ns 993ns 0 0 0 42.64 KB
#5131 StringConcatBenchmark net472 37.7μs 117ns 421ns 0 0 0 61.95 KB
#5131 StringConcatAspectBenchmark net6.0 270μs 1.3μs 5.19μs 0 0 0 204.33 KB
#5131 StringConcatAspectBenchmark netcoreapp3.1 286μs 1.62μs 11.5μs 0 0 0 211.13 KB
#5131 StringConcatAspectBenchmark net472 226μs 1.08μs 4.71μs 0 0 0 221.18 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.46μs 0.427ns 1.54ns 0.022 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 2.25μs 1.44ns 5.58ns 0.0216 0 0 1.58 KB
master EnrichedLog net472 2.51μs 2.19ns 8.18ns 0.239 0 0 1.51 KB
#5131 EnrichedLog net6.0 1.52μs 0.456ns 1.71ns 0.0224 0 0 1.58 KB
#5131 EnrichedLog netcoreapp3.1 2.23μs 0.945ns 3.53ns 0.0212 0 0 1.58 KB
#5131 EnrichedLog net472 2.65μs 1.91ns 7.16ns 0.239 0 0 1.51 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 114μs 63.9ns 239ns 0.0566 0 0 4.22 KB
master EnrichedLog netcoreapp3.1 117μs 117ns 440ns 0 0 0 4.22 KB
master EnrichedLog net472 148μs 75.3ns 292ns 0.665 0.222 0 4.4 KB
#5131 EnrichedLog net6.0 113μs 103ns 370ns 0.0573 0 0 4.22 KB
#5131 EnrichedLog netcoreapp3.1 118μs 159ns 617ns 0 0 0 4.22 KB
#5131 EnrichedLog net472 148μs 184ns 712ns 0.66 0.22 0 4.4 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.14μs 8.9ns 34.5ns 0.0294 0 0 2.14 KB
master EnrichedLog netcoreapp3.1 4.27μs 1.11ns 4.31ns 0.0299 0 0 2.14 KB
master EnrichedLog net472 4.89μs 2.48ns 9.6ns 0.309 0 0 1.95 KB
#5131 EnrichedLog net6.0 3.12μs 1.32ns 5.1ns 0.0305 0 0 2.14 KB
#5131 EnrichedLog netcoreapp3.1 4.2μs 1.56ns 6.03ns 0.0293 0 0 2.14 KB
#5131 EnrichedLog net472 4.69μs 2.21ns 8.55ns 0.309 0 0 1.95 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.35μs 1.83ns 7.09ns 0.0156 0 0 1.11 KB
master SendReceive netcoreapp3.1 1.74μs 2.31ns 8.94ns 0.0148 0 0 1.11 KB
master SendReceive net472 2.24μs 2.21ns 8.56ns 0.178 0 0 1.12 KB
#5131 SendReceive net6.0 1.42μs 0.822ns 3.18ns 0.0157 0 0 1.11 KB
#5131 SendReceive netcoreapp3.1 1.82μs 1.12ns 4.36ns 0.0146 0 0 1.11 KB
#5131 SendReceive net472 2.02μs 1.98ns 7.42ns 0.178 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.77μs 0.689ns 2.58ns 0.0221 0 0 1.54 KB
master EnrichedLog netcoreapp3.1 3.94μs 2.5ns 9.7ns 0.0216 0 0 1.58 KB
master EnrichedLog net472 4.42μs 2.51ns 9.72ns 0.313 0 0 1.97 KB
#5131 EnrichedLog net6.0 2.9μs 1.31ns 5.09ns 0.0203 0 0 1.54 KB
#5131 EnrichedLog netcoreapp3.1 4.01μs 2.98ns 11.5ns 0.02 0 0 1.58 KB
#5131 EnrichedLog net472 4.31μs 1.32ns 4.93ns 0.313 0 0 1.97 KB
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5131

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.129 606.11 684.05

Faster :tada: in #5131

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.173 524.49 447.13

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 525ns 0.209ns 0.81ns 0.00758 0 0 544 B
master StartFinishSpan netcoreapp3.1 719ns 0.25ns 0.9ns 0.0075 0 0 544 B
master StartFinishSpan net472 718ns 0.359ns 1.39ns 0.0866 0 0 546 B
master StartFinishScope net6.0 606ns 0.207ns 0.774ns 0.00939 0 0 664 B
master StartFinishScope netcoreapp3.1 911ns 0.292ns 1.09ns 0.00886 0 0 664 B
master StartFinishScope net472 924ns 0.385ns 1.49ns 0.0992 0 0 626 B
#5131 StartFinishSpan net6.0 447ns 0.122ns 0.455ns 0.00763 0 0 544 B
#5131 StartFinishSpan netcoreapp3.1 696ns 0.623ns 2.41ns 0.00738 0 0 544 B
#5131 StartFinishSpan net472 747ns 0.707ns 2.74ns 0.0866 0 0 546 B
#5131 StartFinishScope net6.0 684ns 0.29ns 1.12ns 0.00928 0 0 664 B
#5131 StartFinishScope netcoreapp3.1 909ns 0.238ns 0.92ns 0.00905 0 0 664 B
#5131 StartFinishScope net472 967ns 0.713ns 2.76ns 0.0993 0 0 626 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5131

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.271 609.09 774.01
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 1.145 841.21 963.00

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 609ns 0.263ns 1.02ns 0.00913 0 0 664 B
master RunOnMethodBegin netcoreapp3.1 841ns 0.654ns 2.45ns 0.00901 0 0 664 B
master RunOnMethodBegin net472 1.07μs 0.406ns 1.57ns 0.099 0 0 626 B
#5131 RunOnMethodBegin net6.0 774ns 0.269ns 1.01ns 0.00928 0 0 664 B
#5131 RunOnMethodBegin netcoreapp3.1 963ns 0.511ns 1.98ns 0.00885 0 0 664 B
#5131 RunOnMethodBegin net472 1.1μs 0.292ns 1.01ns 0.0994 0 0 626 B

andrewlock avatar Feb 01 '24 09:02 andrewlock

Datadog Report

Branch report: dudik/incorrect-locals-number-async-method Commit report: 9146b99 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 335903 Passed, 2084 Skipped, 51m 54.6s Wall Time

datadog-ddstaging[bot] avatar Mar 22 '24 15:03 datadog-ddstaging[bot]

Benchmarks Report for tracer :snail:

Benchmarks for #5131 compared to master:

  • All benchmarks have the same speed
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.8μs 48.4ns 290ns 0.0219 0.00877 0 7.51 KB
master StartStopWithChild netcoreapp3.1 10.7μs 52.4ns 216ns 0.0261 0.0104 0 7.6 KB
master StartStopWithChild net472 16.8μs 43ns 155ns 1.34 0.332 0.108 8.06 KB
#5131 StartStopWithChild net6.0 8.98μs 51.5ns 392ns 0.0218 0.00871 0 7.51 KB
#5131 StartStopWithChild netcoreapp3.1 11.3μs 63.4ns 406ns 0.0398 0.017 0 7.6 KB
#5131 StartStopWithChild net472 17.6μs 78ns 331ns 1.34 0.351 0.12 8.05 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 470μs 170ns 657ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 606μs 142ns 513ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 807μs 221ns 828ns 0.403 0 0 3.3 KB
#5131 WriteAndFlushEnrichedTraces net6.0 468μs 220ns 795ns 0 0 0 2.7 KB
#5131 WriteAndFlushEnrichedTraces netcoreapp3.1 624μs 299ns 1.12μs 0 0 0 2.7 KB
#5131 WriteAndFlushEnrichedTraces net472 815μs 112ns 420ns 0.408 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 173μs 161ns 623ns 0.174 0 0 18.33 KB
master SendRequest netcoreapp3.1 194μs 326ns 1.26μs 0.195 0 0 20.49 KB
master SendRequest net472 0.000278ns 0.000141ns 0.000528ns 0 0 0 0 b
#5131 SendRequest net6.0 173μs 204ns 792ns 0.258 0 0 18.33 KB
#5131 SendRequest netcoreapp3.1 192μs 327ns 1.27μs 0.191 0 0 20.49 KB
#5131 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 551μs 670ns 2.59μs 0.548 0 0 41.74 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 659μs 675ns 2.53μs 0.324 0 0 41.69 KB
master WriteAndFlushEnrichedTraces net472 859μs 3.66μs 14.2μs 8.08 2.55 0.425 53.24 KB
#5131 WriteAndFlushEnrichedTraces net6.0 540μs 1.35μs 5.23μs 0.539 0 0 41.78 KB
#5131 WriteAndFlushEnrichedTraces netcoreapp3.1 655μs 839ns 3.25μs 0.326 0 0 41.72 KB
#5131 WriteAndFlushEnrichedTraces net472 854μs 3.34μs 13.4μs 8.45 2.53 0.422 53.24 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.17μs 0.406ns 1.57ns 0.0105 0 0 784 B
master ExecuteNonQuery netcoreapp3.1 1.46μs 6.09ns 23.6ns 0.0102 0 0 784 B
master ExecuteNonQuery net472 1.85μs 0.726ns 2.72ns 0.118 0 0 746 B
#5131 ExecuteNonQuery net6.0 1.13μs 0.316ns 1.18ns 0.0108 0 0 784 B
#5131 ExecuteNonQuery netcoreapp3.1 1.51μs 1.91ns 7.39ns 0.0103 0 0 784 B
#5131 ExecuteNonQuery net472 1.9μs 0.579ns 2.09ns 0.118 0 0 746 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.29μs 0.61ns 2.28ns 0.0143 0 0 1.01 KB
master CallElasticsearch netcoreapp3.1 1.56μs 0.769ns 2.98ns 0.0133 0 0 1.01 KB
master CallElasticsearch net472 2.51μs 1.49ns 5.59ns 0.161 0 0 1.02 KB
master CallElasticsearchAsync net6.0 1.42μs 1.21ns 4.51ns 0.0135 0 0 984 B
master CallElasticsearchAsync netcoreapp3.1 1.72μs 2.27ns 8.8ns 0.0137 0 0 1.06 KB
master CallElasticsearchAsync net472 2.58μs 1.53ns 5.91ns 0.17 0.00129 0 1.08 KB
#5131 CallElasticsearch net6.0 1.41μs 0.907ns 3.51ns 0.014 0 0 1.01 KB
#5131 CallElasticsearch netcoreapp3.1 1.64μs 0.942ns 3.52ns 0.0139 0 0 1.01 KB
#5131 CallElasticsearch net472 2.46μs 1.61ns 6.22ns 0.161 0 0 1.02 KB
#5131 CallElasticsearchAsync net6.0 1.39μs 1.34ns 5.18ns 0.014 0 0 984 B
#5131 CallElasticsearchAsync netcoreapp3.1 1.72μs 0.905ns 3.5ns 0.0136 0 0 1.06 KB
#5131 CallElasticsearchAsync net472 2.6μs 1.37ns 5.3ns 0.171 0 0 1.08 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.28μs 0.936ns 3.5ns 0.0131 0 0 928 B
master ExecuteAsync netcoreapp3.1 1.7μs 1.21ns 4.52ns 0.0126 0 0 928 B
master ExecuteAsync net472 1.94μs 2.51ns 9.74ns 0.141 0 0 891 B
#5131 ExecuteAsync net6.0 1.3μs 0.81ns 2.81ns 0.0131 0 0 928 B
#5131 ExecuteAsync netcoreapp3.1 1.66μs 1.22ns 4.72ns 0.0126 0 0 928 B
#5131 ExecuteAsync net472 2.01μs 1.67ns 6.45ns 0.141 0 0 891 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.28μs 2.92ns 11.3ns 0.0298 0 0 2.16 KB
master SendAsync netcoreapp3.1 5.05μs 1.84ns 7.12ns 0.0355 0 0 2.7 KB
master SendAsync net472 7.62μs 6.03ns 22.6ns 0.484 0 0 3.05 KB
#5131 SendAsync net6.0 4.24μs 2.89ns 11.2ns 0.0295 0 0 2.16 KB
#5131 SendAsync netcoreapp3.1 5.05μs 1.87ns 6.49ns 0.0355 0 0 2.7 KB
#5131 SendAsync net472 7.74μs 7.31ns 28.3ns 0.482 0 0 3.05 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.52μs 0.889ns 3.2ns 0.0232 0 0 1.65 KB
master EnrichedLog netcoreapp3.1 2.27μs 3.02ns 11.7ns 0.0228 0 0 1.65 KB
master EnrichedLog net472 2.69μs 1.31ns 4.89ns 0.25 0 0 1.57 KB
#5131 EnrichedLog net6.0 1.62μs 0.986ns 3.69ns 0.0227 0 0 1.65 KB
#5131 EnrichedLog netcoreapp3.1 2.31μs 2ns 7.76ns 0.022 0 0 1.65 KB
#5131 EnrichedLog net472 2.75μs 7.07ns 26.5ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 125ns 449ns 0.0568 0 0 4.23 KB
master EnrichedLog netcoreapp3.1 123μs 368ns 1.42μs 0 0 0 4.23 KB
master EnrichedLog net472 148μs 188ns 727ns 0.664 0.221 0 4.41 KB
#5131 EnrichedLog net6.0 114μs 190ns 736ns 0.0576 0 0 4.23 KB
#5131 EnrichedLog netcoreapp3.1 118μs 253ns 980ns 0 0 0 4.23 KB
#5131 EnrichedLog net472 148μs 245ns 950ns 0.662 0.221 0 4.41 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.13μs 1.19ns 4.11ns 0.0311 0 0 2.21 KB
master EnrichedLog netcoreapp3.1 4.22μs 0.966ns 3.35ns 0.0294 0 0 2.21 KB
master EnrichedLog net472 5.19μs 5.71ns 22.1ns 0.321 0 0 2.02 KB
#5131 EnrichedLog net6.0 3.13μs 1.79ns 6.44ns 0.0312 0 0 2.21 KB
#5131 EnrichedLog netcoreapp3.1 4.19μs 1.61ns 6.03ns 0.0294 0 0 2.21 KB
#5131 EnrichedLog net472 5.05μs 4.52ns 17.5ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.43μs 0.878ns 3.4ns 0.0164 0 0 1.18 KB
master SendReceive netcoreapp3.1 1.8μs 8.43ns 33.7ns 0.0162 0 0 1.18 KB
master SendReceive net472 2.42μs 4.09ns 15.9ns 0.187 0 0 1.18 KB
#5131 SendReceive net6.0 1.54μs 0.775ns 2.79ns 0.0162 0 0 1.18 KB
#5131 SendReceive netcoreapp3.1 1.79μs 1.96ns 7.33ns 0.0159 0 0 1.18 KB
#5131 SendReceive net472 2.24μs 2.3ns 8.3ns 0.187 0 0 1.18 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.79μs 0.877ns 3.28ns 0.0209 0 0 1.55 KB
master EnrichedLog netcoreapp3.1 3.88μs 1.42ns 5.3ns 0.0212 0 0 1.6 KB
master EnrichedLog net472 4.71μs 2.69ns 10.4ns 0.314 0 0 1.99 KB
#5131 EnrichedLog net6.0 2.64μs 0.948ns 3.55ns 0.0212 0 0 1.55 KB
#5131 EnrichedLog netcoreapp3.1 3.96μs 2.49ns 8.96ns 0.0198 0 0 1.6 KB
#5131 EnrichedLog net472 4.54μs 6.73ns 26.1ns 0.316 0 0 1.99 KB
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 479ns 0.328ns 1.27ns 0.00771 0 0 552 B
master StartFinishSpan netcoreapp3.1 759ns 1.09ns 4.07ns 0.00722 0 0 552 B
master StartFinishSpan net472 718ns 0.675ns 2.61ns 0.0879 0 0 554 B
master StartFinishScope net6.0 594ns 0.291ns 1.13ns 0.00954 0 0 672 B
master StartFinishScope netcoreapp3.1 897ns 0.649ns 2.43ns 0.00872 0 0 672 B
master StartFinishScope net472 971ns 0.64ns 2.31ns 0.1 0 0 634 B
#5131 StartFinishSpan net6.0 513ns 1.25ns 4.84ns 0.00764 0 0 552 B
#5131 StartFinishSpan netcoreapp3.1 714ns 0.531ns 2.06ns 0.00718 0 0 552 B
#5131 StartFinishSpan net472 788ns 0.237ns 0.917ns 0.088 0 0 554 B
#5131 StartFinishScope net6.0 622ns 0.34ns 1.32ns 0.00933 0 0 672 B
#5131 StartFinishScope netcoreapp3.1 887ns 0.442ns 1.71ns 0.00922 0 0 672 B
#5131 StartFinishScope net472 989ns 3.6ns 13.9ns 0.101 0 0 634 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 658ns 0.817ns 3.17ns 0.00945 0 0 672 B
master RunOnMethodBegin netcoreapp3.1 950ns 0.6ns 2.32ns 0.00894 0 0 672 B
master RunOnMethodBegin net472 1.07μs 1.07ns 4.16ns 0.101 0 0 634 B
#5131 RunOnMethodBegin net6.0 726ns 1.5ns 5.63ns 0.00943 0 0 672 B
#5131 RunOnMethodBegin netcoreapp3.1 904ns 1.15ns 4.15ns 0.00891 0 0 672 B
#5131 RunOnMethodBegin net472 1.15μs 0.583ns 2.26ns 0.101 0 0 634 B

andrewlock avatar Mar 22 '24 17:03 andrewlock