dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

[Profiler] Beginning of Universal binary: no link to dependencies

Open gleocadie opened this issue 2 years ago • 2 comments

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

gleocadie avatar Nov 14 '23 11:11 gleocadie

Datadog Report

Branch report: gleocadie/try-universal-binary Commit report: 244e210

:x: dd-trace-dotnet: 6 Failed (0 Known Flaky), 0 New Flaky, 303169 Passed, 1207 Skipped, 44m 5.16s Wall Time

:x: Failed Tests (6)

This report shows up to 5 failed tests.

  • CheckCpuLimit - Datadog.Profiler.IntegrationTests.SmokeTests.CpuLimitTest - Details

    Expand for error
    xit code of "catchsegv" should be 0 instead of 127 (= 0x7F)
    xpected: True
    ctual:   False
    
  • CheckCpuLimit - Datadog.Profiler.IntegrationTests.SmokeTests.CpuLimitTest - Details

    Expand for error
    xit code of "catchsegv" should be 0 instead of 127 (= 0x7F)
    xpected: True
    ctual:   False
    
  • CheckCpuLimit - Datadog.Profiler.IntegrationTests.SmokeTests.CpuLimitTest - Details

    Expand for error
    xit code of "catchsegv" should be 0 instead of 127 (= 0x7F)
    xpected: True
    ctual:   False
    
  • CheckCpuLimit - Datadog.Profiler.IntegrationTests.SmokeTests.CpuLimitTest - Details

    Expand for error
    xit code of "catchsegv" should be 0 instead of 127 (= 0x7F)
    xpected: True
    ctual:   False
    
  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.StackExchangeRedisTests - Details

    Expand for error
    xpected exit code: 0, actual exit code: 134.
    

datadog-ddstaging[bot] avatar Nov 14 '23 12:11 datadog-ddstaging[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4861) - mean (72ms)  : 62, 82
     .   : milestone, 72,
    master - mean (71ms)  : 63, 79
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (4861) - mean (1,003ms)  : 982, 1025
     .   : milestone, 1003,
    master - mean (999ms)  : 979, 1018
     .   : milestone, 999,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4861) - mean (105ms)  : 102, 108
     .   : milestone, 105,
    master - mean (105ms)  : 102, 109
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (4861) - mean (693ms)  : 664, 721
     .   : milestone, 693,
    master - mean (688ms)  : 661, 716
     .   : milestone, 688,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4861) - mean (91ms)  : 88, 94
     .   : milestone, 91,
    master - mean (90ms)  : 86, 94
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (4861) - mean (664ms)  : 641, 687
     .   : milestone, 664,
    master - mean (661ms)  : 634, 688
     .   : milestone, 661,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4861) - mean (187ms)  : 184, 189
     .   : milestone, 187,
    master - mean (188ms)  : 184, 191
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (4861) - mean (1,094ms)  : 1067, 1122
     .   : milestone, 1094,
    master - mean (1,099ms)  : 1078, 1119
     .   : milestone, 1099,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4861) - mean (272ms)  : 268, 275
     .   : milestone, 272,
    master - mean (271ms)  : 267, 275
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (4861) - mean (1,058ms)  : 1030, 1087
     .   : milestone, 1058,
    master - mean (1,054ms)  : 1030, 1077
     .   : milestone, 1054,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4861) - mean (262ms)  : 258, 266
     .   : milestone, 262,
    master - mean (262ms)  : 258, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (4861) - mean (1,027ms)  : 1001, 1052
     .   : milestone, 1027,
    master - mean (1,028ms)  : 1002, 1055
     .   : milestone, 1028,

andrewlock avatar Nov 14 '23 12:11 andrewlock