Summary of changes
Deletes the SyncMsiContent helper and corresponding UpdateMsiContents task
Reason for change
As far as I can tell, SyncMsiContent hasn't been right since we introduced the profiler, so I'm not sure it adds a lot of value. It would also need updating to support the changes introduced in #3060
We could fix it, but I don't know that it's worth it at this stage. The MSI should only change now when we add new products, so doesn't seem worth including to me.
Implementation details
Delete key.
Test coverage
Nope
Other details
If we do decide we want this, we have to fix it before the next release, otherwise it will revert some of the changes in #3060. So I'm inclined to merge this first either way, and then we can revert and update when someone has time if we want to update it
Benchmarks Report :snail:
Benchmarks for #3074 compared to master:
- 2 benchmarks are faster, with geometric mean 1.236
- All benchmarks have the same allocations
The following thresholds were used for comparing the benchmark speeds:
- Mann–Whitney U test with statistical test for significance of 5%
- Only results indicating a difference greater than 10% and 0.3 ns are considered.
Allocation changes below 0.5% are ignored.
Benchmark details
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch |
Method |
Toolchain |
Mean |
StdError |
StdDev |
Gen 0 |
Gen 1 |
Gen 2 |
Allocated |
| master |
WriteAndFlushEnrichedTraces |
net472 |
792μs |
4.32μs |
24.4μs |
0.391 |
0 |
0 |
3.18 KB |
| master |
WriteAndFlushEnrichedTraces |
netcoreapp3.1 |
529μs |
3.02μs |
22.6μs |
0 |
0 |
0 |
2.58 KB |
| #3074 |
WriteAndFlushEnrichedTraces |
net472 |
724μs |
507ns |
1.96μs |
0.365 |
0 |
0 |
3.18 KB |
| #3074 |
WriteAndFlushEnrichedTraces |
netcoreapp3.1 |
475μs |
279ns |
1.08μs |
0 |
0 |
0 |
2.58 KB |
Benchmarks.Trace.AppSecBodyBenchmark - Faster :tada: Same allocations :heavy_check_mark:
Faster :tada: in #3074
| Benchmark |
base/diff |
Base Median (ns) |
Diff Median (ns) |
Modality |
| Benchmarks.Trace.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 |
1.132 |
204.95 |
181.04 |
|
Raw results
| Branch |
Method |
Toolchain |
Mean |
StdError |
StdDev |
Gen 0 |
Gen 1 |
Gen 2 |
Allocated |
| master |
AllCycleSimpleBody |
net472 |
205ns |
0.137ns |
0.493ns |
0.0676 |
0 |
0 |
425 B |
| master |
AllCycleSimpleBody |
netcoreapp3.1 |
234ns |
0.27ns |
1.05ns |
0.00594 |
0 |
0 |
424 B |
| master |
AllCycleMoreComplexBody |
net472 |
182ns |
0.151ns |
0.566ns |
0.0638 |
0 |
0 |
401 B |
| master |
AllCycleMoreComplexBody |
netcoreapp3.1 |
236ns |
0.314ns |
1.22ns |
0.00542 |
0 |
0 |
400 B |
| master |
BodyExtractorSimpleBody |
net472 |
259ns |
0.152ns |
0.549ns |
0.0574 |
0 |
0 |
361 B |
| master |
BodyExtractorSimpleBody |
netcoreapp3.1 |
216ns |
0.355ns |
1.37ns |
0.0038 |
0 |
0 |
272 B |
| master |
BodyExtractorMoreComplexBody |
net472 |
14.2μs |
9.8ns |
37.9ns |
1.21 |
0.0215 |
0 |
7.62 KB |
| master |
BodyExtractorMoreComplexBody |
netcoreapp3.1 |
12.5μs |
20.2ns |
72.8ns |
0.0933 |
0 |
0 |
6.75 KB |
| #3074 |
AllCycleSimpleBody |
net472 |
181ns |
0.122ns |
0.455ns |
0.0676 |
0 |
0 |
425 B |
| #3074 |
AllCycleSimpleBody |
netcoreapp3.1 |
234ns |
0.279ns |
1.08ns |
0.0058 |
0 |
0 |
424 B |
| #3074 |
AllCycleMoreComplexBody |
net472 |
182ns |
0.172ns |
0.621ns |
0.0637 |
0 |
0 |
401 B |
| #3074 |
AllCycleMoreComplexBody |
netcoreapp3.1 |
239ns |
0.246ns |
0.952ns |
0.00533 |
0 |
0 |
400 B |
| #3074 |
BodyExtractorSimpleBody |
net472 |
264ns |
0.225ns |
0.842ns |
0.0574 |
0 |
0 |
361 B |
| #3074 |
BodyExtractorSimpleBody |
netcoreapp3.1 |
220ns |
0.225ns |
0.842ns |
0.00375 |
0 |
0 |
272 B |
| #3074 |
BodyExtractorMoreComplexBody |
net472 |
14.5μs |
9.93ns |
37.1ns |
1.21 |
0.0218 |
0 |
7.62 KB |
| #3074 |
BodyExtractorMoreComplexBody |
netcoreapp3.1 |
12.1μs |
8.03ns |
28.9ns |
0.0905 |
0 |
0 |
6.75 KB |
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch |
Method |
Toolchain |
Mean |
StdError |
StdDev |
Gen 0 |
Gen 1 |
Gen 2 |
Allocated |
| master |
SendRequest |
net472 |
0.0624ns |
0.0151ns |
0.0918ns |
0 |
0 |
0 |
0 b |
| master |
SendRequest |
netcoreapp3.1 |
189μs |
77.1ns |
267ns |
0.188 |
0 |
0 |
20.33 KB |
| #3074 |
SendRequest |
net472 |
0ns |
0ns |
0ns |
0 |
0 |
0 |
0 b |
| #3074 |
SendRequest |
netcoreapp3.1 |
177μs |
148ns |
575ns |
0.177 |
0 |
0 |
20.33 KB |
Benchmarks.Trace.DbCommandBenchmark - Faster :tada: Same allocations :heavy_check_mark:
Faster :tada: in #3074
| Benchmark |
base/diff |
Base Median (ns) |
Diff Median (ns) |
Modality |
| Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 |
1.349 |
1,762.88 |
1,306.41 |
bimodal |
Raw results
| Branch |
Method |
Toolchain |
Mean |
StdError |
StdDev |
Gen 0 |
Gen 1 |
Gen 2 |
Allocated |
| master |
ExecuteNonQuery |
net472 |
1.69μs |
9.36ns |
54.6ns |
0.126 |
0.000827 |
0 |
794 B |
| master |
ExecuteNonQuery |
netcoreapp3.1 |
1.77μs |
15.2ns |
152ns |
0.0112 |
0 |
0 |
824 B |
| #3074 |
ExecuteNonQuery |
net472 |
1.49μs |
0.698ns |
2.61ns |
0.126 |
0.000746 |
0 |
794 B |
| #3074 |
ExecuteNonQuery |
netcoreapp3.1 |
1.31μs |
0.356ns |
1.38ns |
0.0111 |
0 |
0 |
824 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch |
Method |
Toolchain |
Mean |
StdError |
StdDev |
Gen 0 |
Gen 1 |
Gen 2 |
Allocated |
| master |
CallElasticsearch |
net472 |
2.17μs |
0.518ns |
1.87ns |
0.159 |
0 |
0 |
1 KB |
| master |
CallElasticsearch |
netcoreapp3.1 |
1.4μs |
0.68ns |
2.64ns |
0.0131 |
0 |
0 |
984 B |
| master |
CallElasticsearchAsync |
net472 |
2.28μs |
4.84ns |
18.8ns |
0.181 |
0 |
0 |
1.14 KB |
| master |
CallElasticsearchAsync |
netcoreapp3.1 |
1.43μs |
0.529ns |
1.98ns |
0.015 |
0 |
0 |
1.1 KB |
| #3074 |
CallElasticsearch |
net472 |
2.23μs |
0.531ns |
2.06ns |
0.159 |
0 |
0 |
1 KB |
| #3074 |
CallElasticsearch |
netcoreapp3.1 |
1.4μs |
0.469ns |
1.76ns |
0.0132 |
0 |
0 |
984 B |
| #3074 |
CallElasticsearchAsync |
net472 |
2.34μs |
0.801ns |
3.1ns |
0.181 |
0 |
0 |
1.14 KB |
| #3074 |
CallElasticsearchAsync |
netcoreapp3.1 |
1.43μs |
0.299ns |
1.12ns |
0.015 |
0 |
0 |
1.1 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch |
Method |
Toolchain |
Mean |
StdError |
StdDev |
Gen 0 |
Gen 1 |
Gen 2 |
Allocated |
| master |
ExecuteAsync |
net472 |
2.48μs |
3.1ns |
12ns |
0.2 |
0 |
0 |
1.26 KB |
| master |
ExecuteAsync |
netcoreapp3.1 |
1.56μs |
1.66ns |
6.2ns |
0.0163 |
0 |
0 |
1.22 KB |
| #3074 |
ExecuteAsync |
net472 |
2.49μs |
1.93ns |
7.49ns |
0.199 |
0 |
0 |
1.26 KB |
| #3074 |
ExecuteAsync |
netcoreapp3.1 |
1.55μs |
0.49ns |
1.9ns |
0.0163 |
0 |
0 |
1.22 KB |
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch |
Method |
Toolchain |
Mean |
StdError |
StdDev |
Gen 0 |
Gen 1 |
Gen 2 |
Allocated |
| master |
SendAsync |
net472 |
5.06μs |
6.98ns |
26.1ns |
0.392 |
0 |
0 |
2.48 KB |
| master |
SendAsync |
netcoreapp3.1 |
3.3μs |
4.05ns |
15.7ns |
0.031 |
0 |
0 |
2.36 KB |
| #3074 |
SendAsync |
net472 |
5.04μs |
9.87ns |
38.2ns |
0.392 |
0 |
0 |
2.48 KB |
| #3074 |
SendAsync |
netcoreapp3.1 |
3.31μs |
4.09ns |
15.8ns |
0.0313 |
0 |
0 |
2.36 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch |
Method |
Toolchain |
Mean |
StdError |
StdDev |
Gen 0 |
Gen 1 |
Gen 2 |
Allocated |
| master |
EnrichedLog |
net472 |
2.83μs |
0.751ns |
2.81ns |
0.263 |
0 |
0 |
1.66 KB |
| master |
EnrichedLog |
netcoreapp3.1 |
2.29μs |
0.476ns |
1.72ns |
0.0231 |
0 |
0 |
1.73 KB |
| #3074 |
EnrichedLog |
net472 |
2.83μs |
0.571ns |
2.06ns |
0.263 |
0 |
0 |
1.66 KB |
| #3074 |
EnrichedLog |
netcoreapp3.1 |
2.5μs |
4.33ns |
16.2ns |
0.0237 |
0 |
0 |
1.73 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch |
Method |
Toolchain |
Mean |
StdError |
StdDev |
Gen 0 |
Gen 1 |
Gen 2 |
Allocated |
| master |
EnrichedLog |
net472 |
149μs |
77.9ns |
302ns |
0.675 |
0.225 |
0 |
4.5 KB |
| master |
EnrichedLog |
netcoreapp3.1 |
113μs |
107ns |
399ns |
0.0566 |
0 |
0 |
4.38 KB |
| #3074 |
EnrichedLog |
net472 |
147μs |
220ns |
850ns |
0.663 |
0.221 |
0 |
4.5 KB |
| #3074 |
EnrichedLog |
netcoreapp3.1 |
115μs |
223ns |
863ns |
0.0563 |
0 |
0 |
4.38 KB |
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch |
Method |
Toolchain |
Mean |
StdError |
StdDev |
Gen 0 |
Gen 1 |
Gen 2 |
Allocated |
| master |
EnrichedLog |
net472 |
5.62μs |
8.3ns |
32.1ns |
0.545 |
0.00281 |
0 |
3.43 KB |
| master |
EnrichedLog |
netcoreapp3.1 |
4.31μs |
5.04ns |
19.5ns |
0.0514 |
0 |
0 |
3.8 KB |
| #3074 |
EnrichedLog |
net472 |
5.48μs |
3.54ns |
13.2ns |
0.546 |
0.00301 |
0 |
3.43 KB |
| #3074 |
EnrichedLog |
netcoreapp3.1 |
4.34μs |
6.83ns |
24.6ns |
0.0514 |
0 |
0 |
3.8 KB |
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch |
Method |
Toolchain |
Mean |
StdError |
StdDev |
Gen 0 |
Gen 1 |
Gen 2 |
Allocated |
| master |
SendReceive |
net472 |
1.99μs |
1.03ns |
4ns |
0.193 |
0 |
0 |
1.22 KB |
| master |
SendReceive |
netcoreapp3.1 |
1.73μs |
0.707ns |
2.65ns |
0.0165 |
0 |
0 |
1.21 KB |
| #3074 |
SendReceive |
net472 |
1.95μs |
0.955ns |
3.7ns |
0.194 |
0 |
0 |
1.22 KB |
| #3074 |
SendReceive |
netcoreapp3.1 |
1.59μs |
0.955ns |
3.7ns |
0.0166 |
0 |
0 |
1.21 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch |
Method |
Toolchain |
Mean |
StdError |
StdDev |
Gen 0 |
Gen 1 |
Gen 2 |
Allocated |
| master |
EnrichedLog |
net472 |
4.66μs |
1.38ns |
5.33ns |
0.329 |
0 |
0 |
2.08 KB |
| master |
EnrichedLog |
netcoreapp3.1 |
4.09μs |
2ns |
7.73ns |
0.0226 |
0 |
0 |
1.69 KB |
| #3074 |
EnrichedLog |
net472 |
4.75μs |
1.84ns |
6.88ns |
0.33 |
0 |
0 |
2.08 KB |
| #3074 |
EnrichedLog |
netcoreapp3.1 |
4.1μs |
1.12ns |
4.19ns |
0.0225 |
0 |
0 |
1.69 KB |
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch |
Method |
Toolchain |
Mean |
StdError |
StdDev |
Gen 0 |
Gen 1 |
Gen 2 |
Allocated |
| master |
StartFinishSpan |
net472 |
832ns |
0.252ns |
0.944ns |
0.104 |
0 |
0 |
658 B |
| master |
StartFinishSpan |
netcoreapp3.1 |
776ns |
1.78ns |
6.88ns |
0.00885 |
0 |
0 |
648 B |
| master |
StartFinishScope |
net472 |
1.01μs |
0.27ns |
1.05ns |
0.117 |
0 |
0 |
738 B |
| master |
StartFinishScope |
netcoreapp3.1 |
930ns |
0.337ns |
1.26ns |
0.0102 |
0 |
0 |
768 B |
| #3074 |
StartFinishSpan |
net472 |
860ns |
0.403ns |
1.56ns |
0.104 |
0 |
0 |
658 B |
| #3074 |
StartFinishSpan |
netcoreapp3.1 |
777ns |
1.23ns |
4.77ns |
0.00896 |
0 |
0 |
648 B |
| #3074 |
StartFinishScope |
net472 |
1.06μs |
0.276ns |
1.07ns |
0.117 |
0 |
0 |
738 B |
| #3074 |
StartFinishScope |
netcoreapp3.1 |
839ns |
1.08ns |
4.16ns |
0.0104 |
0 |
0 |
768 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch |
Method |
Toolchain |
Mean |
StdError |
StdDev |
Gen 0 |
Gen 1 |
Gen 2 |
Allocated |
| master |
RunOnMethodBegin |
net472 |
1.22μs |
0.858ns |
3.32ns |
0.117 |
0 |
0 |
738 B |
| master |
RunOnMethodBegin |
netcoreapp3.1 |
1.01μs |
0.329ns |
1.19ns |
0.0102 |
0 |
0 |
768 B |
| #3074 |
RunOnMethodBegin |
net472 |
1.24μs |
0.274ns |
1.02ns |
0.117 |
0 |
0 |
738 B |
| #3074 |
RunOnMethodBegin |
netcoreapp3.1 |
1μs |
0.291ns |
1.05ns |
0.0103 |
0 |
0 |
768 B |
Code Coverage Report :bar_chart:
:heavy_check_mark: Merging #3074 into master will not change line coverage
:heavy_check_mark: Merging #3074 into master will not change branch coverage
:heavy_check_mark: Merging #3074 into master will not change complexity
|
master |
#3074 |
Change |
| Lines |
16774 / 23114 |
16798 / 23114 |
|
| Lines % |
73% |
73% |
0% :heavy_check_mark: |
| Branches |
10031 / 14310 |
10045 / 14310 |
|
| Branches % |
70% |
70% |
0% :heavy_check_mark: |
| Complexity |
15381 |
15381 |
0 :heavy_check_mark: |
View the full report for further details:
Datadog.Trace Breakdown :heavy_check_mark:
|
master |
#3074 |
Change |
| Lines % |
73% |
73% |
0% :heavy_check_mark: |
| Branches % |
70% |
70% |
0% :heavy_check_mark: |
| Complexity |
15381 |
15381 |
0 :heavy_check_mark: |
The following classes have significant coverage changes.
| File |
Line coverage change |
Branch coverage change |
Complexity change |
| Datadog.Trace.Ci.CIVisibility |
5% :heavy_check_mark: |
6% :heavy_check_mark: |
0 :heavy_check_mark: |
View the full reports for further details:
DataDog
