dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

Add NCrunch to gitignore and get it to work with the test runners

Open zippy1981 opened this issue 2 years ago • 1 comments

Files that get created if you have nCrunch installed in Visual Studio

Summary of changes

Added gitignore entries and tetrunner names

Reason for change

I don't want to accidently commit my NCrunch config, and I want the unit tests that care about the testrunner name to pass.

Implementation details

copied from http://gitignore.io, and fixed unit tests

Test coverage

Technically not covered by CI/CD, but if you guys bought a license there is a CLI version of ncrunch that you might be able to get working in CI/CD

Other details

zippy1981 avatar Jun 30 '22 22:06 zippy1981

@pierotibou are those linux failure something I should investigate?

zippy1981 avatar Jul 05 '22 17:07 zippy1981

Can I get an update on this?

zippy1981 avatar Sep 23 '22 21:09 zippy1981

@zippy1981 we've been working on fixing several flaky tests. Can you update your branch with master and let CI run again? Thanks.

lucaspimentel avatar Oct 04 '22 12:10 lucaspimentel

we've been working on fixing several flaky tests. Can you update your branch with master and let CI run again? Thanks.

Oops, ignore my comment above. I forgot this is an external contribution.

lucaspimentel avatar Oct 04 '22 14:10 lucaspimentel

Thanks @zippy1981, sorry for the delay 🤦‍♂️

andrewlock avatar Oct 05 '22 11:10 andrewlock