dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

Published 20 hours ago • verified publisher icon DataDog

Add support for db client split by instance.

Open moonheart opened this issue 3 years ago • 2 comments

Fixes #1571

Changes proposed in this pull request:

Add Support for DD_TRACE_DB_CLIENT_SPLIT_BY_INSTANCE

@DataDog/apm-dotnet

moonheart avatar Jul 02 '21 08:07 moonheart

Thanks for taking the time to work on this, but unfortunately, I don't think this is something we are going to be able to accept right now. We are planning a long term solution to the problem of service naming across Datadog, and we don't want to introduce a new setting that will become obsolete, but which we would still need to support.

andrewlock avatar Jul 05 '21 09:07 andrewlock

@andrewlock Thanks for your reply. I believe the long term solution you are planning to the problem for service naming will be great, but how about the short one? This setting DD_TRACE_DB_CLIENT_SPLIT_BY_INSTANCE is not a new one and it exist in dd-trace-java. This PR just keeps the behaviour. 🙈

moonheart avatar Jul 06 '21 01:07 moonheart

Thanks for the contribution, @moonheart, we have no plans to add this feature to the .NET Tracer. I closed the related ticket two months ago and neglected to close the PR.

lucaspimentel avatar Oct 12 '22 14:10 lucaspimentel