dd-sdk-reactnative icon indicating copy to clipboard operation
dd-sdk-reactnative copied to clipboard

Feature flag naming

Open UrbanChrisy opened this issue 1 year ago • 2 comments

Describe the bug

When trying to set a feature flag I have a prefix for the origin of the feature flag. As such I use unleash so prefix each flag with unleash. when it shows up in the datadog dashboard it shows the name as just the unleash without the remaining string. Screenshot 2024-09-11 at 3 39 53 PM

Seems like its slicing on dashes and dots.

And the value is then shown as [object object]

Reproduction steps

import {
  DdRum,
} from '@datadog/mobile-react-native'
DdRum.addFeatureFlagEvaluation('unleash.testing-feature-flag', false)

SDK logs

No response

Expected behavior

This is treated as a unique string and allowed to padd

Affected SDK versions

^2.3.3

Latest working SDK version

Nope never worked by the looks of our logs

Did you confirm if the latest SDK version fixes the bug?

Yes

Integration Methods

NPM

React Native Version

0.73.6

Package.json Contents

No response

iOS Setup

No response

Android Setup

No response

Device Information

No response

Other relevant information

No response

UrbanChrisy avatar Sep 11 '24 22:09 UrbanChrisy

Hi @UrbanChrisy, thank you for reaching out.

I believe that unleash.testing-feature-flag is interpreted as:

"unleash": {
  "testing-feature-flag": true
}

Because of the dot notation, which is a standard in Datadog for defining nested properties.

Would it be possible for you to use another symbol as separator?

marco-saia-datadog avatar Sep 12 '24 07:09 marco-saia-datadog

@marco-saia-datadog Its kind of annoying to have to change our feature flags over different systems, is there a way to bypass this? Since these values are synced between different platforms not only datadog. And we already have feature flags in production apps which cannot be changed.

To makes more sense that Datadog would handle this and not us.

UrbanChrisy avatar Sep 19 '24 19:09 UrbanChrisy