Add background upload configuration info to batch deleted telemetry
What and why?
Enriches Batch Deleted telemetry metric with backgroundTaskEnabled configuration info.
This is needed for measuring batch delivery success rate based on existence of the configuration.
How?
I have added new field background_tasks_enabled.
in_background is still hardcoded to false, because knowing if the deletion happen in the background is not trivial.
Although I think we're mostly interested in measuring the difference is success rate for two different configurations, rather than knowing if batch file was deleted in background/foreground.
Review checklist
- [x] Feature or bugfix MUST have appropriate tests (unit, integration)
- [ ] Make sure each commit and the PR mention the Issue number or JIRA reference
- [ ] Add CHANGELOG entry for user facing changes
Datadog Report
Branch report: maciey/add-backgroundtask-telemetry
Commit report: 2ddb942
Test service: dd-sdk-ios
:white_check_mark: 0 Failed, 3491 Passed, 0 Skipped, 2m 19.07s Total Time :small_red_triangle_down: Test Sessions change in coverage: 3 decreased, 3 increased, 8 no change
:small_red_triangle_down: Code Coverage Decreases vs Default Branch (3)
/merge
:steam_locomotive: MergeQueue: pull request added to the queue
The median merge time in develop is 0s.
Use /merge -c to cancel this operation!
:x: MergeQueue: This merge request was updated
This PR is rejected because it was updated
If you need support, contact us on Slack #devflow with those details!
/merge
:steam_locomotive: MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
Use /merge -c to cancel this operation!
:steam_locomotive: MergeQueue: pull request added to the queue
The median merge time in develop is 0s.
Use /merge -c to cancel this operation!