dd-sdk-ios icon indicating copy to clipboard operation
dd-sdk-ios copied to clipboard

Add background upload configuration info to batch deleted telemetry

Open maciejburda opened this issue 1 year ago • 1 comments

What and why?

Enriches Batch Deleted telemetry metric with backgroundTaskEnabled configuration info. This is needed for measuring batch delivery success rate based on existence of the configuration.

How?

I have added new field background_tasks_enabled.

in_background is still hardcoded to false, because knowing if the deletion happen in the background is not trivial. Although I think we're mostly interested in measuring the difference is success rate for two different configurations, rather than knowing if batch file was deleted in background/foreground.

Review checklist

  • [x] Feature or bugfix MUST have appropriate tests (unit, integration)
  • [ ] Make sure each commit and the PR mention the Issue number or JIRA reference
  • [ ] Add CHANGELOG entry for user facing changes

maciejburda avatar Sep 05 '24 13:09 maciejburda

Datadog Report

Branch report: maciey/add-backgroundtask-telemetry Commit report: 2ddb942 Test service: dd-sdk-ios

:white_check_mark: 0 Failed, 3491 Passed, 0 Skipped, 2m 19.07s Total Time :small_red_triangle_down: Test Sessions change in coverage: 3 decreased, 3 increased, 8 no change

:small_red_triangle_down: Code Coverage Decreases vs Default Branch (3)

  • test DatadogInternalTests tvOS 79.72% (-0.03%) - Details
  • test DatadogTraceTests tvOS 54.24% (-0.02%) - Details
  • test DatadogCrashReportingTests tvOS 26.77% (-0.02%) - Details

/merge

maciejburda avatar Oct 17 '24 08:10 maciejburda

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in develop is 0s.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Oct 17 '24 08:10 dd-devflow[bot]

:x: MergeQueue: This merge request was updated

This PR is rejected because it was updated

If you need support, contact us on Slack #devflow with those details!

dd-devflow[bot] avatar Oct 17 '24 09:10 dd-devflow[bot]

/merge

maciejburda avatar Oct 17 '24 09:10 maciejburda

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Oct 17 '24 09:10 dd-devflow[bot]

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in develop is 0s.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Oct 17 '24 09:10 dd-devflow[bot]