dd-sdk-android icon indicating copy to clipboard operation
dd-sdk-android copied to clipboard

RUM-12062: Refactor the configuration and integration of the RUM Debug Widget

Open kikoveiga opened this issue 6 months ago • 2 comments

What does this PR do?

  • Simplifies the configuration of the RUM Debug Widget. Customers can now simply use enableRumDebugWidget() in their RumConfiguration.Builder.
  • Adds documentation for this configuration in the README.md.
  • Replaced manual overlay lifecycle management with automatic OverlayManager using activity lifecycle callbacks.

Motivation

Configuration was too complex for customers, where some unnecessary APIs had to be exposed. The DefaultInsightsOverlay had to be manually attached to every activity by customers.

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • [ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

kikoveiga avatar Oct 31 '25 15:10 kikoveiga

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 70.05% (-0.26%)
View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7c2f184 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

datadog-official[bot] avatar Nov 03 '25 14:11 datadog-official[bot]

Codecov Report

:x: Patch coverage is 1.67598% with 176 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 70.04%. Comparing base (97368ae) to head (7c2f184).

Files with missing lines Patch % Lines
...nsights/internal/overlay/DefaultInsightsOverlay.kt 0.00% 110 Missing :warning:
...droid/insights/internal/extensions/AnimationExt.kt 0.00% 30 Missing :warning:
...n/kotlin/com/datadog/android/rum/RumDebugWidget.kt 0.00% 18 Missing :warning:
...ndroid/insights/internal/overlay/OverlayManager.kt 0.00% 12 Missing :warning:
...atadog/android/insights/internal/RumDebugWidget.kt 0.00% 3 Missing :warning:
...g/android/insights/internal/InsightStateStorage.kt 0.00% 2 Missing :warning:
...otlin/com/datadog/android/rum/_RumInternalProxy.kt 0.00% 1 Missing :warning:
Additional details and impacted files
@@                             Coverage Diff                              @@
##           tvaleev/feature/innovation-week-07-04-25    #2975      +/-   ##
============================================================================
- Coverage                                     70.26%   70.04%   -0.21%     
============================================================================
  Files                                           840      842       +2     
  Lines                                         30776    30869      +93     
  Branches                                       5233     5252      +19     
============================================================================
- Hits                                          21623    21622       -1     
- Misses                                         7673     7770      +97     
+ Partials                                       1480     1477       -3     
Files with missing lines Coverage Δ
...roid/insights/internal/DefaultInsightsCollector.kt 76.71% <100.00%> (ø)
...og/android/insights/internal/extensions/LangExt.kt 29.41% <ø> (+1.63%) :arrow_up:
...kotlin/com/datadog/android/rum/RumConfiguration.kt 97.56% <100.00%> (ø)
...otlin/com/datadog/android/rum/_RumInternalProxy.kt 70.00% <0.00%> (-3.68%) :arrow_down:
...g/android/insights/internal/InsightStateStorage.kt 0.00% <0.00%> (ø)
...atadog/android/insights/internal/RumDebugWidget.kt 0.00% <0.00%> (ø)
...ndroid/insights/internal/overlay/OverlayManager.kt 0.00% <0.00%> (ø)
...n/kotlin/com/datadog/android/rum/RumDebugWidget.kt 0.00% <0.00%> (ø)
...droid/insights/internal/extensions/AnimationExt.kt 0.00% <0.00%> (ø)
...nsights/internal/overlay/DefaultInsightsOverlay.kt 0.00% <0.00%> (ø)

... and 37 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Nov 03 '25 16:11 codecov-commenter