Support nginx-opentracing v0.34.0

[miry]

nginx opentracing dropped support modules built against Opentracing v1.5, the prefix -ot16- dropped.

Solves #275

cc: @shellshock1953 @dgoffredo @cgilmour

[dgoffredo]

Hi, @miry. Thanks for the contribution.

The latest release (v0.34.0) of nginx-opentracing is no longer compatible with nginx's debian-based docker images. nginx-opentracing v0.34.0 requires GLIBC 2.38, while e.g. nginx:1.25.4 has GLIBC 2.36:

$ docker run -it --rm nginx:1.25.4 ldd --version
ldd (Debian GLIBC 2.36-9+deb12u4) 2.36
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.

This presents a problem for our nginx example, which fetches the newest versions of nginx-opentracing and dd-opentracing-cpp, and runs them on a base nginx image.

The same problem occurs in the integration tests, which are built on ubuntu:20.04, which has GLIBC 2.31:

$ docker run -it --rm ubuntu:20.04 ldd --version
ldd (Ubuntu GLIBC 2.31-0ubuntu9.14) 2.31
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.

For the integration tests, at least, we can just build on a newer ubuntu. However, I'm unable to get the integration tests to pass on my machine, probably due to file permission issues caused by differences between root docker and rootless docker. My machine uses rootless docker.

[miry]

I think it is a good feedback.

UPDATE:

Ok, checked a new way how nginx-opentracing building modules. It was built against ubuntu:2023. It installs during build binaries:

#11 5.864 Unpacking libc6:amd64 (2.38-1ubuntu6.1) over (2.38-1ubuntu6) ...
#11 6.117 Setting up libc6:amd64 (2.38-1ubuntu6.1) ...

build logs

But in same time docker images opentracing-contrib/nginx-opentracing debian/alpine uses official nginx images for debian and alpine.

As workaround you can extract opentracing module from opentracing/nginx-opentracing debian and copy to your image. dockerfile with nginx and opentracing modules

[miry]

Created a discussion issue on nginx-opentracing side https://github.com/opentracing-contrib/nginx-opentracing/issues/587