dd-opentracing-cpp icon indicating copy to clipboard operation
dd-opentracing-cpp copied to clipboard

Feature request: arm64 binaries

Open mcuelenaere opened this issue 2 years ago • 5 comments

https://github.com/opentracing-contrib/nginx-opentracing/issues/391 seems to have linux/arm64 images, but AFAICS dd-opentracing-cpp does not provide arm64 builds. Is this on purpose or just an oversight? Would it be possible to provide arm64 binaries?

mcuelenaere avatar Jun 22 '23 08:06 mcuelenaere

dd-opentracing-cpp does not provide ARM64 binaries because the need has not yet arose, and because I do not have access to an ARM64 machine. Also, the CI system we use, CircleCI, does not support ARM64 beneath their docker executor (we'd have to switch to using VMs).

What's your use case? I can probably add this to our feature request pipeline. I see you opened a similar issue in our nginx module repo.

dgoffredo avatar Jun 22 '23 18:06 dgoffredo

Our usecase is that we are evaluating switching to AWS Graviton processors and atm this means we need to disable APM tracing for our nginx setup.

I see that https://circleci.com/docs/using-arm/ exists, but I'm not super familiar with CircleCI. Could QEMU work instead? I believe that's what Github Actions uses by default.

mcuelenaere avatar Jun 22 '23 18:06 mcuelenaere

Please submit this request as a support issue via https://help.datadoghq.com/hc/en-us/requests/new and reference these github issues. This way, the feature request is associated with your account and can be tracked internally.

I see that https://circleci.com/docs/using-arm/ exists, but I'm not super familiar with CircleCI. Could QEMU work instead? I believe that's what Github Actions uses by default.

Our CI runs on CircleCI's built-in Docker executor. We could switch to using a "VM executor," but that might involve a rewrite of our CI configuration. Not a deal-breaker, but potentially time-consuming.

dgoffredo avatar Jun 22 '23 19:06 dgoffredo

Issue filed!

mcuelenaere avatar Jun 23 '23 11:06 mcuelenaere

Thanks, let's leave this open, and I'll chase after whoever I need to internally.

dgoffredo avatar Jun 23 '23 12:06 dgoffredo

Hi folks, any updates on this one? We'd also like to use Arm. Fwiw, CircleCI supports Arm for Docker executors now. See: https://circleci.com/docs/using-docker/#arm

bwhaley avatar Jul 25 '24 23:07 bwhaley

The non-OpenTracing version of the Datadog tracing nginx module, nginx-datadog, has supported arm64 for a while. It's configured differently, but has feature parity. If you can afford to change all of your tracing configuration, migrating is an option.

dgoffredo avatar Jul 26 '24 01:07 dgoffredo

Unfortunately that won't work in our case because it isn't compatible with openresty (https://github.com/DataDog/nginx-datadog/issues/30).

Any chance of adding Arm to the build process in this repo?

bwhaley avatar Jul 30 '24 21:07 bwhaley

Bummer. I'm no longer a maintainer of this repo, so I can't comment on its priority.

@dmehala for visibility.

dgoffredo avatar Jul 30 '24 21:07 dgoffredo

Gotcha, well in that case, special thanks for your feedback anyway.

bwhaley avatar Jul 30 '24 22:07 bwhaley

Hi @bwhaley

dd-opentracing-cpp is deprecated. There will be no further work on this library. Best outcome is to require OpenResty support here for visibility.

dmehala avatar Jul 30 '24 22:07 dmehala