dd-opentracing-cpp icon indicating copy to clipboard operation
dd-opentracing-cpp copied to clipboard

Published 20 hours ago • verified publisher icon DataDog

Add examples for envoy v1.15 and v1.16

Open cgilmour opened this issue 4 years ago • 1 comments

Other minor changes

  • bump version numbers for older containers
  • add version to service name

cgilmour avatar Dec 09 '20 23:12 cgilmour

I was looking at this PR.

Checked out the branch, and ran ./check_envoy_configs.sh in examples/envoy-tracing/. It hanged after the following error:

Creating envoy-tracing_dd-agent_1 ... done
Creating envoy-tracing_envoy-v1.13_1   ... done
Creating envoy-tracing_envoy-v1.14_1   ... done
Creating envoy-tracing_envoy-v1.11_1   ... done
Creating envoy-tracing_envoy-v1.15_1   ... done
Creating envoy-tracing_envoy-ed6a1b8_1 ... done
Creating envoy-tracing_envoy-v1.12_1   ... done
Creating envoy-tracing_envoy-v1.16_1   ... done
curl: (28) Failed to connect to 172.20.0.9 port 80: Connection timed out

The script could be improved by adding a call to docker-compose down in a trap handler.

Is this PR needed anymore?

dgoffredo avatar Sep 02 '21 18:09 dgoffredo