dd-agent
dd-agent copied to clipboard
[travis][ci] launch core and extras if CI run successful
What does this PR do?
This PR will run the SDK repos CI if we have a successful test run (maybe it should run always, regardless).
Motivation
During the SDK transition we have moved the checks to the core and extras repositories. These are somewhat coupled to dd-agent
, so we must ensure we launch the tests in their respective CI's after changes are made here.
Testing Guidelines
An overview on testing is available in our contribution guidelines.
Additional Notes
Anything else we should know when reviewing?
I like the idea behind the PR, however I think we should to do it another way. I see 3 possible cases:
- I open a PR and I know it's potentially breaking core/extra, then I'll check by myself.
- I open a PR that doesn't break core/extra, then nothing to do.
- (the case this PR was made for) I open a PR not knowing that it's going to break core/extra. CI is ✅ , and I won't check core/extra CI. CI is 🔴 on core/extra master, but we don't check that very often. A new PR is created on core/extra, CI is 🔴 , we have a look and we determine (hopefully easily?) it's my previous PR.
Pros:
- we can check easily when core/extra broke and track it down to dd-agent (assuming tests are not too flaky). Cons:
- it slows the dd-agent CI (by ~2min)
- it slows the entire CI (by triggering a lot more integrations-core builds); as you said the volume of dd-agent changes should go way down, so it might not be a real issue.
I think that being really careful about changes in utils/
could be enough (and catching the rest with usual CI on core/extra), and that we don't have a lot to win by triggering a CI that doesn't fail the CI on PRs.
Let me know what you think, I don't really have a solution. Maybe use the new Travis cron feature daily - https://travis-ci.org/DataDog/integrations-core/settings ?