datadog-operator icon indicating copy to clipboard operation
datadog-operator copied to clipboard

[datadogagent/finalizer] Delete dependencies of V2 agents

Open davidor opened this issue 1 year ago • 2 comments

What does this PR do?

Implements a finalizer for V2 agents. The finalizer removes all the resources associated with the agent. Before this PR, cluster roles and cluster role bindings were not being deleted.

Describe your test plan

When deleting a V2 agent, check that its associated resources are also deleted.

davidor avatar Jul 26 '22 13:07 davidor

Codecov Report

Merging #576 (4be3dd2) into main (86164f0) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #576   +/-   ##
=======================================
  Coverage   58.51%   58.51%           
=======================================
  Files           3        3           
  Lines         135      135           
=======================================
  Hits           79       79           
  Misses         43       43           
  Partials       13       13           
Flag Coverage Δ
unittests 58.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 86164f0...4be3dd2. Read the comment docs.

codecov-commenter avatar Jul 26 '22 13:07 codecov-commenter

Rebased on top of main to fix conflicts.

davidor avatar Jul 27 '22 16:07 davidor