Enable to add a reference of DatadogSLO in DatadogMonitor SLO alert type.

[melchiormoulin]

The goal is to be able to link DatadogSLO and DatadogMonitor for SLO alert type.

What does this PR do?

When a user set a SLORef in DatadogMonitor CRD. The controller query the corresponding DatadogSLO and fetch the ID from the status. It then replace the ID inside the DatadogMonitor query.

Motivation

Enable the user to create a datadogmonitor SLO alert type without the need of knowing the SLO ID.

It would solves thoses issues : https://github.com/DataDog/datadog-operator/issues/1022 https://github.com/DataDog/datadog-operator/issues/1844

Additional Notes

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

• Agent: vX.Y.Z
• Cluster Agent: vX.Y.Z

Describe your test plan

Create A DatadogSLO. Create a DatadogMonitor and refer the previous DatadogSLO in SLORef. The controller should update the id inside the query

Checklist

• [ ] PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
• [ ] PR has a milestone or the qa/skip-qa label

[celenechang]

Hi @melchiormoulin , thank you for your contribution. Do you mind if I make a few edits on your branch?

[melchiormoulin]

I don't mind at all.

[celenechang]

@melchiormoulin Sorry for the delay; we've been having internal discussions about this change, and need some more time to consider it. For now we are going to move the milestone to the next Operator release. We will keep you posted on any updates

[levan-m]

@melchiormoulin, sorry for additional delay. Unfortunately we can’t provide any ETA when and if we can merge this change.

This has nothing to do with the the implementation in the PR, rather how we see purpose of resource CRDs. When we created resource CRDs the assumption was that users would managed those independently. This PR introduces dependency between two resources, creating a precedent potentially pushing us into general dependency management which is a complex undertaking considering how monitors, SLOs, composites, synthetics etc. can reference each other.

We are contemplating if this is something we want to commit to and surveying customers how they manage dependencies now.

[melchiormoulin]

Hello thanks for the response ! I understand that you don't want to link those 2 CRD in a tech perspectives but as a user and for automation ( particularly if we packaged it those 2 CR with helm ) it will be a lot more convenient.

[levan-m]

Removing milestone and keeping open since we haven't yet prioritized looking deeper into this to make any decision. Can't provide ETA now when we can prioritize it.

[dd-octo-sts[bot]]

This pull request has been automatically marked as stale because it has not had activity in the past 15 days.

It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window.

Thank you for your contributions!

[ahatzz11]

Bumping this so it doesn't get closed - Please allow the linking between a DatadogMonitor and a DatadogSLO. The need to manage these separately is quite annoying.