datadog-ci icon indicating copy to clipboard operation
datadog-ci copied to clipboard

Running sourcemaps upload fails with old GCC

Open petems opened this issue 2 years ago • 0 comments

Bug description

On RHEL / CentOS (GCC 4)

CI/.gradle/nodejs/node-v12.18.3-linux-x64/bin/npx @datadog/[email protected] sourcemaps upload ./build --service=example --release-version=6.5.1-test-b53 --minified-path-prefix=/static/js

Successfully started process 'command 'CI/.gradle/nodejs/node-v12.18.3-linux-x64/bin/npx''

In file included from ../deps/cpu_features/src/impl_x86__base_implementation.inl:89:0,

                 from ../deps/cpu_features/src/impl_x86_linux_or_android.c:20:

../deps/cpu_features/src/copy.inl: In function ‘copy’:

../deps/cpu_features/src/copy.inl:18:3: error: ‘for’ loop initial declarations are only allowed in C99 mode

   for (size_t i = 0; i < count; ++i) dst[i] = src[i];

   ^

../deps/cpu_features/src/copy.inl:18:3: note: use option -std=c99 or -std=gnu99 to compile your code

In file included from ../deps/cpu_features/src/impl_x86__base_implementation.inl:91:0,

                 from ../deps/cpu_features/src/impl_x86_linux_or_android.c:20:

../deps/cpu_features/src/equals.inl: In function ‘equals’:

../deps/cpu_features/src/equals.inl:19:3: error: ‘for’ loop initial declarations are only allowed in C99 mode

   for (size_t i = 0; i < count; ++i)

   ^

In file included from ../deps/cpu_features/src/impl_x86_linux_or_android.c:20:0:

../deps/cpu_features/src/impl_x86__base_implementation.inl: In function ‘ParseLeaf2’:

../deps/cpu_features/src/impl_x86__base_implementation.inl:1730:3: error: ‘for’ loop initial declarations are only allowed in C99 mode

   for (size_t i = 0; i < sizeof(data); ++i) {

   ^

../deps/cpu_features/src/impl_x86__base_implementation.inl: In function ‘ParseCacheInfo’:

../deps/cpu_features/src/impl_x86__base_implementation.inl:1746:3: error: ‘for’ loop initial declarations are only allowed in C99 mode

   for (int index = 0; info.size < CPU_FEATURES_MAX_CACHE_LEVEL; ++index) {

   ^

../deps/cpu_features/src/impl_x86__base_implementation.inl: In function ‘ParseCacheInfoLegacyAMD’:

../deps/cpu_features/src/impl_x86__base_implementation.inl:1873:3: error: ‘for’ loop initial declarations are only allowed in C99 mode

   for (int i = 0; i < LEGACY_AMD_MAX_CACHE_LEVEL; ++i) {

   ^

../deps/cpu_features/src/impl_x86_linux_or_android.c: In function ‘DetectFeaturesFromOs’:

../deps/cpu_features/src/impl_x86_linux_or_android.c:37:5: error: ‘for’ loop initial declarations are only allowed in C99 mode

     for (bool stop = false; !stop;) {

     ^

Looks like a similar issue happened with the PHP trace library, and looks like adding the -99 to the build options was put in as a fix: https://github.com/DataDog/dd-trace-php/pull/396

Describe what you expected

No response

Steps to reproduce the issue

No response

Additional context

No response

Command

sourcemaps

petems avatar Sep 11 '23 09:09 petems