datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

switch to ebpf-platform slack channel for reviews

Open brycekahle opened this issue 1 week ago • 2 comments

What does this PR do?

Moves ebpf-platform reviews back to #ebpf-platform channel.

Motivation

The review requests were getting lost in the noise of the Github reminders

Describe how you validated your changes

Additional Notes

brycekahle avatar Dec 15 '25 21:12 brycekahle

Static quality checks

✅ Please find below the results from static quality gates Comparison made with ancestor 004ef89fb7aa5bc942191ccb1cdad7dbca3c836d

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+0.01}$$ $${706.33}$$ < $${707.13}$$ $${-0.03}$$ $${173.27}$$ < $${174.16}$$
agent_deb_amd64_fips $${+0.01}$$ $${702.55}$$ < $${702.86}$$ $${-0.01}$$ $${172.56}$$ < $${173.5}$$
agent_heroku_amd64 $${0}$$ $${327.51}$$ < $${327.92}$$ $${+0}$$ $${87.24}$$ < $${88.21}$$
agent_msi $${0}$$ $${570.41}$$ < $${982.08}$$ $${-0.01}$$ $${142.49}$$ < $${143.49}$$
agent_rpm_amd64 $${+0.01}$$ $${706.31}$$ < $${707.12}$$ $${+0.04}$$ $${176.39}$$ < $${177.29}$$
agent_rpm_amd64_fips $${+0.01}$$ $${702.53}$$ < $${702.85}$$ $${-0}$$ $${175.4}$$ < $${176.32}$$
agent_rpm_arm64 $${+0.01}$$ $${688.02}$$ < $${691.67}$$ $${+0.02}$$ $${159.43}$$ < $${160.7}$$
agent_rpm_arm64_fips $${+0.01}$$ $${685.06}$$ < $${687.54}$$ $${+0.01}$$ $${159.17}$$ < $${160.11}$$
agent_suse_amd64 $${+0.01}$$ $${706.31}$$ < $${707.12}$$ $${+0.04}$$ $${176.39}$$ < $${177.29}$$
agent_suse_amd64_fips $${+0.01}$$ $${702.53}$$ < $${702.85}$$ $${-0}$$ $${175.4}$$ < $${176.32}$$
agent_suse_arm64 $${+0.01}$$ $${688.02}$$ < $${691.67}$$ $${+0.02}$$ $${159.43}$$ < $${160.7}$$
agent_suse_arm64_fips $${+0.01}$$ $${685.06}$$ < $${687.54}$$ $${+0.01}$$ $${159.17}$$ < $${160.11}$$
docker_agent_amd64 $${+0.01}$$ $${768.57}$$ < $${769.38}$$ $${+0}$$ $${261.17}$$ < $${262.06}$$
docker_agent_arm64 $${+0.01}$$ $${774.81}$$ < $${778.35}$$ $${+0}$$ $${250.27}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${+0.01}$$ $${959.45}$$ < $${960.26}$$ $${+0}$$ $${329.8}$$ < $${330.69}$$
docker_agent_jmx_arm64 $${+0.01}$$ $${954.41}$$ < $${957.95}$$ $${-0}$$ $${314.9}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${+0}$$ $${179.41}$$ < $${179.56}$$ $${+0}$$ $${63.44}$$ < $${64.14}$$
docker_cluster_agent_arm64 $${+0}$$ $${195.36}$$ < $${196.79}$$ $${+0.01}$$ $${59.75}$$ < $${60.69}$$
docker_cws_instrumentation_amd64 $${-0}$$ $${7.13}$$ < $${7.18}$$ $${-0}$$ $${2.99}$$ < $${3.33}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.73}$$ < $${3.09}$$
docker_dogstatsd_amd64 $${+0}$$ $${38.75}$$ < $${39.38}$$ $${-0}$$ $${15.0}$$ < $${15.82}$$
docker_dogstatsd_arm64 $${0}$$ $${37.06}$$ < $${37.94}$$ $${+0}$$ $${14.33}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.97}$$ < $${30.61}$$ $${+0}$$ $${7.93}$$ < $${8.79}$$
dogstatsd_deb_arm64 $${0}$$ $${28.13}$$ < $${29.11}$$ $${-0}$$ $${6.81}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.97}$$ < $${30.61}$$ $${-0}$$ $${7.94}$$ < $${8.8}$$
dogstatsd_suse_amd64 $${0}$$ $${29.97}$$ < $${30.61}$$ $${-0}$$ $${7.94}$$ < $${8.8}$$
iot_agent_deb_amd64 $${0}$$ $${42.73}$$ < $${43.29}$$ $${+0}$$ $${11.19}$$ < $${12.04}$$
iot_agent_deb_arm64 $${0}$$ $${39.87}$$ < $${40.92}$$ $${-0}$$ $${9.57}$$ < $${10.45}$$
iot_agent_deb_armhf $${0}$$ $${40.44}$$ < $${41.03}$$ $${-0}$$ $${9.76}$$ < $${10.62}$$
iot_agent_rpm_amd64 $${0}$$ $${42.73}$$ < $${43.29}$$ $${+0}$$ $${11.21}$$ < $${12.06}$$
iot_agent_suse_amd64 $${0}$$ $${42.73}$$ < $${43.29}$$ $${+0}$$ $${11.21}$$ < $${12.06}$$

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4dcbb829-01b8-4425-9ab8-6f07f5c0cf25

Baseline: d1bd2516636112b7f5a589742d54e2c8fe20caa9 Comparison: 99efc5fc5b8facc125bfe9eef3229ccdf96b9ebe Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.91 [-1.15, +4.97] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.91 [-1.15, +4.97] 1 Logs
ddot_metrics memory utilization +0.60 [+0.37, +0.82] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.32 [+0.27, +0.37] 1 Logs
ddot_metrics_sum_delta memory utilization +0.23 [+0.03, +0.43] 1 Logs
quality_gate_idle memory utilization +0.05 [+0.01, +0.10] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.34, +0.38] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.11, +0.13] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.39, +0.41] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.13, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.08, +0.07] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.05, +0.03] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.40, +0.34] 1 Logs
file_tree memory utilization -0.12 [-0.18, -0.06] 1 Logs
docker_containers_memory memory utilization -0.15 [-0.22, -0.08] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.28 [-0.51, -0.05] 1 Logs
quality_gate_idle_all_features memory utilization -0.36 [-0.40, -0.33] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization -0.41 [-0.56, -0.25] 1 Logs
ddot_logs memory utilization -0.41 [-0.47, -0.35] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.41 [-0.57, -0.26] 1 Logs
quality_gate_metrics_logs memory utilization -0.51 [-0.72, -0.30] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.69 [-2.17, +0.79] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.74 [-0.83, -0.65] 1 Logs
otlp_ingest_logs memory utilization -0.90 [-1.00, -0.80] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

cit-pr-commenter[bot] avatar Dec 15 '25 21:12 cit-pr-commenter[bot]

ISTM that this file should be approveable by anyone, and then have a syntax check on top of it. Needing devx to change feels like toil for the team.

aiuto avatar Dec 16 '25 17:12 aiuto

ISTM that this file should be approveable by anyone, and then have a syntax check on top of it. Needing devx to change feels like toil for the team.

Definitely toil, however I think a better solution would be to have team-specific files/directories to shard ownership that could then be extended to support all configuration.

ofek avatar Dec 16 '25 18:12 ofek

/merge

brycekahle avatar Dec 16 '25 19:12 brycekahle

View all feedbacks in Devflow UI.

2025-12-16 19:04:46 UTC :information_source: Start processing command /merge


2025-12-16 19:04:51 UTC :information_source: MergeQueue: pull request added to the queue

The expected merge time in main is approximately 53m (p90).


2025-12-16 19:09:47 UTC :x: MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 937315e:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail. Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

/merge

brycekahle avatar Dec 16 '25 20:12 brycekahle

View all feedbacks in Devflow UI.

2025-12-16 20:07:49 UTC :information_source: Start processing command /merge


2025-12-16 20:07:54 UTC :information_source: MergeQueue: pull request added to the queue

The expected merge time in main is approximately 53m (p90).


2025-12-16 20:34:03 UTC :information_source: MergeQueue: This merge request was merged