datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Patch a generic placeholder in openssl libraries

Open JSGette opened this issue 2 months ago • 2 comments

The problem is there is no official way to make openssl portable. Since we are triggering openssl's build system from inside of bazel we are getting sandbox paths injected into libraries and binaries created by openssl's build. The only current way to tackle it is to put a placeholder instead of the valid one (but openssl's build won't allow it) and then replace that placeholder with the expected installation path. So the workflow is following:

  1. Build openssl
  2. Patch libraries and replace sandbox paths with a PLACEHOLDER
  3. Run @openssl//:install to put it to the expected place
  4. Run //deps/openssl:fix_openssl_paths to replace PLACEHOLDER with the expected path

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

JSGette avatar Dec 15 '25 15:12 JSGette

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a67cf3dc-d8ff-4202-a098-860a4ffefdc2

Baseline: ad2d771190082c756ea4b117ee44cf53c57c6fb8 Comparison: ebd23b19fc1afe060e58c2f9c94c84e56ccee58a Diff

❌ Experiments with retried target crashes

This is a critical error. One or more replicates failed with a non-zero exit code. These replicates may have been retried. See Replicate Execution Details for more information.

  • quality_gate_metrics_logs

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.85 [-0.27, +5.98] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.85 [-0.27, +5.98] 1 Logs
ddot_metrics memory utilization +1.18 [+0.95, +1.40] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.51 [+0.46, +0.56] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.28 [+0.21, +0.36] 1 Logs
docker_containers_memory memory utilization +0.28 [+0.21, +0.35] 1 Logs
otlp_ingest_metrics memory utilization +0.10 [-0.06, +0.25] 1 Logs
quality_gate_idle_all_features memory utilization +0.03 [-0.01, +0.07] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_v3 ingress throughput +0.02 [-0.11, +0.15] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.12, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.08, +0.07] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.06, +0.04] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.43, +0.38] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.40, +0.34] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.03 [-0.46, +0.39] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.05 [-0.21, +0.10] 1 Logs
quality_gate_idle memory utilization -0.11 [-0.15, -0.07] 1 Logs bounds checks dashboard
file_tree memory utilization -0.15 [-0.20, -0.10] 1 Logs
ddot_logs memory utilization -0.22 [-0.27, -0.16] 1 Logs
otlp_ingest_logs memory utilization -0.33 [-0.43, -0.23] 1 Logs
ddot_metrics_sum_delta memory utilization -0.41 [-0.62, -0.21] 1 Logs
quality_gate_metrics_logs memory utilization -0.43 [-0.65, -0.22] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.48 [-0.71, -0.24] 1 Logs
quality_gate_logs % cpu utilization -1.61 [-3.08, -0.15] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Normal Replicate Execution Failures (non-profiling)

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_metrics_logs baseline 7 Failed to shutdown when requested Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

cit-pr-commenter[bot] avatar Dec 15 '25 16:12 cit-pr-commenter[bot]

Static quality checks

✅ Please find below the results from static quality gates Comparison made with ancestor 45bf973584c5633eedf2c13b746335092b7d4b20

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 DataNotFound $${705.94}$$ < $${717.44}$$ DataNotFound $${173.16}$$ < $${177.37}$$
agent_deb_amd64_fips DataNotFound $${700.36}$$ < $${711.66}$$ DataNotFound $${171.84}$$ < $${174.84}$$
agent_heroku_amd64 DataNotFound $${327.27}$$ < $${337.57}$$ DataNotFound $${87.34}$$ < $${90.78}$$
agent_msi DataNotFound $${982.69}$$ < $${1015.38}$$ DataNotFound $${142.39}$$ < $${149.42}$$
agent_rpm_amd64 DataNotFound $${705.93}$$ < $${717.41}$$ DataNotFound $${176.19}$$ < $${178.01}$$
agent_rpm_amd64_fips DataNotFound $${700.35}$$ < $${711.64}$$ DataNotFound $${174.02}$$ < $${177.26}$$
agent_rpm_arm64 DataNotFound $${691.61}$$ < $${702.19}$$ DataNotFound $${159.96}$$ < $${163.22}$$
agent_rpm_arm64_fips DataNotFound $${686.9}$$ < $${697.6}$$ DataNotFound $${159.19}$$ < $${162.68}$$
agent_suse_amd64 DataNotFound $${705.93}$$ < $${717.41}$$ DataNotFound $${176.19}$$ < $${178.01}$$
agent_suse_amd64_fips DataNotFound $${700.35}$$ < $${711.64}$$ DataNotFound $${174.02}$$ < $${177.26}$$
agent_suse_arm64 DataNotFound $${691.61}$$ < $${702.19}$$ DataNotFound $${159.96}$$ < $${163.22}$$
agent_suse_arm64_fips DataNotFound $${686.9}$$ < $${697.6}$$ DataNotFound $${159.19}$$ < $${162.68}$$
docker_agent_amd64 DataNotFound $${768.3}$$ < $${769.92}$$ DataNotFound $${260.93}$$ < $${261.52}$$
docker_agent_arm64 DataNotFound $${778.25}$$ < $${779.46}$$ DataNotFound $${251.12}$$ < $${251.72}$$
docker_agent_jmx_amd64 DataNotFound $${959.17}$$ < $${960.8}$$ DataNotFound $${329.57}$$ < $${330.15}$$
docker_agent_jmx_arm64 DataNotFound $${957.85}$$ < $${958.93}$$ DataNotFound $${315.74}$$ < $${316.35}$$
docker_cluster_agent_amd64 DataNotFound $${178.85}$$ < $${207.49}$$ DataNotFound $${63.14}$$ < $${70.2}$$
docker_cluster_agent_arm64 DataNotFound $${196.34}$$ < $${223.38}$$ DataNotFound $${59.89}$$ < $${66.42}$$
docker_cws_instrumentation_amd64 DataNotFound $${7.07}$$ < $${7.12}$$ DataNotFound $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 DataNotFound $${6.69}$$ < $${6.92}$$ DataNotFound $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 DataNotFound $${38.57}$$ < $${39.3}$$ DataNotFound $${14.91}$$ < $${15.76}$$
docker_dogstatsd_arm64 DataNotFound $${37.24}$$ < $${37.94}$$ DataNotFound $${14.35}$$ < $${14.83}$$
dogstatsd_deb_amd64 DataNotFound $${29.79}$$ < $${30.53}$$ DataNotFound $${7.86}$$ < $${8.75}$$
dogstatsd_deb_arm64 DataNotFound $${28.3}$$ < $${29.11}$$ DataNotFound $${6.8}$$ < $${7.71}$$
dogstatsd_rpm_amd64 DataNotFound $${29.79}$$ < $${30.53}$$ DataNotFound $${7.87}$$ < $${8.76}$$
dogstatsd_suse_amd64 DataNotFound $${29.79}$$ < $${30.53}$$ DataNotFound $${7.87}$$ < $${8.76}$$
iot_agent_deb_amd64 DataNotFound $${42.54}$$ < $${43.19}$$ DataNotFound $${11.11}$$ < $${11.98}$$
iot_agent_deb_arm64 DataNotFound $${40.28}$$ < $${40.92}$$ DataNotFound $${9.57}$$ < $${10.45}$$
iot_agent_deb_armhf DataNotFound $${40.19}$$ < $${40.86}$$ DataNotFound $${9.68}$$ < $${10.56}$$
iot_agent_rpm_amd64 DataNotFound $${42.54}$$ < $${43.19}$$ DataNotFound $${11.13}$$ < $${12.0}$$
iot_agent_suse_amd64 DataNotFound $${42.54}$$ < $${43.19}$$ DataNotFound $${11.13}$$ < $${12.0}$$

/merge

spencergilbert avatar Dec 17 '25 13:12 spencergilbert

View all feedbacks in Devflow UI.

2025-12-17 13:39:19 UTC :information_source: Start processing command /merge


2025-12-17 13:39:24 UTC :information_source: MergeQueue: pull request added to the queue

The expected merge time in 7.74.x is approximately 56m (p90).


2025-12-17 14:05:42 UTC :information_source: MergeQueue: This merge request was merged