datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[ABLD-8] Proof of concept of creating install scripts with bazel

Open aiuto opened this issue 1 month ago • 3 comments

  • create a rule that will expand a template, automatically using the command line flags to set an output dir and the path of the install_dir
  • create /packages/debian/etc as the place to hold the creation of the etc files.
  • Do it for a single script in agent-init-scripts.rb

Followups

  • Convert more scripts in another PR.
  • Do the same pattern for redhat init scripts
  • Have dd_agent_expand_template return a PackageFilesInfo so that we can consume it directly.

testing

  • run CI, grab the .deb artifact, unpack it, verify /etc/init is identical to a previously built package.

Related: ABLD-303

aiuto avatar Dec 13 '25 04:12 aiuto

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7d1ca057-cf22-4d88-aa98-6903d021a137

Baseline: 4b7ca7c467646e20b8b2371f9d6c4451437c02e0 Comparison: 91da39a4668c8bb25821cc2077193556aaff1c3d Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -1.36 [-4.38, +1.67] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +1.75 [+1.55, +1.96] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization +0.05 [-0.17, +0.27] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.04 [-0.36, +0.45] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.11, +0.14] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.41, +0.43] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.07, +0.08] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.05, +0.05] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.13, +0.13] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.41, +0.35] 1 Logs
quality_gate_idle_all_features memory utilization -0.04 [-0.07, -0.00] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization -0.06 [-0.21, +0.10] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.06 [-0.28, +0.17] 1 Logs
file_tree memory utilization -0.09 [-0.14, -0.03] 1 Logs
quality_gate_logs % cpu utilization -0.10 [-1.58, +1.37] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.13 [-0.17, -0.08] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.18 [-0.23, -0.13] 1 Logs
ddot_logs memory utilization -0.20 [-0.27, -0.13] 1 Logs
docker_containers_memory memory utilization -0.27 [-0.34, -0.20] 1 Logs
otlp_ingest_metrics memory utilization -0.35 [-0.50, -0.20] 1 Logs
otlp_ingest_logs memory utilization -0.39 [-0.50, -0.28] 1 Logs
ddot_metrics memory utilization -0.59 [-0.80, -0.37] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.33 [-1.41, -1.25] 1 Logs
docker_containers_cpu % cpu utilization -1.36 [-4.38, +1.67] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

cit-pr-commenter[bot] avatar Dec 13 '25 05:12 cit-pr-commenter[bot]

Gitlab CI Configuration Changes

Updated: .gitlab-ci.yml

:warning: Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
0 49 0 0

Updated: .gitlab/trigger_distribution/include.yml

:warning: Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
0 1 0 0

:information_source: Diff available in the job log.

Static quality checks

✅ Please find below the results from static quality gates Comparison made with ancestor 4b7ca7c467646e20b8b2371f9d6c4451437c02e0

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+0}$$ $${707.17}$$ < $${707.24}$$ $${-0.05}$$ $${173.44}$$ < $${174.02}$$
agent_deb_amd64_fips $${0}$$ $${702.47}$$ < $${702.86}$$ $${-0.01}$$ $${172.41}$$ < $${173.5}$$
agent_heroku_amd64 $${-0}$$ $${328.84}$$ < $${329.53}$$ $${+0.01}$$ $${87.47}$$ < $${88.43}$$
agent_msi $${0}$$ $${570.86}$$ < $${982.08}$$ $${+0.01}$$ $${142.76}$$ < $${143.02}$$
agent_rpm_amd64 $${+0}$$ $${707.15}$$ < $${707.23}$$ $${-0}$$ $${176.05}$$ < $${177.24}$$
agent_rpm_amd64_fips $${0}$$ $${702.46}$$ < $${702.85}$$ $${+0.01}$$ $${175.59}$$ < $${176.32}$$
agent_rpm_arm64 $${-0}$$ $${688.94}$$ < $${692.59}$$ $${+0.02}$$ $${159.66}$$ < $${160.9}$$
agent_rpm_arm64_fips $${-0}$$ $${685.05}$$ < $${687.54}$$ $${-0.03}$$ $${159.0}$$ < $${160.11}$$
agent_suse_amd64 $${+0}$$ $${707.15}$$ < $${707.23}$$ $${-0}$$ $${176.05}$$ < $${177.24}$$
agent_suse_amd64_fips $${0}$$ $${702.46}$$ < $${702.85}$$ $${+0.01}$$ $${175.59}$$ < $${176.32}$$
agent_suse_arm64 $${-0}$$ $${688.94}$$ < $${692.59}$$ $${+0.02}$$ $${159.66}$$ < $${160.9}$$
agent_suse_arm64_fips $${-0}$$ $${685.05}$$ < $${687.54}$$ $${-0.03}$$ $${159.0}$$ < $${160.11}$$
docker_agent_amd64 $${+0}$$ $${768.96}$$ < $${769.58}$$ $${+0.01}$$ $${261.25}$$ < $${261.89}$$
docker_agent_arm64 $${-0}$$ $${775.31}$$ < $${779.27}$$ $${+0.01}$$ $${250.3}$$ < $${252.08}$$
docker_agent_jmx_amd64 $${+0}$$ $${959.84}$$ < $${960.46}$$ $${+0}$$ $${329.9}$$ < $${330.53}$$
docker_agent_jmx_arm64 $${+0}$$ $${954.9}$$ < $${958.87}$$ $${+0.02}$$ $${314.92}$$ < $${316.71}$$
docker_cluster_agent_amd64 $${-0}$$ $${180.42}$$ < $${181.08}$$ $${-0}$$ $${63.73}$$ < $${64.49}$$
docker_cluster_agent_arm64 $${-0}$$ $${196.3}$$ < $${198.49}$$ $${+0}$$ $${60.03}$$ < $${61.17}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.13}$$ < $${7.18}$$ $${+0}$$ $${2.99}$$ < $${3.33}$$
docker_cws_instrumentation_arm64 $${+0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.73}$$ < $${3.09}$$
docker_dogstatsd_amd64 $${0}$$ $${38.77}$$ < $${39.38}$$ $${-0}$$ $${15.01}$$ < $${15.82}$$
docker_dogstatsd_arm64 $${+0}$$ $${37.07}$$ < $${37.94}$$ $${+0}$$ $${14.34}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${30.0}$$ < $${30.61}$$ $${-0}$$ $${7.93}$$ < $${8.79}$$
dogstatsd_deb_arm64 $${0}$$ $${28.15}$$ < $${29.11}$$ $${-0}$$ $${6.81}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${30.0}$$ < $${30.61}$$ $${+0}$$ $${7.94}$$ < $${8.8}$$
dogstatsd_suse_amd64 $${0}$$ $${30.0}$$ < $${30.61}$$ $${+0}$$ $${7.94}$$ < $${8.8}$$
iot_agent_deb_amd64 $${0}$$ $${42.94}$$ < $${43.29}$$ $${+0}$$ $${11.25}$$ < $${12.04}$$
iot_agent_deb_arm64 $${0}$$ $${40.07}$$ < $${40.92}$$ $${+0}$$ $${9.61}$$ < $${10.45}$$
iot_agent_deb_armhf $${0}$$ $${40.65}$$ < $${41.03}$$ $${-0}$$ $${9.81}$$ < $${10.62}$$
iot_agent_rpm_amd64 $${0}$$ $${42.94}$$ < $${43.29}$$ $${+0}$$ $${11.26}$$ < $${12.06}$$
iot_agent_suse_amd64 $${0}$$ $${42.94}$$ < $${43.29}$$ $${+0}$$ $${11.26}$$ < $${12.06}$$

/merge

aiuto avatar Dec 19 '25 14:12 aiuto

View all feedbacks in Devflow UI.

2025-12-19 14:27:52 UTC :information_source: Start processing command /merge


2025-12-19 14:27:58 UTC :information_source: MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.


2025-12-19 16:00:16 UTC :information_source: MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).


2025-12-19 17:30:31 UTC :information_source: MergeQueue: This merge request was merged