build dbus static
What does this PR do?
- Build dbus as a static library.
- Link it right into openscap.so
- prune the dbus .h files from the distribution
Motivation
Both disk and idle set size savings.
- If we link it we don't have to ship an .so. We can probably remove the .h files too. Let's save that for a followup to keep rollback surface smaller now.
Risks
All the tests pass, but I don't entirely trust that - mostly because I do not know enough about how openscap gets used and what it does. I would be surprised if customers were able to find our libdbus.so and build and link against it, but maybe there are integrations which do so.
- Resolution: Tested by cspm team.
Static quality checks
✅ Please find below the results from static quality gates Comparison made with ancestor 004ef89fb7aa5bc942191ccb1cdad7dbca3c836d
Successful checks
Info
| Quality gate | Delta | On disk size (MiB) | Delta | On wire size (MiB) | |
|---|---|---|---|---|---|
| ✅ | agent_deb_amd64 | $${-0.17}$$ | $${706.15}$$ < $${707.13}$$ | $${-0.01}$$ | $${173.29}$$ < $${174.16}$$ |
| ✅ | agent_deb_amd64_fips | $${-0.17}$$ | $${702.37}$$ < $${702.86}$$ | $${-0.03}$$ | $${172.55}$$ < $${173.5}$$ |
| ✅ | agent_heroku_amd64 | $${-0}$$ | $${327.51}$$ < $${327.92}$$ | $${-0}$$ | $${87.23}$$ < $${88.21}$$ |
| ✅ | agent_msi | $${-0}$$ | $${570.41}$$ < $${982.08}$$ | $${-0.01}$$ | $${142.49}$$ < $${143.49}$$ |
| ✅ | agent_rpm_amd64 | $${-0.17}$$ | $${706.13}$$ < $${707.12}$$ | $${+0.04}$$ | $${176.4}$$ < $${177.29}$$ |
| ✅ | agent_rpm_amd64_fips | $${-0.17}$$ | $${702.35}$$ < $${702.85}$$ | $${-0.1}$$ | $${175.3}$$ < $${176.32}$$ |
| ✅ | agent_rpm_arm64 | $${-0.16}$$ | $${687.85}$$ < $${691.67}$$ | $${+0.06}$$ | $${159.47}$$ < $${160.7}$$ |
| ✅ | agent_rpm_arm64_fips | $${-0.16}$$ | $${684.89}$$ < $${687.54}$$ | $${-0}$$ | $${159.16}$$ < $${160.11}$$ |
| ✅ | agent_suse_amd64 | $${-0.17}$$ | $${706.13}$$ < $${707.12}$$ | $${+0.04}$$ | $${176.4}$$ < $${177.29}$$ |
| ✅ | agent_suse_amd64_fips | $${-0.17}$$ | $${702.35}$$ < $${702.85}$$ | $${-0.1}$$ | $${175.3}$$ < $${176.32}$$ |
| ✅ | agent_suse_arm64 | $${-0.16}$$ | $${687.85}$$ < $${691.67}$$ | $${+0.06}$$ | $${159.47}$$ < $${160.7}$$ |
| ✅ | agent_suse_arm64_fips | $${-0.16}$$ | $${684.89}$$ < $${687.54}$$ | $${-0}$$ | $${159.16}$$ < $${160.11}$$ |
| ✅ | docker_agent_amd64 | $${-0.17}$$ | $${768.39}$$ < $${769.38}$$ | $${-0.03}$$ | $${261.14}$$ < $${262.06}$$ |
| ✅ | docker_agent_arm64 | $${-0.16}$$ | $${774.64}$$ < $${778.35}$$ | $${-0.04}$$ | $${250.23}$$ < $${251.72}$$ |
| ✅ | docker_agent_jmx_amd64 | $${-0.17}$$ | $${959.27}$$ < $${960.26}$$ | $${-0.03}$$ | $${329.77}$$ < $${330.69}$$ |
| ✅ | docker_agent_jmx_arm64 | $${-0.16}$$ | $${954.24}$$ < $${957.95}$$ | $${-0.04}$$ | $${314.85}$$ < $${316.35}$$ |
| ✅ | docker_cluster_agent_amd64 | $${+0}$$ | $${179.4}$$ < $${179.56}$$ | $${-0}$$ | $${63.43}$$ < $${64.14}$$ |
| ✅ | docker_cluster_agent_arm64 | $${+0}$$ | $${195.36}$$ < $${196.79}$$ | $${+0}$$ | $${59.74}$$ < $${60.69}$$ |
| ✅ | docker_cws_instrumentation_amd64 | $${0}$$ | $${7.13}$$ < $${7.18}$$ | $${-0}$$ | $${2.99}$$ < $${3.33}$$ |
| ✅ | docker_cws_instrumentation_arm64 | $${0}$$ | $${6.69}$$ < $${6.92}$$ | $${0}$$ | $${2.73}$$ < $${3.09}$$ |
| ✅ | docker_dogstatsd_amd64 | $${+0}$$ | $${38.75}$$ < $${39.38}$$ | $${-0}$$ | $${15.0}$$ < $${15.82}$$ |
| ✅ | docker_dogstatsd_arm64 | $${0}$$ | $${37.06}$$ < $${37.94}$$ | $${+0}$$ | $${14.33}$$ < $${14.83}$$ |
| ✅ | dogstatsd_deb_amd64 | $${0}$$ | $${29.97}$$ < $${30.61}$$ | $${-0}$$ | $${7.93}$$ < $${8.79}$$ |
| ✅ | dogstatsd_deb_arm64 | $${0}$$ | $${28.13}$$ < $${29.11}$$ | $${-0}$$ | $${6.81}$$ < $${7.71}$$ |
| ✅ | dogstatsd_rpm_amd64 | $${0}$$ | $${29.97}$$ < $${30.61}$$ | $${+0}$$ | $${7.94}$$ < $${8.8}$$ |
| ✅ | dogstatsd_suse_amd64 | $${0}$$ | $${29.97}$$ < $${30.61}$$ | $${+0}$$ | $${7.94}$$ < $${8.8}$$ |
| ✅ | iot_agent_deb_amd64 | $${0}$$ | $${42.73}$$ < $${43.29}$$ | $${+0}$$ | $${11.19}$$ < $${12.04}$$ |
| ✅ | iot_agent_deb_arm64 | $${0}$$ | $${39.87}$$ < $${40.92}$$ | $${+0}$$ | $${9.58}$$ < $${10.45}$$ |
| ✅ | iot_agent_deb_armhf | $${0}$$ | $${40.44}$$ < $${41.03}$$ | $${+0}$$ | $${9.77}$$ < $${10.62}$$ |
| ✅ | iot_agent_rpm_amd64 | $${0}$$ | $${42.73}$$ < $${43.29}$$ | $${+0}$$ | $${11.21}$$ < $${12.06}$$ |
| ✅ | iot_agent_suse_amd64 | $${0}$$ | $${42.73}$$ < $${43.29}$$ | $${+0}$$ | $${11.21}$$ < $${12.06}$$ |
Regression Detector
Regression Detector Results
Metrics dashboard
Target profiles
Run ID: 3bd450db-f26d-44cc-a584-e2ccc1140038
Baseline: 004ef89fb7aa5bc942191ccb1cdad7dbca3c836d Comparison: 4d1666c22d2cab8ad1a4243321d2ae8662a9ffe2 Diff
Optimization Goals: ✅ No significant changes detected
Experiments ignored for regressions
Regressions in experiments with settings containing erratic: true are ignored.
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.92 | [-1.12, +4.95] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.92 | [-1.12, +4.95] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +1.40 | [+1.31, +1.48] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +0.75 | [-0.74, +2.23] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | +0.59 | [+0.53, +0.66] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.40 | [+0.24, +0.56] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.20 | [+0.13, +0.28] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.19 | [+0.10, +0.29] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.18 | [-0.04, +0.40] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.10 | [-0.13, +0.33] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.07 | [-0.36, +0.49] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.05 | [-0.33, +0.43] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.07, +0.08] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.00 | [-0.05, +0.05] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.00 | [-0.13, +0.12] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.13, +0.12] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.02 | [-0.44, +0.39] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.03 | [-0.10, +0.04] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.14 | [-0.19, -0.10] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | -0.22 | [-0.37, -0.06] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.29 | [-0.34, -0.23] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.43 | [-0.65, -0.21] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.52 | [-0.56, -0.48] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.71 | [-0.91, -0.50] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
I've successfully ran the CSPM Host Benchmarks non-regression tests.
I'm always happy when linking statically.
Confirmed in https://dd.slack.com/archives/C5SQHB3LZ/p1765562017738039 that this linkage is allowed.
/merge
View all feedbacks in Devflow UI.
2025-12-16 13:55:42 UTC :information_source: Start processing command /merge
2025-12-16 13:55:47 UTC :information_source: MergeQueue: pull request added to the queue
The expected merge time in main is approximately 46m (p90).
2025-12-16 14:14:03 UTC :information_source: MergeQueue: This merge request was merged