datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Allow nghttp2 to export a shared library so that we can link the curl binary dynamically against it.

Open aiuto opened this issue 1 month ago • 6 comments

Allow nghttp2 to export a shared library so that we can link the curl binary dynamically against it.

  • Use case in the curl PR. https://github.com/DataDog/datadog-agent/pull/42546/

After building curl, we see this.

$ ldd bazel-bin/external/+_repo_rules+curl/curl_bin
            linux-vdso.so.1 (0x0000ffffa8c25000)
            libnghttp2.so.14 => /opt/datadog-agent/embedded/lib/libnghttp2.so.14 (0x0000ffff90240000)
            libz.so => /opt/datadog-agent/embedded/lib/libz.so (0x0000ffff90210000)
            libpthread.so.0 => /lib/aarch64-linux-gnu/libpthread.so.0 (0x0000ffff901e0000)
            libm.so.6 => /lib/aarch64-linux-gnu/libm.so.6 (0x0000ffff90130000)
            libdl.so.2 => /lib/aarch64-linux-gnu/libdl.so.2 (0x0000ffff90100000)
            librt.so.1 => /lib/aarch64-linux-gnu/librt.so.1 (0x0000ffff900d0000)
            libc.so.6 => /lib/aarch64-linux-gnu/libc.so.6 (0x0000ffff8ff10000)
            /lib/ld-linux-aarch64.so.1 (0x0000ffff9028e000)

aiuto avatar Dec 03 '25 14:12 aiuto

/merge

aiuto avatar Dec 03 '25 15:12 aiuto

View all feedbacks in Devflow UI.

2025-12-03 15:36:10 UTC :information_source: Start processing command /merge


2025-12-03 15:36:18 UTC :information_source: MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.


2025-12-03 19:37:04 UTC :warning: MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

Static quality checks

✅ Please find below the results from static quality gates Comparison made with ancestor 5f8f6df6396adf5c15e0b329a4a7e10022cb3aa8

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${0}$$ $${705.47}$$ < $${706.32}$$ $${-0.02}$$ $${172.84}$$ < $${173.81}$$
agent_deb_amd64_fips $${0}$$ $${700.8}$$ < $${701.16}$$ $${+0.09}$$ $${171.9}$$ < $${172.71}$$
agent_heroku_amd64 $${-0}$$ $${327.27}$$ < $${327.69}$$ $${+0}$$ $${87.23}$$ < $${88.19}$$
agent_msi $${+0.7}$$ $${569.56}$$ < $${982.08}$$ $${+0.24}$$ $${142.01}$$ < $${143.01}$$
agent_rpm_amd64 $${0}$$ $${705.46}$$ < $${706.31}$$ $${+0.03}$$ $${175.9}$$ < $${176.86}$$
agent_rpm_amd64_fips $${0}$$ $${700.79}$$ < $${701.15}$$ $${-0}$$ $${173.98}$$ < $${174.95}$$
agent_rpm_arm64 $${0}$$ $${691.16}$$ < $${691.67}$$ $${+0.02}$$ $${159.73}$$ < $${160.7}$$
agent_rpm_arm64_fips $${0}$$ $${687.37}$$ < $${687.54}$$ $${-0.02}$$ $${159.03}$$ < $${160.1}$$
agent_suse_amd64 $${0}$$ $${705.46}$$ < $${706.31}$$ $${+0.03}$$ $${175.9}$$ < $${176.86}$$
agent_suse_amd64_fips $${0}$$ $${700.79}$$ < $${701.15}$$ $${-0}$$ $${173.98}$$ < $${174.95}$$
agent_suse_arm64 $${0}$$ $${691.16}$$ < $${691.67}$$ $${+0.02}$$ $${159.73}$$ < $${160.7}$$
agent_suse_arm64_fips $${0}$$ $${687.37}$$ < $${687.54}$$ $${-0.02}$$ $${159.03}$$ < $${160.1}$$
docker_agent_amd64 $${-0}$$ $${767.8}$$ < $${768.66}$$ $${+0.01}$$ $${260.63}$$ < $${261.52}$$
docker_agent_arm64 $${+0}$$ $${777.78}$$ < $${778.35}$$ $${+0}$$ $${250.8}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${-0}$$ $${958.68}$$ < $${959.54}$$ $${-0}$$ $${329.26}$$ < $${330.15}$$
docker_agent_jmx_arm64 $${-0}$$ $${957.37}$$ < $${957.95}$$ $${-0}$$ $${315.42}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${+0}$$ $${179.11}$$ < $${179.28}$$ $${+0}$$ $${63.24}$$ < $${63.96}$$
docker_cluster_agent_arm64 $${-0}$$ $${196.58}$$ < $${196.79}$$ $${-0.01}$$ $${59.96}$$ < $${60.69}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.71}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${-0}$$ $${38.67}$$ < $${39.3}$$ $${+0}$$ $${14.94}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${+0.06}$$ $${37.36}$$ < $${37.94}$$ $${+0}$$ $${14.38}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.89}$$ < $${30.53}$$ $${+0}$$ $${7.88}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.4}$$ < $${29.11}$$ $${+0}$$ $${6.82}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.89}$$ < $${30.53}$$ $${+0}$$ $${7.89}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.89}$$ < $${30.53}$$ $${+0}$$ $${7.89}$$ < $${8.76}$$
iot_agent_deb_amd64 $${0}$$ $${42.62}$$ < $${43.19}$$ $${+0}$$ $${11.13}$$ < $${11.98}$$
iot_agent_deb_arm64 $${0}$$ $${40.36}$$ < $${40.92}$$ $${+0}$$ $${9.58}$$ < $${10.45}$$
iot_agent_deb_armhf $${0}$$ $${40.26}$$ < $${40.86}$$ $${-0}$$ $${9.7}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${0}$$ $${42.62}$$ < $${43.19}$$ $${-0}$$ $${11.14}$$ < $${12.0}$$
iot_agent_suse_amd64 $${0}$$ $${42.62}$$ < $${43.19}$$ $${-0}$$ $${11.14}$$ < $${12.0}$$

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ba548491-b608-4ed6-87e6-5459ff01ff15

Baseline: 8e280fbdc05a23dc073f7526d8388d5d3ab1a5c6 Comparison: ba72b0212512305752206b9ef176256f1b381d93 Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -3.62 [-6.59, -0.65] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
ddot_metrics memory utilization +1.01 [+0.78, +1.24] 1 Logs
ddot_metrics_sum_delta memory utilization +0.44 [+0.22, +0.65] 1 Logs
otlp_ingest_metrics memory utilization +0.28 [+0.13, +0.44] 1 Logs
docker_containers_memory memory utilization +0.22 [+0.15, +0.30] 1 Logs
ddot_logs memory utilization +0.16 [+0.09, +0.23] 1 Logs
file_tree memory utilization +0.14 [+0.07, +0.21] 1 Logs
otlp_ingest_logs memory utilization +0.08 [-0.02, +0.17] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.06 [-0.02, +0.14] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.05 [+0.00, +0.10] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.34, +0.40] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.12, +0.15] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.12, +0.14] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.00 [-0.17, +0.17] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.09, +0.08] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.01 [-0.42, +0.40] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.42, +0.36] 1 Logs
quality_gate_logs % cpu utilization -0.03 [-1.51, +1.44] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.06 [-0.28, +0.17] 1 Logs
quality_gate_idle_all_features memory utilization -0.15 [-0.18, -0.11] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.19 [-0.23, -0.15] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.27 [-0.33, -0.22] 1 Logs
quality_gate_metrics_logs memory utilization -0.75 [-0.98, -0.53] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -3.62 [-6.59, -0.65] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

cit-pr-commenter[bot] avatar Dec 03 '25 15:12 cit-pr-commenter[bot]

/merge

aiuto avatar Dec 05 '25 05:12 aiuto

View all feedbacks in Devflow UI.

2025-12-05 05:38:22 UTC :information_source: Start processing command /merge


2025-12-05 05:38:30 UTC :information_source: MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.


2025-12-05 09:39:12 UTC :warning: MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

/merge

aiuto avatar Dec 16 '25 17:12 aiuto

View all feedbacks in Devflow UI.

2025-12-16 17:01:24 UTC :information_source: Start processing command /merge


2025-12-16 17:01:30 UTC :information_source: MergeQueue: pull request added to the queue

The expected merge time in main is approximately 49m (p90).


2025-12-16 18:18:11 UTC :information_source: MergeQueue: This merge request was merged