David ioinovitch/ntp ad discovery

[davidioin]

What does this PR do?

Motivation

https://datadoghq.atlassian.net/browse/WINA-1549

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

[bits-bot]

All committers have signed the CLA.

[agent-platform-auto-pr[bot]]

Uncompressed package size comparison

Comparison with ancestor 1659f34aec245fcf1dd51e4da2f864d051f5942d

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-x86_64-rpm	0.01MB	⚠️	784.05MB	784.04MB	0.50MB
datadog-agent-x86_64-suse	0.01MB	⚠️	784.05MB	784.04MB	0.50MB
datadog-agent-amd64-deb	0.01MB	⚠️	775.10MB	775.09MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	61.06MB	61.06MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	61.14MB	61.14MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	61.14MB	61.14MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	58.31MB	58.31MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	58.40MB	58.39MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	764.40MB	764.40MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	773.33MB	773.33MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	31.22MB	31.22MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	31.30MB	31.30MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	31.30MB	31.30MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	30.04MB	30.04MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	378.71MB	378.71MB	0.50MB

Decision

⚠️ Warning

[cit-pr-commenter[bot]]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 5bda1eb4-bf97-4ec7-afb8-8c2be7eeef34

Baseline: 57f58d32e59cd62a2fbfdcab6f8d8da2b9bcc993 Comparison: 5ea4b87d803e50b2a4ae1d84dd128b901215f831 Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.83	[-0.96, +4.63]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.74	[+0.89, +2.58]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.72	[+0.64, +0.80]	1	Logs
➖	docker_containers_cpu	% cpu utilization	+0.61	[-2.40, +3.63]	1	Logs
➖	file_tree	memory utilization	+0.41	[+0.32, +0.50]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.30	[+0.14, +0.45]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.11	[-0.01, +0.24]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.06	[-0.50, +0.62]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.04	[-0.61, +0.69]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.03	[-0.60, +0.65]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.00	[-0.24, +0.24]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.02, +0.02]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.01	[-0.57, +0.56]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.28, +0.26]	1	Logs
➖	ddot_metrics	memory utilization	-0.03	[-0.15, +0.09]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.05	[-0.70, +0.59]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.05	[-0.60, +0.50]	1	Logs
➖	quality_gate_idle	memory utilization	-0.06	[-0.18, +0.05]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.07	[-0.12, -0.02]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.09	[-0.68, +0.50]	1	Logs
➖	docker_containers_memory	memory utilization	-0.13	[-0.21, -0.05]	1	Logs
➖	ddot_logs	memory utilization	-0.14	[-0.23, -0.05]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.60	[-0.65, -0.55]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[agent-platform-auto-pr[bot]]

Static quality checks

✅ Please find below the results from static quality gates Comparison made with ancestor 57f58d32e59cd62a2fbfdcab6f8d8da2b9bcc993

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${+0}$$	$${700.52}$$ < $${700.55}$$	$${+0.03}$$	$${176.71}$$ < $${177.62}$$
✅	agent_deb_amd64_fips	$${+0}$$	$${698.78}$$ < $${699.75}$$	$${-0}$$	$${176.14}$$ < $${177.04}$$
✅	agent_heroku_amd64	$${-0}$$	$${352.25}$$ < $${362.84}$$	$${+0}$$	$${95.1}$$ < $${98.91}$$
✅	agent_msi	$${+0.02}$$	$${973.24}$$ < $${973.9}$$	$${0}$$	$${147.09}$$ < $${148.11}$$
✅	agent_rpm_amd64	$${+0}$$	$${700.51}$$ < $${700.53}$$	$${-0.01}$$	$${178.34}$$ < $${179.2}$$
✅	agent_rpm_amd64_fips	$${+0}$$	$${698.77}$$ < $${699.74}$$	$${-0.01}$$	$${177.88}$$ < $${178.75}$$
✅	agent_rpm_arm64	$${-0}$$	$${690.41}$$ < $${690.5}$$	$${+0}$$	$${161.75}$$ < $${162.56}$$
✅	agent_rpm_arm64_fips	$${-0}$$	$${688.79}$$ < $${689.8}$$	$${+0}$$	$${160.84}$$ < $${161.61}$$
✅	agent_suse_amd64	$${+0}$$	$${700.51}$$ < $${700.54}$$	$${-0.01}$$	$${178.34}$$ < $${179.2}$$
✅	agent_suse_amd64_fips	$${+0}$$	$${698.77}$$ < $${699.74}$$	$${-0.01}$$	$${177.88}$$ < $${178.93}$$
✅	agent_suse_arm64	$${-0}$$	$${690.41}$$ < $${690.43}$$	$${+0}$$	$${161.75}$$ < $${162.57}$$
✅	agent_suse_arm64_fips	$${-0}$$	$${688.79}$$ < $${689.78}$$	$${+0}$$	$${160.84}$$ < $${161.61}$$
✅	docker_agent_amd64	$${+0}$$	$${784.32}$$ < $${784.33}$$	$${+0}$$	$${269.78}$$ < $${270.56}$$
✅	docker_agent_arm64	$${-0}$$	$${797.67}$$ < $${797.68}$$	$${+0.02}$$	$${257.06}$$ < $${257.84}$$
✅	docker_agent_jmx_amd64	$${+0}$$	$${975.51}$$ < $${975.52}$$	$${+0}$$	$${338.75}$$ < $${339.53}$$
✅	docker_agent_jmx_arm64	$${-0}$$	$${977.46}$$ < $${977.47}$$	$${-0}$$	$${321.99}$$ < $${322.81}$$
✅	docker_agent_windows1809	$${+2.29}$$	$${1184.66}$$ < $${1190.0}$$	$${+0.41}$$	$${417.37}$$ < $${422.66}$$
✅	docker_agent_windows1809_core	$${+0}$$	$${5914.81}$$ < $${5919.41}$$	$${0}$$	$${2048.0}$$ < $${2049.0}$$
✅	docker_agent_windows1809_core_jmx	$${+0.01}$$	$${6036.38}$$ < $${6063.56}$$	$${0}$$	$${2048.0}$$ < $${2049.0}$$
✅	docker_agent_windows1809_jmx	$${+0}$$	$${1306.48}$$ < $${1311.1}$$	$${+0.03}$$	$${459.65}$$ < $${464.35}$$
✅	docker_agent_windows2022	$${+0.08}$$	$${1204.15}$$ < $${1208.75}$$	$${+0.05}$$	$${430.11}$$ < $${434.91}$$
✅	docker_agent_windows2022_core	$${+0.11}$$	$${5887.87}$$ < $${5892.66}$$	$${0}$$	$${2048.0}$$ < $${2049.0}$$
✅	docker_agent_windows2022_core_jmx	$${+0.01}$$	$${6009.52}$$ < $${6014.08}$$	$${0}$$	$${2048.0}$$ < $${2049.0}$$
✅	docker_agent_windows2022_jmx	$${+0.14}$$	$${1325.87}$$ < $${1330.39}$$	$${+0.01}$$	$${472.36}$$ < $${477.17}$$
✅	docker_cluster_agent_amd64	$${-0}$$	$${213.62}$$ < $${214.5}$$	$${+0}$$	$${72.6}$$ < $${73.51}$$
✅	docker_cluster_agent_arm64	$${-0}$$	$${229.45}$$ < $${230.33}$$	$${-0.01}$$	$${68.85}$$ < $${69.77}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.08}$$ < $${7.12}$$	$${-0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${-0}$$	$${39.23}$$ < $${39.57}$$	$${+0}$$	$${15.12}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.88}$$ < $${38.2}$$	$${+0}$$	$${14.53}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${30.46}$$ < $${31.4}$$	$${-0}$$	$${8.0}$$ < $${8.95}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${29.03}$$ < $${29.97}$$	$${+0}$$	$${6.94}$$ < $${7.89}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${30.46}$$ < $${31.4}$$	$${-0}$$	$${8.01}$$ < $${8.96}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${30.46}$$ < $${31.4}$$	$${-0}$$	$${8.01}$$ < $${8.96}$$
✅	iot_agent_deb_amd64	$${0}$$	$${53.66}$$ < $${54.55}$$	$${+0}$$	$${13.52}$$ < $${14.45}$$
✅	iot_agent_deb_arm64	$${0}$$	$${51.01}$$ < $${51.9}$$	$${+0}$$	$${11.7}$$ < $${12.63}$$
✅	iot_agent_deb_armhf	$${0}$$	$${50.52}$$ < $${51.42}$$	$${-0}$$	$${11.79}$$ < $${12.74}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${53.66}$$ < $${54.55}$$	$${+0}$$	$${13.54}$$ < $${14.47}$$
✅	iot_agent_rpm_arm64	$${0}$$	$${51.01}$$ < $${51.91}$$	$${-0}$$	$${11.71}$$ < $${12.65}$$
✅	iot_agent_suse_amd64	$${0}$$	$${53.66}$$ < $${54.55}$$	$${+0}$$	$${13.54}$$ < $${14.47}$$