datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[NPM-3663] Include BTF availability in agent flare

Open pimlu opened this issue 1 year ago • 1 comments

What does this PR do?

This PR adds information about where we are loading BTF information from to the agent flare.

Motivation

This can tell us why CO-RE is running into issues, and particularly with our bundled BTF files, if we are correctly identifying the distro + kernel.

Describe how to test/QA your changes

TBD

Possible Drawbacks / Trade-offs

Additional Notes

pimlu avatar Oct 23 '24 21:10 pimlu

Regression Detector

Regression Detector Results

Run ID: 0e175603-bcfa-4103-a8fc-6504b6886feb Metrics dashboard Target profiles

Baseline: 2f80c774f49f0164d3f03194a43741122d1961f2 Comparison: cf5c3b3956e2d73e1b8d533ccf90dca0a7dee598

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
idle memory utilization +0.13 [+0.08, +0.17] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.11 [-0.14, +0.35] 1 Logs
quality_gate_idle memory utilization +0.06 [+0.02, +0.11] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.06 [-0.07, +0.18] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput +0.03 [-0.77, +0.84] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.21, +0.24] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.33, +0.36] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.18, +0.18] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.09, +0.09] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.53, +0.44] 1 Logs
basic_py_check % cpu utilization -0.09 [-2.82, +2.65] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.11 [-0.83, +0.61] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.45 [-0.50, -0.40] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.47 [-2.98, +2.04] 1 Logs
idle_all_features memory utilization -1.37 [-1.50, -1.25] 1 Logs bounds checks dashboard
file_tree memory utilization -2.56 [-2.70, -2.41] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10
idle_all_features memory_usage 10/10
quality_gate_idle memory_usage 10/10
quality_gate_idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

cit-pr-commenter[bot] avatar Oct 23 '24 23:10 cit-pr-commenter[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=47989284 --os-family=ubuntu

Note: This applies to commit cf5c3b39

needs a release note (I think this is a good example of a time to include one)

akarpz avatar Oct 24 '24 14:10 akarpz

/merge

pimlu avatar Oct 31 '24 17:10 pimlu

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 24m.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Oct 31 '24 17:10 dd-devflow[bot]

/remove

pimlu avatar Oct 31 '24 17:10 pimlu

:steam_locomotive: Devflow: /remove

dd-devflow[bot] avatar Oct 31 '24 17:10 dd-devflow[bot]

:warning: MergeQueue: This merge request build was cancelled

This merge request build was cancelled

If you need support, contact us on Slack #devflow!

dd-devflow[bot] avatar Oct 31 '24 17:10 dd-devflow[bot]

/merge

pimlu avatar Oct 31 '24 18:10 pimlu

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Oct 31 '24 18:10 dd-devflow[bot]