datadog-agent
datadog-agent copied to clipboard
[Backport 7.58.x] [NTWK-562] Add test for packet capture info
Backport c32be6aa23418c5fbad364a42b5be4aa187242ff from #30427.
What does this PR do?
Adds tests to #30396 to make sure it doesn't panic, and tests the pktType logic
Motivation
Describe how to test/QA your changes
sudo -E go test -tags=linux,linux_bpf,npm,process,test ./pkg/network/filter -v
Possible Drawbacks / Trade-offs
Additional Notes
[Fast Unit Tests Report]
On pipeline 47282312 (CI Visibility). The following jobs did not run any unit tests:
Jobs:
- tests_windows-x64
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help
Test changes on VM
Use this command from test-infra-definitions to manually test this PR changes on a VM:
inv create-vm --pipeline-id=47282312 --os-family=ubuntu
Note: This applies to commit 9f6fef82
Regression Detector
Regression Detector Results
Run ID: e71ea0e9-9a69-4af6-89c9-78d641962130 Metrics dashboard Target profiles
Baseline: 68cc2141fe19caa2917b82feda1333357d466f97 Comparison: 9f6fef82ae5219845435eb57f9025e79f38016ea
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.54 | [+0.79, +2.29] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.32 | [+0.21, +0.44] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.26 | [+0.21, +0.31] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.21 | [-0.63, +1.05] | 1 | Logs |
| ➖ | idle | memory utilization | +0.15 | [+0.09, +0.21] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | pycheck_lots_of_tags | % cpu utilization | -0.01 | [-2.61, +2.59] | 1 | Logs |
| ➖ | basic_py_check | % cpu utilization | -0.21 | [-3.05, +2.63] | 1 | Logs |
Bounds Checks
| perf | experiment | bounds_check_name | replicates_passed |
|---|---|---|---|
| ❌ | idle | memory_usage | 9/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue: pull request added to the queue
The median merge time in 7.58.x is 40m.
Use /merge -c to cancel this operation!