datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[ASCII-2336] Build the Default source tree once config is Ready for usage

Open dustmop opened this issue 1 year ago • 2 comments

What does this PR do?

Build the default source of the config model by inserting all keys from BindEnv, SetKnown and SetDefault. Insert values from SetDefault during this process. Once the config is built, these three methods should not be called again.

Motivation

Removing our dependency on viper.

Describe how to test/QA your changes

Run with envvar DD_CONF_NODETREEMODEL=enable. Config will be built, but the agent won't sucessfully run, as this feature is a work in progress.

Possible Drawbacks / Trade-offs

Additional Notes

dustmop avatar Oct 21 '24 21:10 dustmop

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=47850102 --os-family=ubuntu

Note: This applies to commit 4850adac

Regression Detector

Regression Detector Results

Run ID: 1e40e764-1644-4a68-9efb-dc0c7690d1d9 Metrics dashboard Target profiles

Baseline: 71ac8ec8368cceccee531444d8b0b42e7c132881 Comparison: 4850adac77aa38a03f7b72da03281ab47a4ea0e3

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +0.98 [-1.90, +3.87] 1 Logs
idle_all_features memory utilization +0.90 [+0.80, +1.00] 1 Logs bounds checks dashboard
idle memory utilization +0.78 [+0.73, +0.84] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.47 [+0.37, +0.56] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.06 [-0.11, +0.24] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.03 [-0.46, +0.51] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.33, +0.35] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.11] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.11 [-0.36, +0.13] 1 Logs
quality_gate_idle memory utilization -0.21 [-0.26, -0.17] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput -0.24 [-1.04, +0.55] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.25 [-0.47, -0.02] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.30 [-1.01, +0.42] 1 Logs
quality_gate_idle_all_features memory utilization -0.97 [-1.09, -0.86] 1 Logs bounds checks dashboard
file_tree memory utilization -1.16 [-1.29, -1.02] 1 Logs
pycheck_lots_of_tags % cpu utilization -1.32 [-3.93, +1.28] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10
idle_all_features memory_usage 10/10
quality_gate_idle memory_usage 10/10
quality_gate_idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

cit-pr-commenter[bot] avatar Oct 21 '24 22:10 cit-pr-commenter[bot]

Pushed some commits that handle the additional error tracking and rename of SetReady to BuildSchema. I think the other comments will require larger changes which will come in a future PR.

dustmop avatar Oct 29 '24 16:10 dustmop

/merge

dustmop avatar Oct 30 '24 15:10 dustmop

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Oct 30 '24 15:10 dd-devflow[bot]