Add Error Tracking Standalone Config option
What does this PR do?
This PR adds ErrorTrackingStandalone config option as a boolean. When set to true, all samplers but the error sampler are bypassed. Only chunks that contain an error span or a span with exception span events are run through the error sampler. Kept spans are specifically tagged.
Motivation
We want to offer users the opportunity to have Error Tracking Standalone, i.e. a way to gather backend errors with lower cost than buying APM - but with upsell in mind. ETBS only relies on chunks that contain errors, so only the error sampler should be run.
https://datadoghq.atlassian.net/browse/ERRORT-4747
Test changes on VM
Use this command from test-infra-definitions to manually test this PR changes on a VM:
inv create-vm --pipeline-id=50045549 --os-family=ubuntu
Note: This applies to commit 217b2012
Regression Detector
Regression Detector Results
Metrics dashboard
Target profiles
Run ID: 39cb3475-fd7d-42be-a11b-a93bf47b26c8
Baseline: fb2da089191f8ae523150f719551c44f98358061 Comparison: 217b2012641e2facb5291654ed2d48351a6a7d4a Diff
Optimization Goals: ✅ No significant changes detected
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | pycheck_lots_of_tags | % cpu utilization | +2.78 | [-0.76, +6.31] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.16 | [-0.62, +0.93] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.05 | [-0.41, +0.51] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.73, +0.75] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.00 | [-0.78, +0.79] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.10, +0.11] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.02 | [-0.81, +0.76] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.03 | [-0.66, +0.60] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | -0.15 | [-0.84, +0.54] | 1 | Logs |
| ➖ | basic_py_check | % cpu utilization | -0.34 | [-4.20, +3.52] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.45 | [-0.50, -0.39] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.86 | [-1.59, -0.13] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.95 | [-1.02, -0.88] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle_all_features | memory utilization | -1.05 | [-1.20, -0.91] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | -1.28 | [-1.40, -1.17] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
/merge
Devflow running: /merge
View all feedbacks in Devflow UI.
2024-11-27 08:13:42 UTC :information_source: MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
2024-11-27 09:25:49 UTC :information_source: MergeQueue: merge request added to the queue
The median merge time in main is 23m.