datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[APR-210] Zstd logs with added telemetry

Open StephenWakely opened this issue 1 year ago • 3 comments

APR-210

A branch of #27149 to do some benchmarking with.

I have added extra telemetry and added an option to compress using a native golang zstd library.

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

StephenWakely avatar Oct 07 '24 12:10 StephenWakely

Go Package Import Differences

Baseline: 7b0d65fc81fa0eb4fc8fa89bf028626ed8c68e39 Comparison: cf1eefb6c393b96403b2dd59ad625735e2f45126

binaryosarchchange
process-agentlinuxamd64
+2, -0
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl/strategy
process-agentlinuxarm64
+2, -0
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl/strategy
process-agentwindowsamd64
+2, -0
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl/strategy
process-agentdarwinamd64
+9, -0
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl/strategy
+github.com/klauspost/compress
+github.com/klauspost/compress/fse
+github.com/klauspost/compress/huff0
+github.com/klauspost/compress/internal/cpuinfo
+github.com/klauspost/compress/internal/snapref
+github.com/klauspost/compress/zstd
+github.com/klauspost/compress/zstd/internal/xxhash
process-agentdarwinarm64
+8, -0
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl/strategy
+github.com/klauspost/compress
+github.com/klauspost/compress/fse
+github.com/klauspost/compress/huff0
+github.com/klauspost/compress/internal/snapref
+github.com/klauspost/compress/zstd
+github.com/klauspost/compress/zstd/internal/xxhash
heroku-process-agentlinuxamd64
+2, -0
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl/strategy
system-probelinuxamd64
+2, -0
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl/strategy
system-probelinuxarm64
+2, -0
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl/strategy
system-probewindowsamd64
+9, -0
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl
+github.com/DataDog/datadog-agent/comp/serializer/compression/compressionimpl/strategy
+github.com/klauspost/compress
+github.com/klauspost/compress/fse
+github.com/klauspost/compress/huff0
+github.com/klauspost/compress/internal/cpuinfo
+github.com/klauspost/compress/internal/snapref
+github.com/klauspost/compress/zstd
+github.com/klauspost/compress/zstd/internal/xxhash

cit-pr-commenter[bot] avatar Oct 07 '24 13:10 cit-pr-commenter[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=46064209 --os-family=ubuntu

Note: This applies to commit f4fead7d

pr-commenter[bot] avatar Oct 08 '24 14:10 pr-commenter[bot]

Regression Detector

pr-commenter[bot] avatar Oct 08 '24 14:10 pr-commenter[bot]