Fix bugs introduced in KMT

[usamasaqib]

What does this PR do?

This PR fixes two issues in KMT:

1. https://github.com/DataDog/datadog-agent/pull/29338 introduced an invalid check, and lacked support for working with VMs, where the ssh key is not owned by the root user in the target VM.
2. kmt.build task did not copy over cross-arch clang-bpf and llc-bpf, causing runtime compilation to fail.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[agent-platform-auto-pr[bot]]

[Fast Unit Tests Report]

On pipeline 44549452 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: 6e12b5fd-6ab7-40c4-99c6-ed2b03fecc77 Metrics dashboard Target profiles

Baseline: 023ef5945eaed5aea081f20a7788a68c0107f816 Comparison: 6628631619356c76bd40048e8455b1dba3b75653

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	file_tree	memory utilization	+0.92	[+0.81, +1.03]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.64	[+0.56, +0.72]	1	Logs
➖	otel_to_otel_logs	ingress throughput	+0.55	[-0.28, +1.38]	1	Logs
➖	pycheck_lots_of_tags	% cpu utilization	+0.15	[-2.54, +2.84]	1	Logs
➖	idle	memory utilization	+0.04	[+0.00, +0.08]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.00, +0.00]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.10	[-1.86, -0.35]	1	Logs
➖	basic_py_check	% cpu utilization	-2.69	[-5.56, +0.19]	1	Logs

Bounds Checks

perf	experiment	bounds_check_name	replicates_passed
❌	idle	memory_usage	8/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[usamasaqib]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!