datadog-agent
datadog-agent copied to clipboard
discovery: add config option for cpu usage update delay
What does this PR do?
Adds a configuration option to service discovery to control the minimum delay between CPU usage updates. This prevents things like manually checking the discovery endpoint from breaking the CPU usage values the main agent will get. By default, it is set to one minute, since this is how frequent the main agent will poll the endpoint.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Test changes on VM
Use this command from test-infra-definitions to manually test this PR changes on a VM:
inv create-vm --pipeline-id=45689757 --os-family=ubuntu
Note: This applies to commit d0e2e2c3
Regression Detector
Regression Detector Results
Run ID: 3dd95a21-feb3-4e96-a3db-d344158dcfbd Metrics dashboard Target profiles
Baseline: bddd1fbe6f4985774dae04b78419a7b24eae2fd4 Comparison: d0e2e2c318f9cb50f6847d1cc3521bd45635b961
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | pycheck_lots_of_tags | % cpu utilization | +1.25 | [-1.24, +3.73] | 1 | Logs |
| ➖ | idle_all_features | memory utilization | +1.05 | [+0.97, +1.13] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.97 | [+0.16, +1.78] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.94 | [+0.89, +0.99] | 1 | Logs |
| ➖ | idle | memory utilization | +0.13 | [+0.09, +0.18] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.12, +0.10] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.14 | [-0.87, +0.59] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.23 | [-0.34, -0.12] | 1 | Logs |
| ➖ | basic_py_check | % cpu utilization | -0.25 | [-2.87, +2.36] | 1 | Logs |
Bounds Checks
| perf | experiment | bounds_check_name | replicates_passed |
|---|---|---|---|
| ✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue: pull request added to the queue
The median merge time in main is 25m.
Use /merge -c to cancel this operation!