datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[ASCII-2294] Add suffix to fstype to avoid using a real type

Open pgimalac opened this issue 1 year ago • 2 comments

What does this PR do?

Fixes a flake in the TestNixFSTypeFiltering test. The test uses randomly generated strings to generate test cases, and it failed due to a random filesystem type unexpectedly being one of the ignored types. This PR adds a suffix to the generated type to avoid collision.

Motivation

Not have the test flake.

Additional Notes

The test was added 13 months ago and failed for the first time now, so pretty unlikely failure.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

pgimalac avatar Sep 16 '24 16:09 pgimalac

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=44433255 --os-family=ubuntu

Note: This applies to commit 156084f6

pr-commenter[bot] avatar Sep 16 '24 17:09 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: fc21e4c1-cd68-4a6e-8958-ca95236130f4 Metrics dashboard Target profiles

Baseline: ceffe2661b47a677e68bee64de606c28ea4dc252 Comparison: 156084f6ee3143c4f784d7fd48fc487e3a8f7206

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.69 [+0.92, +2.46] 1 Logs
idle memory utilization +0.62 [+0.58, +0.66] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.53 [+0.47, +0.58] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
otel_to_otel_logs ingress throughput -0.14 [-0.97, +0.70] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.43 [-3.08, +2.22] 1 Logs
file_tree memory utilization -0.53 [-0.64, -0.42] 1 Logs
basic_py_check % cpu utilization -1.59 [-4.40, +1.21] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 4/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Sep 16 '24 17:09 pr-commenter[bot]

/merge

pgimalac avatar Sep 18 '24 12:09 pgimalac

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Sep 18 '24 12:09 dd-devflow[bot]