datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CWS] remove any fx usage from CWS functional tests

Open paulcacheux opened this issue 1 year ago • 2 comments

What does this PR do?

Using fx in CWS functional tests has proven to be a difficult task because of the fundamental incompatibility between:

  • the way fx tests are setup in the agent, with a strict lifecycle linked to a test lifetime -> components will be stopped at the end of the tests
  • the fact that we reuse the same test module across tests in CWS func tests This means that we might use a component after it has been stopped, this mainly was causing issues with the logger.

Happily CWS tests were not really using the components, so replacing them by nil is enough.

The first commit of this PR also removes the need for the workloadmeta in the SBOM resolver (replacing it by a None option, which is enough).

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

paulcacheux avatar Sep 14 '24 17:09 paulcacheux

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=44418408 --os-family=ubuntu

Note: This applies to commit 995ee948

pr-commenter[bot] avatar Sep 14 '24 20:09 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 50bf69bf-e264-43af-8967-37d7c042fb14 Metrics dashboard Target profiles

Baseline: 10d974e4d2761fa3f52fc5515bf6b82c94e0f85e Comparison: 4a1bf70f82f43a91265d253a6ddf65239789d231

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +1.08 [-1.64, +3.81] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.57 [+0.52, +0.62] 1 Logs
file_tree memory utilization +0.37 [+0.26, +0.47] 1 Logs
idle memory utilization +0.36 [+0.32, +0.40] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.01 [-0.75, +0.78] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.01, +0.01] 1 Logs
basic_py_check % cpu utilization -0.43 [-3.32, +2.47] 1 Logs
otel_to_otel_logs ingress throughput -0.54 [-1.36, +0.28] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Sep 14 '24 21:09 pr-commenter[bot]

/merge

paulcacheux avatar Sep 16 '24 14:09 paulcacheux

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Sep 16 '24 14:09 dd-devflow[bot]

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Sep 16 '24 15:09 dd-devflow[bot]