datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

use tracepoints for TCP failures

Open akarpz opened this issue 1 year ago • 1 comments

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

akarpz avatar Sep 13 '24 16:09 akarpz

[Fast Unit Tests Report]

On pipeline 45454601 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Regression Detector

Regression Detector Results

Run ID: d389786c-7838-4d64-8b83-555ce1689293 Metrics dashboard Target profiles

Baseline: 40b773cc038a143f4181472d357c30877e335963 Comparison: bdbf347a19c6fe4f4c8441c3ba0df76d3528a4c2

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otel_to_otel_logs ingress throughput +0.97 [+0.14, +1.80] 1 Logs
pycheck_lots_of_tags % cpu utilization +0.89 [-1.67, +3.45] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.39 [+0.34, +0.44] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.04, +0.03] 1 Logs
idle memory utilization -0.14 [-0.20, -0.08] 1 Logs
basic_py_check % cpu utilization -0.54 [-3.40, +2.32] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.65 [-1.40, +0.09] 1 Logs
file_tree memory utilization -0.74 [-0.86, -0.61] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Sep 30 '24 14:09 pr-commenter[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=45454601 --os-family=ubuntu

Note: This applies to commit bdbf347a

pr-commenter[bot] avatar Sep 30 '24 19:09 pr-commenter[bot]