datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CWS-3070] Allow rules to override kill disarmers

Open YoannGh opened this issue 1 year ago • 2 comments

What does this PR do?

Allows disarmer parameters set on specific rules to take precedence over the ones set from the configuration.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

YoannGh avatar Sep 13 '24 16:09 YoannGh

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=45692894 --os-family=ubuntu

Note: This applies to commit 36ce0ff1

pr-commenter[bot] avatar Sep 13 '24 16:09 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 9704bb4c-9daa-4197-a350-ff16108ad101 Metrics dashboard Target profiles

Baseline: faea2cd07b40ae55014b76619f733ff5c3f7350c Comparison: 36ce0ff1b08b840724bbfd77ea63ab0c89844006

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +1.39 [-1.37, +4.14] 1 Logs
otel_to_otel_logs ingress throughput +0.33 [-0.47, +1.14] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.04 [-0.68, +0.77] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.11, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
idle_all_features memory utilization -0.14 [-0.24, -0.05] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.32 [-0.38, -0.27] 1 Logs
idle memory utilization -0.69 [-0.74, -0.64] 1 Logs
file_tree memory utilization -2.44 [-2.55, -2.32] 1 Logs
pycheck_lots_of_tags % cpu utilization -2.55 [-4.99, -0.12] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Sep 13 '24 17:09 pr-commenter[bot]

@YoannGh Could you please rebase ? Thanks !

lebauce avatar Oct 03 '24 09:10 lebauce

/merge

YoannGh avatar Oct 03 '24 11:10 YoannGh

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Oct 03 '24 11:10 dd-devflow[bot]