datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

Send Host Tags in first 20 minutes

Open ewoodthomas opened this issue 1 year ago • 4 comments

What does this PR do?

Motivation

https://datadoghq.atlassian.net/browse/CONTINT-4435

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

ewoodthomas avatar Sep 13 '24 16:09 ewoodthomas

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

ewoodthomas avatar Sep 13 '24 17:09 ewoodthomas

:steam_locomotive: Gitlab pipeline started

Started pipeline #44311127

dd-devflow[bot] avatar Sep 13 '24 17:09 dd-devflow[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=45155440 --os-family=ubuntu

Note: This applies to commit 8558e59a

pr-commenter[bot] avatar Sep 13 '24 17:09 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 7b2ba28f-3dd7-400a-9346-8d589b41c785 Metrics dashboard Target profiles

Baseline: f340f9a4754140874b15ee8f903e64549c4860cd Comparison: 033611f289d7c41ac4c8b9b93bb3a969e3acccfa

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +1.36 [-1.25, +3.96] 1 Logs
basic_py_check % cpu utilization +1.15 [-1.72, +4.01] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.74 [-0.03, +1.50] 1 Logs
file_tree memory utilization +0.01 [-0.11, +0.13] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.03, +0.04] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
idle memory utilization -0.16 [-0.20, -0.11] 1 Logs
otel_to_otel_logs ingress throughput -0.20 [-1.02, +0.63] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.72 [-0.78, -0.66] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 8/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Sep 13 '24 17:09 pr-commenter[bot]