datadog-agent
datadog-agent copied to clipboard
[CONS-6540] Better look for image name in podman DB
What does this PR do?
Motivation
Fix cases where the agent couldn’t find the container image name with podman.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Test changes on VM
Use this command from test-infra-definitions to manually test this PR changes on a VM:
inv create-vm --pipeline-id=44290790 --os-family=ubuntu
Note: This applies to commit 96c66cc9
Regression Detector
Regression Detector Results
Run ID: 92166751-4519-4d85-b422-4a9dfd67d295 Metrics dashboard Target profiles
Baseline: b6502beceb03e9355ef1b6957d4e29a15f83bd65 Comparison: 96c66cc9d0f40519c25af193f45f756906ee1689
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.40 | [+0.34, +0.45] | 1 | Logs |
| ➖ | pycheck_lots_of_tags | % cpu utilization | +0.18 | [-2.49, +2.85] | 1 | Logs |
| ➖ | idle | memory utilization | +0.08 | [+0.03, +0.12] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.01 | [-0.12, +0.11] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.81 | [-1.58, -0.05] | 1 | Logs |
| ➖ | basic_py_check | % cpu utilization | -1.30 | [-4.09, +1.50] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | -1.36 | [-2.19, -0.54] | 1 | Logs |
Bounds Checks
| perf | experiment | bounds_check_name | replicates_passed |
|---|---|---|---|
| ❌ | idle | memory_usage | 7/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue: pull request added to the queue
The median merge time in main is 26m.
Use /merge -c to cancel this operation!