datadog-agent
datadog-agent copied to clipboard
DataDog
usm: Move SoWatcher tests to FileRegistry
What does this PR do?
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Regression Detector
Regression Detector Results
Metrics dashboard
Target profiles
Run ID: 384348b6-06b8-4fe7-875c-ca5250f488c9
Baseline: a82788ba0328da868f50664be77f945a8dba4817 Comparison: 083babe7b50d9c56ac68b823c38e329289b6d22d Diff
Optimization Goals: ✅ No significant changes detected
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +3.56 | [+2.69, +4.44] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.83 | [+0.73, +0.92] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.63 | [+0.46, +0.79] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.30 | [+0.16, +0.43] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.05 | [-0.57, +0.67] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.04 | [-0.58, +0.66] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.04 | [-0.02, +0.11] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.04 | [-0.53, +0.60] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.03 | [-0.55, +0.60] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.01 | [-0.09, +0.11] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | +0.01 | [-0.11, +0.13] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.27, +0.28] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.02, +0.02] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.03 | [-0.66, +0.61] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.03 | [-0.26, +0.20] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.05 | [-0.66, +0.57] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.06 | [-0.67, +0.56] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.10 | [-0.26, +0.06] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.15 | [-0.26, -0.03] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.42 | [-0.46, -0.38] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.64 | [-3.24, +1.95] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_cpu | % cpu utilization | -0.75 | [-4.53, +3.04] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.29 | [-1.34, -1.23] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
![pr-commenter[bot] avatar](https://avatars.githubusercontent.com/u/365230?v=4 "Published by a pub.dev verified publisher"){kind=small}
Uncompressed package size comparison
Comparison with ancestor a82788ba0328da868f50664be77f945a8dba4817
Diff per package
| package | diff | status | size | ancestor | threshold |
|---|---|---|---|---|---|
| datadog-agent-amd64-deb | 0.00MB | ✅ | 773.30MB | 773.30MB | 0.50MB |
| datadog-agent-x86_64-rpm | 0.00MB | ✅ | 782.25MB | 782.25MB | 0.50MB |
| datadog-agent-x86_64-suse | 0.00MB | ✅ | 782.25MB | 782.25MB | 0.50MB |
| datadog-agent-arm64-deb | 0.00MB | ✅ | 759.26MB | 759.26MB | 0.50MB |
| datadog-agent-aarch64-rpm | 0.00MB | ✅ | 768.19MB | 768.19MB | 0.50MB |
| datadog-dogstatsd-amd64-deb | 0.00MB | ✅ | 31.99MB | 31.99MB | 0.50MB |
| datadog-dogstatsd-x86_64-rpm | 0.00MB | ✅ | 32.07MB | 32.07MB | 0.50MB |
| datadog-dogstatsd-x86_64-suse | 0.00MB | ✅ | 32.07MB | 32.07MB | 0.50MB |
| datadog-dogstatsd-arm64-deb | 0.00MB | ✅ | 30.47MB | 30.47MB | 0.50MB |
| datadog-heroku-agent-amd64-deb | 0.00MB | ✅ | 380.12MB | 380.12MB | 0.50MB |
| datadog-iot-agent-amd64-deb | 0.00MB | ✅ | 62.70MB | 62.70MB | 0.50MB |
| datadog-iot-agent-x86_64-rpm | 0.00MB | ✅ | 62.78MB | 62.78MB | 0.50MB |
| datadog-iot-agent-x86_64-suse | 0.00MB | ✅ | 62.78MB | 62.78MB | 0.50MB |
| datadog-iot-agent-arm64-deb | 0.00MB | ✅ | 59.27MB | 59.27MB | 0.50MB |
| datadog-iot-agent-aarch64-rpm | 0.00MB | ✅ | 59.35MB | 59.35MB | 0.50MB |
Decision
✅ Passed
Static quality checks
✅ Please find below the results from static quality gates
Successful checks
Info
| Result | Quality gate | On disk size | On disk size limit | On wire size | On wire size limit |
|---|---|---|---|---|---|
| ✅ | static_quality_gate_agent_deb_amd64 | 746.02 MiB | 752.99 MiB | 184.7 MiB | 187.44 MiB |
| ✅ | static_quality_gate_agent_deb_amd64_fips | 744.39 MiB | 751.36 MiB | 184.12 MiB | 187.06 MiB |
| ✅ | static_quality_gate_agent_heroku_amd64 | 368.5 MiB | 369.68 MiB | 98.53 MiB | 99.55 MiB |
| ✅ | static_quality_gate_agent_msi | 977.16 MiB | 978.01 MiB | 148.31 MiB | 149.12 MiB |
| ✅ | static_quality_gate_agent_rpm_amd64 | 746.01 MiB | 752.98 MiB | 186.44 MiB | 190.03 MiB |
| ✅ | static_quality_gate_agent_rpm_amd64_fips | 744.38 MiB | 751.35 MiB | 186.18 MiB | 189.81 MiB |
| ✅ | static_quality_gate_agent_rpm_arm64 | 732.6 MiB | 739.42 MiB | 168.39 MiB | 171.23 MiB |
| ✅ | static_quality_gate_agent_rpm_arm64_fips | 731.09 MiB | 737.91 MiB | 167.55 MiB | 170.22 MiB |
| ✅ | static_quality_gate_agent_suse_amd64 | 746.01 MiB | 752.98 MiB | 186.44 MiB | 190.03 MiB |
| ✅ | static_quality_gate_agent_suse_amd64_fips | 744.38 MiB | 751.35 MiB | 186.18 MiB | 189.81 MiB |
| ✅ | static_quality_gate_agent_suse_arm64 | 732.6 MiB | 739.42 MiB | 168.39 MiB | 171.23 MiB |
| ✅ | static_quality_gate_agent_suse_arm64_fips | 731.09 MiB | 737.91 MiB | 167.55 MiB | 170.22 MiB |
| ✅ | static_quality_gate_docker_agent_amd64 | 829.79 MiB | 849.39 MiB | 281.76 MiB | 288.34 MiB |
| ✅ | static_quality_gate_docker_agent_arm64 | 839.85 MiB | 858.97 MiB | 267.87 MiB | 274.36 MiB |
| ✅ | static_quality_gate_docker_agent_jmx_amd64 | 829.79 MiB | 849.39 MiB | 281.76 MiB | 288.34 MiB |
| ✅ | static_quality_gate_docker_agent_jmx_arm64 | 839.85 MiB | 858.97 MiB | 267.87 MiB | 274.36 MiB |
| ✅ | static_quality_gate_docker_agent_windows1809 | 829.79 MiB | 849.39 MiB | 281.76 MiB | 288.34 MiB |
| ✅ | static_quality_gate_docker_agent_windows1809_core | 829.79 MiB | 849.39 MiB | 281.76 MiB | 288.34 MiB |
| ✅ | static_quality_gate_docker_agent_windows1809_core_jmx | 829.79 MiB | 849.39 MiB | 281.76 MiB | 288.34 MiB |
| ✅ | static_quality_gate_docker_agent_windows1809_jmx | 829.79 MiB | 849.39 MiB | 281.76 MiB | 288.34 MiB |
| ✅ | static_quality_gate_docker_agent_windows2022 | 829.79 MiB | 849.39 MiB | 281.76 MiB | 288.34 MiB |
| ✅ | static_quality_gate_docker_agent_windows2022_core | 829.79 MiB | 849.39 MiB | 281.76 MiB | 288.34 MiB |
| ✅ | static_quality_gate_docker_agent_windows2022_core_jmx | 829.79 MiB | 849.39 MiB | 281.76 MiB | 288.34 MiB |
| ✅ | static_quality_gate_docker_agent_windows2022_jmx | 829.79 MiB | 849.39 MiB | 281.76 MiB | 288.34 MiB |
| ✅ | static_quality_gate_docker_cluster_agent_amd64 | 258.9 MiB | 259.73 MiB | 102.78 MiB | 103.68 MiB |
| ✅ | static_quality_gate_docker_cluster_agent_arm64 | 273.41 MiB | 274.24 MiB | 97.52 MiB | 98.45 MiB |
| ✅ | static_quality_gate_docker_cws_instrumentation_amd64 | 7.08 MiB | 7.12 MiB | 2.95 MiB | 3.29 MiB |
| ✅ | static_quality_gate_docker_cws_instrumentation_arm64 | 6.69 MiB | 6.92 MiB | 2.7 MiB | 3.07 MiB |
| ✅ | static_quality_gate_docker_dogstatsd_amd64 | 38.63 MiB | 39.57 MiB | 14.81 MiB | 15.76 MiB |
| ✅ | static_quality_gate_docker_dogstatsd_arm64 | 37.26 MiB | 38.2 MiB | 13.88 MiB | 14.83 MiB |
| ✅ | static_quality_gate_dogstatsd_deb_amd64 | 30.58 MiB | 31.52 MiB | 8.02 MiB | 8.97 MiB |
| ✅ | static_quality_gate_dogstatsd_deb_arm64 | 29.14 MiB | 30.08 MiB | 6.97 MiB | 7.92 MiB |
| ✅ | static_quality_gate_dogstatsd_rpm_amd64 | 30.58 MiB | 31.52 MiB | 8.03 MiB | 8.98 MiB |
| ✅ | static_quality_gate_dogstatsd_suse_amd64 | 30.58 MiB | 31.52 MiB | 8.03 MiB | 8.98 MiB |
| ✅ | static_quality_gate_iot_agent_deb_amd64 | 59.87 MiB | 60.17 MiB | 14.97 MiB | 15.82 MiB |
| ✅ | static_quality_gate_iot_agent_deb_arm64 | 56.6 MiB | 56.94 MiB | 12.84 MiB | 13.86 MiB |
| ✅ | static_quality_gate_iot_agent_deb_armhf | 56.05 MiB | 56.41 MiB | 12.99 MiB | 13.86 MiB |
| ✅ | static_quality_gate_iot_agent_rpm_amd64 | 59.87 MiB | 60.18 MiB | 15.0 MiB | 15.84 MiB |
| ✅ | static_quality_gate_iot_agent_rpm_arm64 | 56.6 MiB | 56.94 MiB | 12.86 MiB | 13.76 MiB |
| ✅ | static_quality_gate_iot_agent_suse_amd64 | 59.87 MiB | 60.18 MiB | 15.0 MiB | 15.84 MiB |
View all feedbacks in Devflow UI.
2025-05-21 13:59:25 UTC :information_source: Start processing command /merge
2025-05-21 13:59:37 UTC :information_source: MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
2025-05-21 16:22:14 UTC :information_source: MergeQueue: merge request added to the queue
The expected merge time in main is approximately 1h (p90).
2025-05-21 17:04:04 UTC :information_source: MergeQueue: This merge request was merged