datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard
verified publisher icon DataDog

usm: Refactor SSL monitor to use new uprobe attacher

Open gjulianm opened this issue 1 year ago • 4 comments

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

gjulianm avatar Sep 12 '24 15:09 gjulianm

/trigger-ci

gjulianm avatar Sep 13 '24 09:09 gjulianm

:steam_locomotive: Gitlab pipeline started

Started pipeline #44268999

dd-devflow[bot] avatar Sep 13 '24 09:09 dd-devflow[bot]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

dda inv aws.create-vm --pipeline-id=63026549 --os-family=ubuntu

Note: This applies to commit db2e8cdb

agent-platform-auto-pr[bot] avatar Feb 21 '25 13:02 agent-platform-auto-pr[bot]

Uncompressed package size comparison

Comparison with ancestor dc52a8dd4b9a9a2d5dd80cb77a1af54b3230c738

Size reduction summary
package diff status size ancestor threshold
datadog-agent-arm64-deb -0.03MB ✅ 766.15MB 766.18MB 0.50MB
datadog-agent-aarch64-rpm -0.03MB ✅ 775.07MB 775.10MB 0.50MB
datadog-agent-amd64-deb -0.04MB ✅ 776.35MB 776.39MB 0.50MB
datadog-agent-x86_64-rpm -0.04MB ✅ 785.30MB 785.34MB 0.50MB
datadog-agent-x86_64-suse -0.04MB ✅ 785.30MB 785.34MB 0.50MB
Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-amd64-deb 0.00MB ✅ 31.20MB 31.20MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB ✅ 31.28MB 31.28MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB ✅ 31.28MB 31.28MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB ✅ 30.03MB 30.03MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB ✅ 377.90MB 377.90MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB ✅ 60.57MB 60.57MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB ✅ 60.65MB 60.65MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB ✅ 60.65MB 60.65MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB ✅ 57.86MB 57.86MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB ✅ 57.94MB 57.94MB 0.50MB

Decision

✅ Passed

agent-platform-auto-pr[bot] avatar Feb 21 '25 13:02 agent-platform-auto-pr[bot]

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
✅ static_quality_gate_agent_deb_amd64 780.02 MiB 780.74 MiB 190.29 MiB 190.85 MiB
✅ static_quality_gate_agent_deb_amd64_fips 777.99 MiB 778.65 MiB 190.05 MiB 190.66 MiB
✅ static_quality_gate_agent_heroku_amd64 427.98 MiB 428.97 MiB 112.78 MiB 113.11 MiB
✅ static_quality_gate_agent_msi 976.04 MiB 977.0 MiB 149.39 MiB 149.85 MiB
✅ static_quality_gate_agent_rpm_amd64 780.01 MiB 780.59 MiB 192.88 MiB 193.37 MiB
✅ static_quality_gate_agent_rpm_amd64_fips 777.98 MiB 778.69 MiB 192.1 MiB 192.47 MiB
✅ static_quality_gate_agent_rpm_arm64 771.42 MiB 772.07 MiB 173.96 MiB 174.47 MiB
✅ static_quality_gate_agent_rpm_arm64_fips 769.6 MiB 770.27 MiB 173.11 MiB 173.63 MiB
✅ static_quality_gate_agent_suse_amd64 780.01 MiB 780.7 MiB 192.88 MiB 193.37 MiB
✅ static_quality_gate_agent_suse_amd64_fips 777.98 MiB 778.59 MiB 192.1 MiB 192.47 MiB
✅ static_quality_gate_agent_suse_arm64 771.42 MiB 772.02 MiB 173.96 MiB 174.47 MiB
✅ static_quality_gate_agent_suse_arm64_fips 769.6 MiB 770.2 MiB 173.11 MiB 173.63 MiB
✅ static_quality_gate_docker_agent_amd64 865.14 MiB 865.3 MiB 290.9 MiB 291.35 MiB
✅ static_quality_gate_docker_agent_arm64 879.84 MiB 880.0 MiB 277.41 MiB 277.86 MiB
✅ static_quality_gate_docker_agent_jmx_amd64 865.14 MiB 865.3 MiB 290.9 MiB 291.35 MiB
✅ static_quality_gate_docker_agent_jmx_arm64 879.84 MiB 880.0 MiB 277.41 MiB 277.86 MiB
✅ static_quality_gate_docker_agent_windows1809 865.14 MiB 865.3 MiB 290.9 MiB 291.35 MiB
✅ static_quality_gate_docker_agent_windows1809_core 865.14 MiB 865.3 MiB 290.9 MiB 291.35 MiB
✅ static_quality_gate_docker_agent_windows1809_core_jmx 865.14 MiB 865.3 MiB 290.9 MiB 291.35 MiB
✅ static_quality_gate_docker_agent_windows1809_jmx 865.14 MiB 865.3 MiB 290.9 MiB 291.35 MiB
✅ static_quality_gate_docker_agent_windows2022 865.14 MiB 865.3 MiB 290.9 MiB 291.35 MiB
✅ static_quality_gate_docker_agent_windows2022_core 865.14 MiB 865.3 MiB 290.9 MiB 291.35 MiB
✅ static_quality_gate_docker_agent_windows2022_core_jmx 865.14 MiB 865.3 MiB 290.9 MiB 291.35 MiB
✅ static_quality_gate_docker_agent_windows2022_jmx 865.14 MiB 865.3 MiB 290.9 MiB 291.35 MiB
✅ static_quality_gate_docker_cluster_agent_amd64 263.12 MiB 263.29 MiB 105.69 MiB 106.03 MiB
✅ static_quality_gate_docker_cluster_agent_arm64 279.06 MiB 279.25 MiB 100.52 MiB 100.87 MiB
✅ static_quality_gate_docker_cws_instrumentation_amd64 6.65 MiB 7.12 MiB 2.82 MiB 3.29 MiB
✅ static_quality_gate_docker_cws_instrumentation_arm64 6.44 MiB 6.92 MiB 2.6 MiB 3.07 MiB
✅ static_quality_gate_docker_dogstatsd_amd64 46.09 MiB 46.37 MiB 17.38 MiB 17.78 MiB
✅ static_quality_gate_docker_dogstatsd_arm64 44.7 MiB 44.99 MiB 16.24 MiB 16.65 MiB
✅ static_quality_gate_dogstatsd_deb_amd64 37.95 MiB 38.23 MiB 9.84 MiB 10.26 MiB
✅ static_quality_gate_dogstatsd_deb_arm64 36.53 MiB 36.82 MiB 8.54 MiB 8.96 MiB
✅ static_quality_gate_dogstatsd_rpm_amd64 37.95 MiB 38.23 MiB 9.85 MiB 10.27 MiB
✅ static_quality_gate_dogstatsd_suse_amd64 37.95 MiB 38.23 MiB 9.85 MiB 10.27 MiB
✅ static_quality_gate_iot_agent_deb_amd64 57.71 MiB 58.19 MiB 14.55 MiB 15.02 MiB
✅ static_quality_gate_iot_agent_deb_arm64 55.16 MiB 55.63 MiB 12.57 MiB 13.05 MiB
✅ static_quality_gate_iot_agent_deb_armhf 53.84 MiB 54.32 MiB 12.57 MiB 13.05 MiB
✅ static_quality_gate_iot_agent_rpm_amd64 57.71 MiB 58.19 MiB 14.57 MiB 15.04 MiB
✅ static_quality_gate_iot_agent_rpm_arm64 55.16 MiB 55.63 MiB 12.59 MiB 13.07 MiB
✅ static_quality_gate_iot_agent_suse_amd64 57.71 MiB 58.19 MiB 14.57 MiB 15.04 MiB

agent-platform-auto-pr[bot] avatar Feb 21 '25 13:02 agent-platform-auto-pr[bot]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: cbaa9e64-6a7e-4816-913e-4b38035deaa7

Baseline: dc52a8dd4b9a9a2d5dd80cb77a1af54b3230c738 Comparison: 1a109da804fdb463eb0db03398cfbf5b6af4a41b Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ file_tree memory utilization +0.90 [+0.76, +1.04] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.17 [+0.07, +0.27] 1 Logs bounds checks dashboard
➖ file_to_blackhole_0ms_latency egress throughput +0.04 [-0.57, +0.66] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.04 [-0.19, +0.27] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.03 [-0.65, +0.70] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.66, +0.69] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.29, +0.31] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.01 [-0.63, +0.64] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.00 [-0.69, +0.69] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.00 [-0.65, +0.64] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.05 [-0.67, +0.58] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.05 [-0.20, +0.10] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.09 [-0.14, -0.03] 1 Logs
➖ ddot_logs memory utilization -0.22 [-0.34, -0.09] 1 Logs
➖ docker_containers_memory memory utilization -0.35 [-0.43, -0.26] 1 Logs
➖ quality_gate_idle memory utilization -0.35 [-0.41, -0.30] 1 Logs bounds checks dashboard
➖ otlp_ingest_logs memory utilization -0.43 [-0.56, -0.30] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.55 [-1.40, +0.30] 1 Logs
➖ ddot_metrics memory utilization -0.57 [-0.69, -0.45] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.92 [-0.96, -0.89] 1 Logs
➖ quality_gate_logs % cpu utilization -1.33 [-4.05, +1.40] 1 Logs bounds checks dashboard
➖ docker_containers_cpu % cpu utilization -3.18 [-6.93, +0.58] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

cit-pr-commenter[bot] avatar Feb 21 '25 14:02 cit-pr-commenter[bot]

Static quality checks

✅ Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
✅ static_quality_gate_agent_deb_amd64 751.03 MiB 778.06 MiB 184.99 MiB 191.06 MiB
✅ static_quality_gate_agent_deb_amd64_fips 748.89 MiB 776.09 MiB 184.67 MiB 190.72 MiB
✅ static_quality_gate_agent_heroku_amd64 368.37 MiB 434.99 MiB 98.04 MiB 114.34 MiB
✅ static_quality_gate_agent_msi 969.15 MiB 978.45 MiB 146.84 MiB 151.65 MiB
✅ static_quality_gate_agent_rpm_amd64 751.05 MiB 778.06 MiB 186.88 MiB 193.42 MiB
✅ static_quality_gate_agent_rpm_amd64_fips 748.98 MiB 776.06 MiB 185.8 MiB 192.61 MiB
✅ static_quality_gate_agent_rpm_arm64 741.4 MiB 768.33 MiB 169.23 MiB 174.71 MiB
✅ static_quality_gate_agent_rpm_arm64_fips 739.34 MiB 766.55 MiB 168.05 MiB 173.92 MiB
✅ static_quality_gate_agent_suse_amd64 751.05 MiB 778.08 MiB 186.88 MiB 193.42 MiB
✅ static_quality_gate_agent_suse_amd64_fips 749.01 MiB 776.11 MiB 185.8 MiB 192.78 MiB
✅ static_quality_gate_agent_suse_arm64 741.3 MiB 768.31 MiB 169.23 MiB 174.71 MiB
✅ static_quality_gate_agent_suse_arm64_fips 739.3 MiB 766.5 MiB 168.05 MiB 173.92 MiB
✅ static_quality_gate_docker_agent_amd64 845.33 MiB 862.5 MiB 285.28 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_arm64 858.73 MiB 876.0 MiB 272.11 MiB 278.3 MiB
✅ static_quality_gate_docker_agent_jmx_amd64 845.33 MiB 862.5 MiB 285.28 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_jmx_arm64 858.73 MiB 876.63 MiB 272.11 MiB 278.4 MiB
✅ static_quality_gate_docker_agent_windows1809 845.33 MiB 862.5 MiB 285.28 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_windows1809_core 845.33 MiB 862.5 MiB 285.28 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_windows1809_core_jmx 845.33 MiB 862.5 MiB 285.28 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_windows1809_jmx 845.33 MiB 862.5 MiB 285.28 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_windows2022 845.33 MiB 862.5 MiB 285.28 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_windows2022_core 845.33 MiB 862.5 MiB 285.28 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_windows2022_core_jmx 845.33 MiB 862.5 MiB 285.28 MiB 292.0 MiB
✅ static_quality_gate_docker_agent_windows2022_jmx 845.33 MiB 862.5 MiB 285.28 MiB 292.0 MiB
✅ static_quality_gate_docker_cluster_agent_amd64 259.71 MiB 263.4 MiB 101.95 MiB 104.07 MiB
✅ static_quality_gate_docker_cluster_agent_arm64 275.69 MiB 279.38 MiB 96.91 MiB 98.95 MiB
✅ static_quality_gate_docker_cws_instrumentation_amd64 6.66 MiB 7.12 MiB 2.82 MiB 3.29 MiB
✅ static_quality_gate_docker_cws_instrumentation_arm64 6.44 MiB 6.92 MiB 2.6 MiB 3.07 MiB
✅ static_quality_gate_docker_dogstatsd_amd64 37.97 MiB 46.39 MiB 14.64 MiB 17.78 MiB
✅ static_quality_gate_docker_dogstatsd_arm64 36.89 MiB 45.05 MiB 13.73 MiB 16.65 MiB
✅ static_quality_gate_dogstatsd_deb_amd64 29.83 MiB 38.4 MiB 7.89 MiB 10.26 MiB
✅ static_quality_gate_dogstatsd_deb_arm64 28.71 MiB 36.98 MiB 6.87 MiB 8.96 MiB
✅ static_quality_gate_dogstatsd_rpm_amd64 29.83 MiB 38.4 MiB 7.9 MiB 10.27 MiB
✅ static_quality_gate_dogstatsd_suse_amd64 29.83 MiB 38.4 MiB 7.9 MiB 10.27 MiB
✅ static_quality_gate_iot_agent_deb_amd64 57.85 MiB 58.51 MiB 14.56 MiB 15.02 MiB
✅ static_quality_gate_iot_agent_deb_arm64 55.27 MiB 55.94 MiB 12.57 MiB 13.05 MiB
✅ static_quality_gate_iot_agent_deb_armhf 54.03 MiB 54.32 MiB 12.58 MiB 13.05 MiB
✅ static_quality_gate_iot_agent_rpm_amd64 57.85 MiB 58.51 MiB 14.58 MiB 15.04 MiB
✅ static_quality_gate_iot_agent_rpm_arm64 55.26 MiB 55.94 MiB 12.59 MiB 13.07 MiB
✅ static_quality_gate_iot_agent_suse_amd64 57.85 MiB 58.51 MiB 14.58 MiB 15.04 MiB

agent-platform-auto-pr[bot] avatar Apr 14 '25 11:04 agent-platform-auto-pr[bot]

I'll run tomorrow a longer (24h) load-test of openssl to get more confidence in the change

guyarb avatar Apr 29 '25 17:04 guyarb

I'll run tomorrow a longer (24h) load-test of openssl to get more confidence in the change

For openssl, can you wait until I merge the other PR for the attacher? Just to ensure that we're comparing with the same behavior.

gjulianm avatar Apr 29 '25 18:04 gjulianm

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies

Was this helpful? Give us feedback!

datadog-datadog-prod-us1[bot] avatar May 12 '25 11:05 datadog-datadog-prod-us1[bot]

load test results - https://dddev.datadoghq.com/dashboard/gqu-2wz-asy/usm-performance-evaluation-20?fromUs[…]penssl&from_ts=1747124945308&to_ts=1747197443353&live=false https://dddev.datadoghq.com/dashboard/gqu-2wz-asy/usm-performance-evaluation-20?fromUs[…]penssl&from_ts=1747124945308&to_ts=1747197443353&live=false https://dddev.datadoghq.com/dashboard/gqu-2wz-asy/usm-performance-evaluation-20?fromUs[…]penssl&from_ts=1747124945308&to_ts=1747197443353&live=false

agreed with Guillermo, to wait until 7.67 cutoff

guyarb avatar May 14 '25 10:05 guyarb

/merge

guyarb avatar May 17 '25 07:05 guyarb

View all feedbacks in Devflow UI.

2025-05-17 07:40:17 UTC :information_source: Start processing command /merge

2025-05-17 07:40:20 UTC :information_source: MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).

2025-05-17 08:32:06 UTC :information_source: MergeQueue: This merge request was merged

dd-devflow[bot] avatar May 17 '25 07:05 dd-devflow[bot]