datadog-agent
datadog-agent copied to clipboard
[Fleet Automation] Fix the bootstrapper for Windows and add an install-script
What does this PR do?
This PR fixes the bootstrap command to work on Windows and adds a PowerShell script that will download the bootstrapper, and execute the bootstrap command.
Motivation
https://datadoghq.atlassian.net/browse/WINA-872
Additional Notes
There are no arguments for the PowerShell script but in the future we can imagine having a way to change the registry, the version, or the default packages. On Linux this is done via environment variables, so this is already possible if the correct environment variable is set before the script is invoked.
Setting the label 'no-changelog' because this feature is not yet released.
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
- Publish the changes from this PR to a custom registry (see https://datadoghq.atlassian.net/wiki/spaces/AW/pages/3404466896/Windows+Fleet+Automation#Test-custom-built-images)
- Make sure that both the Datadog Agent and Datadog Installer images exist on the registry
- Download the bootstrap executable from the Gitlab artifact
- On a blank VM, copy the bootstrap executable, set
$env:DD_INSTALLER_DEFAULT_PKG_INSTALL_DATADOG_AGENT="True", and the correct environment variable for the test registry$env:DD_INSTALLER_REGISTRY_URL="docker.io/<username>". - Call
datadog-installer.exe bootstrap - Verify that both the Datadog Installer service and the Datadog Agent were installed.
Note: It's not possible to test the PowerShell script yet because the bootstrap executable is not yet published.
Gitlab CI Configuration Changes
Modified Jobs
deploy_installer_packages_windows-x64
deploy_installer_packages_windows-x64:
before_script:
- ls $OMNIBUS_PACKAGE_DIR
image: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/datadog-agent-buildimages/gitlab_agent_deploy$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
needs:
- windows-installer-amd64
rules:
- if: $DEPLOY_INSTALLER == "true" || $DDR_WORKFLOW_ID != null
script:
- $S3_CP_CMD --recursive --exclude "*" --include "datadog-installer-*-1-x86_64.msi"
--include "datadog-installer-*-1-x86_64.debug.zip" --include "datadog-installer-*-1-x86_64.zip"
- $OMNIBUS_PACKAGE_DIR $S3_RELEASE_INSTALLER_ARTIFACTS_URI/msi/x86_64/
+ --include "datadog-installer-*-1-x86_64.exe" $OMNIBUS_PACKAGE_DIR $S3_RELEASE_INSTALLER_ARTIFACTS_URI/msi/x86_64/
? +++++++++++++++++++++++++++++++++++++++++++++
stage: deploy_packages
tags:
- arch:amd64
Changes Summary
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 1 | 0 | 0 |
:information_source: Diff available in the job log.
Regression Detector
Regression Detector Results
Run ID: b284f504-4a73-40b0-99a9-455223782a59 Metrics dashboard Target profiles
Baseline: ee133be181fe6c6efc03054660eae3d039279e59 Comparison: cf1a8565077e9c36ce87030cabc646adb26ee2aa
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.94 | [+0.89, +0.99] | 1 | Logs |
| ➖ | idle_all_features | memory utilization | +0.87 | [+0.77, +0.97] | 1 | Logs |
| ➖ | idle | memory utilization | +0.63 | [+0.57, +0.69] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.57 | [-0.24, +1.38] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.10, +0.09] | 1 | Logs |
| ➖ | basic_py_check | % cpu utilization | -0.26 | [-2.99, +2.47] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.32 | [-1.07, +0.42] | 1 | Logs |
| ➖ | pycheck_lots_of_tags | % cpu utilization | -0.51 | [-3.00, +1.99] | 1 | Logs |
| ➖ | file_tree | memory utilization | -2.13 | [-2.24, -2.02] | 1 | Logs |
Bounds Checks
| perf | experiment | bounds_check_name | replicates_passed |
|---|---|---|---|
| ✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Test changes on VM
Use this command from test-infra-definitions to manually test this PR changes on a VM:
inv create-vm --pipeline-id=45208304 --os-family=ubuntu
Note: This applies to commit cf1a8565
/merge
:steam_locomotive: MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
Use /merge -c to cancel this operation!
/merge -c
:warning: MergeQueue: This merge request was unqueued
This merge request was unqueued
If you need support, contact us on Slack #devflow!
/merge
:steam_locomotive: MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
Use /merge -c to cancel this operation!
/merge
:steam_locomotive: MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
Use /merge -c to cancel this operation!
:steam_locomotive: MergeQueue: pull request added to the queue
The median merge time in main is 23m.
Use /merge -c to cancel this operation!