usm: Refactor istio monitor to use new uprobe attacher

[gjulianm]

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter[bot]]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50815221 --os-family=ubuntu

Note: This applies to commit 248375e7

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 1fe899da-fef5-4de3-946f-1e09bd47b611

Baseline: f238a89194b1176281a0bfef2bcc7c253033aa64 Comparison: 248375e7c3aec4210140a28efac09a39951217ae Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.60	[+0.86, +2.33]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.47	[-0.30, +1.23]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.28	[-0.18, +0.74]	1	Logs
➖	file_tree	memory utilization	+0.18	[+0.06, +0.30]	1	Logs
➖	otel_to_otel_logs	ingress throughput	+0.10	[-0.58, +0.77]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.08	[-0.02, +0.18]	1	Logs bounds checks dashboard
➖	file_to_blackhole_500ms_latency	egress throughput	+0.08	[-0.71, +0.86]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.07	[-0.79, +0.93]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.02	[-0.75, +0.79]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.10, +0.11]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.00	[-0.82, +0.83]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.02]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.03	[-0.09, +0.04]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.05	[-0.88, +0.78]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.08	[-0.71, +0.56]	1	Logs
➖	quality_gate_idle	memory utilization	-0.26	[-0.30, -0.22]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-4.07	[-6.99, -1.16]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_300ms_latency	lost_bytes	9/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[agent-platform-auto-pr[bot]]

[Fast Unit Tests Report]

On pipeline 50815221 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[agent-platform-auto-pr[bot]]

Package size comparison

Comparison with ancestor f238a89194b1176281a0bfef2bcc7c253033aa64

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	-0.01MB	✅	1271.24MB	1271.25MB	140.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.21MB	113.21MB	10.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.32MB	78.32MB	10.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	526.44MB	526.44MB	70.00MB
datadog-agent-x86_64-rpm	-0.01MB	✅	1280.48MB	1280.48MB	140.00MB
datadog-agent-x86_64-suse	-0.01MB	✅	1280.48MB	1280.48MB	140.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.27MB	113.27MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.27MB	113.27MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.40MB	78.40MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.40MB	78.40MB	10.00MB
datadog-agent-arm64-deb	-0.01MB	✅	1005.41MB	1005.42MB	140.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.70MB	108.70MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.59MB	55.59MB	10.00MB
datadog-agent-aarch64-rpm	-0.01MB	✅	1014.63MB	1014.64MB	140.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.77MB	108.77MB	10.00MB

Decision

✅ Passed

[gjulianm]

/merge

[dd-devflow[bot]]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2024-12-11 13:09:32 UTC :information_source: MergeQueue: pull request added to the queue

The median merge time in main is 24m.

---

2024-12-11 13:49:59 UTC :information_source: MergeQueue: This merge request was merged