datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

[CWS] do not dispatch event in the case of an error

Open paulcacheux opened this issue 1 year ago • 2 comments

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

paulcacheux avatar Sep 12 '24 14:09 paulcacheux

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=45920032 --os-family=ubuntu

Note: This applies to commit 2675236c

pr-commenter[bot] avatar Sep 12 '24 15:09 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 533d6be9-d40c-4238-b2a0-420936760107 Metrics dashboard Target profiles

Baseline: 66190f78f59f220564cd808fca0318fba2f0c345 Comparison: 2675236c6adcb807d9d1773f96ddaca98f15eec3

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +0.62 [-2.09, +3.34] 1 Logs
pycheck_lots_of_tags % cpu utilization +0.54 [-1.98, +3.07] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.38 [+0.33, +0.43] 1 Logs
idle memory utilization +0.11 [+0.07, +0.16] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.10, +0.09] 1 Logs
file_tree memory utilization -0.06 [-0.17, +0.05] 1 Logs
idle_all_features memory utilization -0.20 [-0.29, -0.12] 1 Logs
otel_to_otel_logs ingress throughput -0.51 [-1.32, +0.30] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.89 [-1.61, -0.16] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Sep 12 '24 15:09 pr-commenter[bot]

/merge

paulcacheux avatar Oct 07 '24 15:10 paulcacheux

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Oct 07 '24 15:10 dd-devflow[bot]