datadog-agent
datadog-agent copied to clipboard
[CONTP-359] Updating OriginInfo struct field names
What does this PR do?
This PR changes the names of fields in the OriginInfo struct (FromUDS, FromTag, FromMsg) to more precise names
Motivation
The current taggertypes.OriginInfo implementation reused the DogStatsD original field names to help with implementation and adoption, however, the field names were not so accurate. Therefore, we changed them to make it more understandable as to what they are representing.
Additional Notes
Possible Drawbacks / Trade-offs
None
Describe how to test/QA your changes
None. Regular test suite should catch any errors in changing variable names.
Test changes on VM
Use this command from test-infra-definitions to manually test this PR changes on a VM:
inv create-vm --pipeline-id=44824200 --os-family=ubuntu
Note: This applies to commit 40856494
Regression Detector
Regression Detector Results
Run ID: 6712c786-3ea4-42b0-9eb0-b732f90fc073 Metrics dashboard Target profiles
Baseline: 42c6d41ada1ed9105b1aa1beb181557da43d60cb Comparison: 408564949f2f73aab7ff2c850e55cb9795a31d1c
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
No significant changes in experiment optimization goals
Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%
There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | idle | memory utilization | +0.66 | [+0.60, +0.73] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.44 | [-0.36, +1.25] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.35 | [+0.31, +0.39] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.32 | [-0.43, +1.07] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.09, +0.08] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.55 | [-0.65, -0.45] | 1 | Logs |
| ➖ | pycheck_lots_of_tags | % cpu utilization | -0.75 | [-3.21, +1.72] | 1 | Logs |
| ➖ | basic_py_check | % cpu utilization | -1.88 | [-4.58, +0.83] | 1 | Logs |
Bounds Checks
| perf | experiment | bounds_check_name | replicates_passed |
|---|---|---|---|
| ✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge
:steam_locomotive: MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
Use /merge -c to cancel this operation!
:warning: MergeQueue: This merge request was unqueued
This merge request was unqueued
If you need support, contact us on Slack #devflow!
/merge
:steam_locomotive: MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
Use /merge -c to cancel this operation!
:steam_locomotive: MergeQueue: pull request added to the queue
The median merge time in main is 23m.
Use /merge -c to cancel this operation!