datadog-agent icon indicating copy to clipboard operation
datadog-agent copied to clipboard

config: add sbom flags documentation in sample config file

Open jinroh opened this issue 1 year ago • 2 comments

What does this PR do?

Adds description and some documentation in our sample config file for sbom.* options.

Motivation

These fields are missing.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

jinroh avatar Sep 11 '24 09:09 jinroh

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=44150677 --os-family=ubuntu

Note: This applies to commit 8645fca6

pr-commenter[bot] avatar Sep 11 '24 09:09 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: a467530d-2e5d-415a-82e4-f0faf935a86b Metrics dashboard Target profiles

Baseline: ba54a8d16c6cd32e2918fd6f37359bb5c5b57983 Comparison: 8645fca6eb9458af623d040231bdc990d469d05c

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +0.83 [+0.72, +0.94] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.75 [-0.05, +1.56] 1 Logs
pycheck_lots_of_tags % cpu utilization +0.75 [-1.93, +3.44] 1 Logs
basic_py_check % cpu utilization +0.48 [-2.31, +3.28] 1 Logs
idle memory utilization +0.48 [+0.44, +0.52] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.26 [+0.21, +0.31] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
otel_to_otel_logs ingress throughput -0.68 [-1.50, +0.15] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Sep 11 '24 10:09 pr-commenter[bot]

/merge

jinroh avatar Sep 25 '24 10:09 jinroh

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Sep 25 '24 10:09 dd-devflow[bot]

:x: MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 8b2a300:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail. Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

If you need support, contact us on Slack #devflow with those details!

dd-devflow[bot] avatar Sep 25 '24 10:09 dd-devflow[bot]