Remove aliases from pkg/config and refactor all references to types/functions

[jackgopack4]

trafficstars

What does this PR do?

replaces all existing references to pkg/config with the respective sub-module. The majority of functions and variables were already moved to aliases with #20034; this change removes obfuscation and makes it clearer what our code is doing.

Additionally, remaining functions that were in pkg/config were moved to appropriate submodules, such as pkg/config/legacy and pkg/config/setup

Motivation

closes https://datadoghq.atlassian.net/browse/OTEL-1134

Additional Notes

legacy_converter.go was moved from pkg/config to pkg/config/legacy

Ideally I would have broken this up into smaller PRs, but refactoring the pkg/config/legacy code was causing a circular dependency on every package importing pkg/config so I went through and updated all of them instead.

Possible Drawbacks / Trade-offs

slight formatting/style preferences used across the codebase; could change import names to match local code style. Additionally if a function/functions belong in a different pkg/config submodule I would be happy to move it where makes sense.

Describe how to test/QA your changes

run unit/integration tests locally and through CI

Reviewer's Checklist

• [X] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
• [ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
• [X] A release note has been added or the changelog/no-changelog label has been applied.
• [X] Changed code has automated tests for its functionality.
• [ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
• [X] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
• [ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
• [ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
• [ ] If applicable, the k8s/ label, indicating the lowest Kubernetes version compatible with this feature.
• [ ] If applicable, the config template has been updated.

[cit-pr-commenter[bot]]

Go Package Import Differences

Baseline: cce2d6dab2eb17679fa09459fb109da5aaf6793c Comparison: 7be6100df6f31f7aba05cb65f2e08eb7673583b1

binary	os	arch	change
agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
agent	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
agent	windows	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
agent	darwin	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
agent	darwin	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
iot-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
iot-agent	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
heroku-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
cluster-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
cluster-agent	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
cluster-agent-cloudfoundry	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
cluster-agent-cloudfoundry	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
dogstatsd	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
dogstatsd	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
process-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
process-agent	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
process-agent	windows	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
process-agent	darwin	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
process-agent	darwin	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
heroku-process-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
security-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
security-agent	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
serverless	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
serverless	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
system-probe	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
system-probe	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
system-probe	windows	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
trace-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
trace-agent	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
trace-agent	windows	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
trace-agent	darwin	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
trace-agent	darwin	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config
heroku-trace-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/config

[github-actions[bot]]

:inbox_tray: :loudspeaker: Info, this pull request increases the binary size of serverless extension by 24736 bytes. Each MB of binary size increase means about 10ms of additional cold start time, so this pull request would increase cold start time by 0ms.

Debug info

If you have questions, we are happy to help, come visit us in the #serverless slack channel and provide a link to this comment.

We suggest you consider adding the !serverless build tag to remove any new dependencies not needed in the serverless extension.

[github-actions[bot]]

:inbox_tray: :loudspeaker: Info, this pull request increases the binary size of serverless extension by 24736 bytes. Each MB of binary size increase means about 10ms of additional cold start time, so this pull request would increase cold start time by 0ms.

Debug info

If you have questions, we are happy to help, come visit us in the #serverless slack channel and provide a link to this comment.

We suggest you consider adding the !serverless build tag to remove any new dependencies not needed in the serverless extension.

[github-actions[bot]]

:inbox_tray: :loudspeaker: Info, this pull request increases the binary size of serverless extension by 24736 bytes. Each MB of binary size increase means about 10ms of additional cold start time, so this pull request would increase cold start time by 0ms.

Debug info

If you have questions, we are happy to help, come visit us in the #serverless slack channel and provide a link to this comment.

We suggest you consider adding the !serverless build tag to remove any new dependencies not needed in the serverless extension.

[github-actions[bot]]

:inbox_tray: :loudspeaker: Info, this pull request increases the binary size of serverless extension by 24736 bytes. Each MB of binary size increase means about 10ms of additional cold start time, so this pull request would increase cold start time by 0ms.

Debug info

If you have questions, we are happy to help, come visit us in the #serverless slack channel and provide a link to this comment.

We suggest you consider adding the !serverless build tag to remove any new dependencies not needed in the serverless extension.

[github-actions[bot]]

:inbox_tray: :loudspeaker: Info, this pull request increases the binary size of serverless extension by -3968 bytes. Each MB of binary size increase means about 10ms of additional cold start time, so this pull request would increase cold start time by 0ms.

Debug info

If you have questions, we are happy to help, come visit us in the #serverless slack channel and provide a link to this comment.

We suggest you consider adding the !serverless build tag to remove any new dependencies not needed in the serverless extension.

[pr-commenter[bot]]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=44513586 --os-family=ubuntu

Note: This applies to commit 7be6100d

[pr-commenter[bot]]

Regression Detector

Regression Detector Results

Run ID: c9d782e7-d80e-4f41-9fea-5147dc05ebc0 Metrics dashboard Target profiles

Baseline: cce2d6dab2eb17679fa09459fb109da5aaf6793c Comparison: 7be6100df6f31f7aba05cb65f2e08eb7673583b1

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	basic_py_check	% cpu utilization	+0.68	[-2.12, +3.47]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.64	[-0.12, +1.40]	1	Logs
➖	file_tree	memory utilization	+0.63	[+0.51, +0.74]	1	Logs
➖	pycheck_lots_of_tags	% cpu utilization	+0.61	[-2.00, +3.22]	1	Logs
➖	idle	memory utilization	+0.30	[+0.25, +0.34]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.00, +0.00]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.10	[-0.15, -0.05]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.99	[-1.81, -0.17]	1	Logs

Bounds Checks

perf	experiment	bounds_check_name	replicates_passed
❌	idle	memory_usage	7/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[jackgopack4]

not sure why the Serverless Binary Size test is failing; seems to be due to an external comment integration. Serverless binary size decreases by 128 bytes with this PR

[jackgopack4]

As a note I noticed that in some functions we reference the function call pkgconfigsetup.Datadog() multiple times. Is not a big deal, but would be nice if we could hoist that into a variable. Especially, since that function call deals with a read lock, so any unnecessary use of the lock 🔒 is not a good approach

I like this idea; I'll look into this and consider opening a second PR; want to keep this PR as close to a 1:1 match of existing code as possible

[jackgopack4]

nit: could be good to refactor the PR title 😅

good call, thank you

[jackgopack4]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:x: MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 250ffcf:

• tests_macos

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

• Investigate the failures and when ready, re-add your pull request to the queue!
• Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail. Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

If you need support, contact us on Slack #devflow with those details!

[jackgopack4]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

[dd-devflow[bot]]

:x: MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 6a6385e:

• tests_ebpf_arm64

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

• Investigate the failures and when ready, re-add your pull request to the queue!
• Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail. Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

If you need support, contact us on Slack #devflow with those details!

[jackgopack4]

/merge

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

[github-actions[bot]]

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between 9f339cb1aaca95f84d756e65b6238bbdae3358c4 and 36eb1a756b784ce971f4d611c2e24ee51a51ac7e.

tl;dr

Use these benchmarks as an insight tool during development.

1. Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.

2. The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

I need more help

First off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development.

If you would like a hand interpreting the results come chat with us in #serverless-agent in the internal DataDog slack or in #serverless in the public DataDog slack. We're happy to help!

Benchmark stats

goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │ baseline/benchmark.log │       current/benchmark.log        │
                                      │         sec/op         │   sec/op     vs base               │
api-gateway-appsec.json                            86.91µ ± 6%   83.91µ ± 5%  -3.45% (p=0.015 n=10)
api-gateway-kong-appsec.json                       67.11µ ± 1%   67.02µ ± 8%       ~ (p=0.684 n=10)
api-gateway-kong.json                              65.70µ ± 1%   64.97µ ± 1%  -1.10% (p=0.000 n=10)
api-gateway-non-proxy-async.json                   103.8µ ± 2%   103.7µ ± 3%       ~ (p=0.971 n=10)
api-gateway-non-proxy.json                         104.8µ ± 1%   104.8µ ± 1%       ~ (p=1.000 n=10)
api-gateway-websocket-connect.json                 69.35µ ± 2%   68.70µ ± 1%  -0.94% (p=0.029 n=10)
api-gateway-websocket-default.json                 63.01µ ± 1%   62.03µ ± 1%  -1.54% (p=0.005 n=10)
api-gateway-websocket-disconnect.json              62.60µ ± 2%   62.56µ ± 1%       ~ (p=0.796 n=10)
api-gateway.json                                   116.6µ ± 1%   113.9µ ± 1%  -2.34% (p=0.000 n=10)
application-load-balancer.json                     64.52µ ± 1%   62.78µ ± 2%  -2.70% (p=0.000 n=10)
cloudfront.json                                    48.38µ ± 4%   47.03µ ± 1%  -2.79% (p=0.001 n=10)
cloudwatch-events.json                             39.27µ ± 2%   37.86µ ± 1%  -3.58% (p=0.000 n=10)
cloudwatch-logs.json                               66.22µ ± 1%   64.96µ ± 1%  -1.91% (p=0.000 n=10)
custom.json                                        32.01µ ± 2%   30.91µ ± 2%  -3.42% (p=0.000 n=10)
dynamodb.json                                      96.35µ ± 1%   93.89µ ± 1%  -2.55% (p=0.000 n=10)
empty.json                                         29.86µ ± 1%   29.60µ ± 1%       ~ (p=0.089 n=10)
eventbridge-custom.json                            43.60µ ± 2%   42.63µ ± 1%  -2.23% (p=0.029 n=10)
http-api.json                                      72.82µ ± 2%   72.34µ ± 1%       ~ (p=0.123 n=10)
kinesis-batch.json                                 73.00µ ± 2%   70.88µ ± 1%  -2.90% (p=0.000 n=10)
kinesis.json                                       55.27µ ± 2%   53.92µ ± 1%  -2.46% (p=0.000 n=10)
s3.json                                            60.42µ ± 2%   59.73µ ± 3%  -1.15% (p=0.035 n=10)
sns-batch.json                                     90.95µ ± 2%   90.36µ ± 2%  -0.65% (p=0.035 n=10)
sns.json                                           65.83µ ± 1%   65.09µ ± 2%  -1.13% (p=0.035 n=10)
snssqs.json                                        111.0µ ± 1%   110.7µ ± 2%       ~ (p=0.529 n=10)
snssqs_no_dd_context.json                         100.67µ ± 1%   99.79µ ± 2%  -0.88% (p=0.019 n=10)
sqs-aws-header.json                                56.11µ ± 2%   55.45µ ± 2%  -1.17% (p=0.035 n=10)
sqs-batch.json                                     95.91µ ± 3%   95.11µ ± 1%       ~ (p=0.143 n=10)
sqs.json                                           70.28µ ± 3%   69.64µ ± 2%       ~ (p=0.363 n=10)
sqs_no_dd_context.json                             62.69µ ± 2%   61.45µ ± 2%       ~ (p=0.089 n=10)
geomean                                            67.70µ        66.65µ       -1.55%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │          B/op          │     B/op      vs base               │
api-gateway-appsec.json                           37.26Ki ± 0%   37.25Ki ± 0%       ~ (p=0.541 n=10)
api-gateway-kong-appsec.json                      26.92Ki ± 0%   26.92Ki ± 0%       ~ (p=0.839 n=10)
api-gateway-kong.json                             24.41Ki ± 0%   24.42Ki ± 0%       ~ (p=0.288 n=10)
api-gateway-non-proxy-async.json                  48.03Ki ± 0%   48.03Ki ± 0%       ~ (p=0.696 n=10)
api-gateway-non-proxy.json                        47.26Ki ± 0%   47.26Ki ± 0%       ~ (p=0.565 n=10)
api-gateway-websocket-connect.json                25.46Ki ± 0%   25.46Ki ± 0%       ~ (p=0.671 n=10)
api-gateway-websocket-default.json                21.37Ki ± 0%   21.36Ki ± 0%       ~ (p=0.239 n=10)
api-gateway-websocket-disconnect.json             21.15Ki ± 0%   21.15Ki ± 0%       ~ (p=0.725 n=10)
api-gateway.json                                  49.56Ki ± 0%   49.55Ki ± 0%       ~ (p=0.325 n=10)
application-load-balancer.json                    22.33Ki ± 0%   22.33Ki ± 0%       ~ (p=0.341 n=10)
cloudfront.json                                   17.65Ki ± 0%   17.64Ki ± 0%       ~ (p=0.085 n=10)
cloudwatch-events.json                            11.69Ki ± 0%   11.68Ki ± 0%  -0.11% (p=0.001 n=10)
cloudwatch-logs.json                              53.36Ki ± 0%   53.36Ki ± 0%       ~ (p=0.912 n=10)
custom.json                                       9.723Ki ± 0%   9.715Ki ± 0%       ~ (p=0.147 n=10)
dynamodb.json                                     40.77Ki ± 0%   40.76Ki ± 0%       ~ (p=0.324 n=10)
empty.json                                        9.270Ki ± 0%   9.259Ki ± 0%       ~ (p=0.128 n=10)
eventbridge-custom.json                           13.41Ki ± 0%   13.42Ki ± 0%       ~ (p=0.838 n=10)
http-api.json                                     23.72Ki ± 0%   23.72Ki ± 0%       ~ (p=0.986 n=10)
kinesis-batch.json                                27.02Ki ± 0%   27.02Ki ± 0%       ~ (p=0.811 n=10)
kinesis.json                                      17.81Ki ± 0%   17.77Ki ± 0%  -0.18% (p=0.041 n=10)
s3.json                                           20.30Ki ± 0%   20.31Ki ± 0%       ~ (p=0.542 n=10)
sns-batch.json                                    38.69Ki ± 0%   38.66Ki ± 0%       ~ (p=0.165 n=10)
sns.json                                          23.98Ki ± 0%   23.98Ki ± 0%       ~ (p=0.684 n=10)
snssqs.json                                       50.55Ki ± 0%   50.54Ki ± 0%       ~ (p=0.912 n=10)
snssqs_no_dd_context.json                         44.80Ki ± 0%   44.80Ki ± 0%       ~ (p=0.579 n=10)
sqs-aws-header.json                               18.81Ki ± 0%   18.81Ki ± 0%       ~ (p=0.700 n=10)
sqs-batch.json                                    41.63Ki ± 0%   41.60Ki ± 0%       ~ (p=0.517 n=10)
sqs.json                                          25.52Ki ± 1%   25.51Ki ± 0%       ~ (p=0.579 n=10)
sqs_no_dd_context.json                            20.70Ki ± 1%   20.63Ki ± 1%       ~ (p=0.197 n=10)
geomean                                           25.70Ki        25.69Ki       -0.03%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │       allocs/op        │ allocs/op   vs base                 │
api-gateway-appsec.json                             629.0 ± 0%   629.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-kong-appsec.json                        488.0 ± 0%   488.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-kong.json                               466.0 ± 0%   466.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy-async.json                    725.0 ± 0%   725.5 ± 0%       ~ (p=0.650 n=10)
api-gateway-non-proxy.json                          716.0 ± 0%   716.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-connect.json                  453.0 ± 0%   453.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-default.json                  379.0 ± 0%   379.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-disconnect.json               370.0 ± 0%   370.0 ± 0%       ~ (p=1.000 n=10)
api-gateway.json                                    791.0 ± 0%   791.0 ± 0%       ~ (p=1.000 n=10)
application-load-balancer.json                      352.0 ± 0%   352.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudfront.json                                     284.0 ± 0%   284.0 ± 0%       ~ (p=0.303 n=10)
cloudwatch-events.json                              220.0 ± 0%   220.0 ± 0%       ~ (p=0.474 n=10)
cloudwatch-logs.json                                215.0 ± 0%   215.0 ± 0%       ~ (p=1.000 n=10)
custom.json                                         168.0 ± 1%   168.0 ± 0%       ~ (p=0.474 n=10)
dynamodb.json                                       589.0 ± 0%   589.0 ± 0%       ~ (p=0.178 n=10)
empty.json                                          159.0 ± 1%   159.0 ± 1%       ~ (p=1.000 n=10)
eventbridge-custom.json                             254.0 ± 0%   254.0 ± 0%       ~ (p=0.677 n=10)
http-api.json                                       432.5 ± 0%   432.0 ± 0%       ~ (p=1.000 n=10)
kinesis-batch.json                                  391.0 ± 0%   391.0 ± 0%       ~ (p=1.000 n=10)
kinesis.json                                        285.0 ± 0%   285.0 ± 0%       ~ (p=0.393 n=10)
s3.json                                             357.0 ± 0%   357.0 ± 0%       ~ (p=1.000 n=10)
sns-batch.json                                      455.0 ± 0%   455.0 ± 0%       ~ (p=0.092 n=10)
sns.json                                            323.0 ± 0%   323.0 ± 0%       ~ (p=0.559 n=10)
snssqs.json                                         438.0 ± 0%   438.0 ± 0%       ~ (p=0.791 n=10)
snssqs_no_dd_context.json                           399.5 ± 0%   399.0 ± 0%       ~ (p=0.966 n=10)
sqs-aws-header.json                                 274.0 ± 0%   274.0 ± 0%       ~ (p=0.730 n=10)
sqs-batch.json                                      503.0 ± 0%   503.0 ± 0%       ~ (p=1.000 n=10)
sqs.json                                            350.5 ± 1%   350.0 ± 1%       ~ (p=0.632 n=10)
sqs_no_dd_context.json                              325.0 ± 1%   324.0 ± 1%       ~ (p=0.157 n=10)
geomean                                             376.3        376.2       -0.02%
¹ all samples are equal

[dd-devflow[bot]]

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!